From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30BB4242D7F; Sun, 3 May 2026 14:52:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777819981; cv=none; b=iknNa4HcyKcyCENKb0JoU9HsyhOAQSHuKytKnNjD4bpxnkJktPq16S92gOr5BPuO3qIDz48ZEPpH/RCEbEBtcqxOQjrd5yamOh2FCP/z4/9MLR2+TsdVznwvdB7qENZlUE0c44QTqBkh+IxhrrndqvqLCFrGWmDE4aCUjQJG5OE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777819981; c=relaxed/simple; bh=C2wVE/sIvMEAvhthdCARXccZQpF7oYZBLXDphUbG2Os=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nEUlNNuwV8WqwWKn/38HR36ist6M0xCLQFMuhqLpFfY6zp2SpDIm9nZx1Fl1F14WuBHWj+iRmv5SnRhpFf51snjEVawBXHvZ8qeGRa/ksMm+1CSk+m+XEDjDNT/+Ak49krZgHZ8+O4B0BEdYz9SfHbYgx+Ze/RsFqBlMmUDDE1o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ZC4QxfIJ; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ZC4QxfIJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777819978; x=1809355978; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=C2wVE/sIvMEAvhthdCARXccZQpF7oYZBLXDphUbG2Os=; b=ZC4QxfIJFxqtdVeZuBFlIdYwSUBUbO0GQysUBEIzH0UAyTl1tyqGCREA DUUSBdbTew7FxIfJMSUAAunZOQRYyqp9NLZtcrLKcid0SftaMAeV+Lsw3 QK1QcZXIHjJqLDjT3Be3aenVS3E/vHgI3n5xKOU6PjGrnpCKMCU0HpxJJ Ho83EyxqwX+J0SWhetB+6bEAx+z8sxCUlArKVdeXp+z0O+mrZtG6cRsrA P62bNAYCsvjOBm0bRYN5xBV4uU/qr/2AWl8d63TtC1vlf1U+MQHfgpq4V 94g+rRGesxm/GxAkyDkC+oiwOaqF0PzmuDrPtTspvVJJvgLcaEcKNfU+C w==; X-CSE-ConnectionGUID: ujwkU1v8TzKSsP82iOTH0A== X-CSE-MsgGUID: Z/9Bd5KlQ1udPI83KnG9Iw== X-IronPort-AV: E=McAfee;i="6800,10657,11775"; a="104153667" X-IronPort-AV: E=Sophos;i="6.23,213,1770624000"; d="scan'208";a="104153667" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 May 2026 07:52:57 -0700 X-CSE-ConnectionGUID: aA34QxKrQW+Vx0+WNBfInA== X-CSE-MsgGUID: ydHjP4+nTxatXV3fjKeqDw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,213,1770624000"; d="scan'208";a="228801147" Received: from lkp-server01.sh.intel.com (HELO 781826d00641) ([10.239.97.150]) by fmviesa009.fm.intel.com with ESMTP; 03 May 2026 07:52:55 -0700 Received: from kbuild by 781826d00641 with local (Exim 4.98.2) (envelope-from ) id 1wJYBg-000000002ez-0Ojf; Sun, 03 May 2026 14:52:52 +0000 Date: Sun, 3 May 2026 22:51:54 +0800 From: kernel test robot To: Guangshuo Li , Sakari Ailus , Bingbu Cao , Mauro Carvalho Chehab , Greg Kroah-Hartman , Hans Verkuil , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: oe-kbuild-all@lists.linux.dev, linux-media@vger.kernel.org, Guangshuo Li Subject: Re: [PATCH] media: staging/ipu7: Fix pdata double free in init error paths Message-ID: <202605032224.WHCEx7uc-lkp@intel.com> References: <20260430053820.446080-1-lgs201920130244@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260430053820.446080-1-lgs201920130244@gmail.com> Hi Guangshuo, kernel test robot noticed the following build errors: [auto build test ERROR on staging/staging-testing] url: https://github.com/intel-lab-lkp/linux/commits/Guangshuo-Li/media-staging-ipu7-Fix-pdata-double-free-in-init-error-paths/20260501-032323 base: staging/staging-testing patch link: https://lore.kernel.org/r/20260430053820.446080-1-lgs201920130244%40gmail.com patch subject: [PATCH] media: staging/ipu7: Fix pdata double free in init error paths config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20260503/202605032224.WHCEx7uc-lkp@intel.com/config) compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260503/202605032224.WHCEx7uc-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202605032224.WHCEx7uc-lkp@intel.com/ All errors (new ones prefixed by >>): drivers/staging/media/ipu7/ipu7.c: In function 'ipu7_isys_init': >> drivers/staging/media/ipu7/ipu7.c:2176:33: error: passing argument 1 of 'ERR_CAST' makes pointer from integer without a cast [-Wint-conversion] 2176 | return ERR_CAST(ret); | ^~~ | | | int In file included from include/linux/cleanup.h:6, from include/linux/acpi.h:11, from drivers/staging/media/ipu7/ipu7.c:6: include/linux/err.h:102:64: note: expected 'const void *' but argument is of type 'int' 102 | static inline void * __must_check ERR_CAST(__force const void *ptr) | ~~~~~~~~~~~~^~~ drivers/staging/media/ipu7/ipu7.c: In function 'ipu7_psys_init': drivers/staging/media/ipu7/ipu7.c:2221:33: error: passing argument 1 of 'ERR_CAST' makes pointer from integer without a cast [-Wint-conversion] 2221 | return ERR_CAST(ret); | ^~~ | | | int include/linux/err.h:102:64: note: expected 'const void *' but argument is of type 'int' 102 | static inline void * __must_check ERR_CAST(__force const void *ptr) | ~~~~~~~~~~~~^~~ vim +/ERR_CAST +2176 drivers/staging/media/ipu7/ipu7.c 2125 2126 static struct ipu7_bus_device * 2127 ipu7_isys_init(struct pci_dev *pdev, struct device *parent, 2128 const struct ipu_buttress_ctrl *ctrl, void __iomem *base, 2129 const struct ipu_isys_internal_pdata *ipdata, 2130 unsigned int nr) 2131 { 2132 struct fwnode_handle *fwnode = dev_fwnode(&pdev->dev); 2133 struct ipu7_bus_device *isys_adev; 2134 struct device *dev = &pdev->dev; 2135 struct ipu7_isys_pdata *pdata; 2136 int ret; 2137 2138 ret = ipu7_isys_check_fwnode_graph(fwnode); 2139 if (ret) { 2140 if (fwnode && !IS_ERR_OR_NULL(fwnode->secondary)) { 2141 dev_err(dev, 2142 "fwnode graph has no endpoints connection\n"); 2143 return ERR_PTR(-EINVAL); 2144 } 2145 2146 ret = ipu_bridge_init(dev, ipu_bridge_parse_ssdb); 2147 if (ret) { 2148 dev_err_probe(dev, ret, "IPU bridge init failed\n"); 2149 return ERR_PTR(ret); 2150 } 2151 } 2152 2153 pdata = kzalloc_obj(*pdata); 2154 if (!pdata) 2155 return ERR_PTR(-ENOMEM); 2156 2157 pdata->base = base; 2158 pdata->ipdata = ipdata; 2159 2160 isys_adev = ipu7_bus_initialize_device(pdev, parent, pdata, ctrl, 2161 IPU_ISYS_NAME); 2162 if (IS_ERR(isys_adev)) { 2163 dev_err_probe(dev, PTR_ERR(isys_adev), 2164 "ipu7_bus_initialize_device isys failed\n"); 2165 kfree(pdata); 2166 return ERR_CAST(isys_adev); 2167 } 2168 2169 isys_adev->mmu = ipu7_mmu_init(dev, base, ISYS_MMID, 2170 &ipdata->hw_variant); 2171 if (IS_ERR(isys_adev->mmu)) { 2172 ret = PTR_ERR(isys_adev->mmu); 2173 dev_err_probe(dev, ret, 2174 "ipu7_mmu_init(isys_adev->mmu) failed\n"); 2175 put_device(&isys_adev->auxdev.dev); > 2176 return ERR_CAST(ret); 2177 } 2178 2179 isys_adev->mmu->dev = &isys_adev->auxdev.dev; 2180 isys_adev->subsys = IPU_IS; 2181 2182 ret = ipu7_bus_add_device(isys_adev); 2183 if (ret) 2184 return ERR_PTR(ret); 2185 2186 return isys_adev; 2187 } 2188 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki