From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB9893AD510 for ; Sun, 3 May 2026 09:01:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777798882; cv=none; b=SXpvCc1Z1/chxHWgZxIyMntcf4ePTrYTmQOmERxhzYlCMWZ0j/jDBY6I7lMLoNzG+kmxv1ltSNUEKW2KAfRjLUwrLX62O/k7qHep8sKGQ3IxexXfku7zfK+7T+xmhGpGiEUURmFnCbWTvbCYnEoQeoIfDo7knUcwg8zXmftMH6g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777798882; c=relaxed/simple; bh=LfticMICtCXefB5YzgWW1TvsF95SQdaYwJoQ3BZ4rKQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cKKNom0xJF/MgvKSvSRHjYJ7TcKXPHcSVlYvBQt/nQECwW2sm/17ujxhAgkPbvMswmWl7MSBD0emCibmw+neSYIeNmbyQ2+BZIG8Rs6+tZVKgIKRL2HwApP65aPkoMyFEXFPskWjHZGC/fKArsHS+0hLoSfXO3GjzYPwcKjwzzw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=AuX7fOHH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="AuX7fOHH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20192C2BCB4; Sun, 3 May 2026 09:01:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1777798882; bh=LfticMICtCXefB5YzgWW1TvsF95SQdaYwJoQ3BZ4rKQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AuX7fOHHQFzPDuHO8hmfpCIbDGDif6VFmTKbLHeqYa5Vr5CrK/pCyyBKev8lh+wSr BoVW1D8OFcA5VZ5e/znbcQb4ng9PuxtgqAI6HAWcTUioTh0N75cKw028eQ8XGWYB2F Bwhi0NtGrEYKzqgJ9pWQu5XYjSTXoi+/gqrvbvnw= Date: Sun, 3 May 2026 11:00:41 +0200 From: Greg KH To: Moksh Panicker Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: rtl8723bs: Remove unnecessary braces in rtl8723bs_xmit.c Message-ID: <2026050327-seminar-aspirate-d008@gregkh> References: <2026050326-photo-untamed-82cb@gregkh> <20260503083220.8852-1-mokshpanicker.7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260503083220.8852-1-mokshpanicker.7@gmail.com> On Sun, May 03, 2026 at 08:32:20AM +0000, Moksh Panicker wrote: > Braces are not necessary for single statement blocks. > This fixes the following checkpatch.pl warning: > > WARNING: braces {} are not necessary for single statement blocks > > Signed-off-by: Moksh Panicker > --- > drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c > index ff39077deb69..d30c5e70625a 100644 > --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c > +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c > @@ -395,9 +395,9 @@ static s32 rtl8723bs_xmit_handler(struct adapter *padapter) > spin_lock_bh(&pxmitpriv->lock); > ret = rtw_txframes_pending(padapter); > spin_unlock_bh(&pxmitpriv->lock); > - if (ret == 1) { > + if (ret == 1) > goto next; > - } > + > > return _SUCCESS; > } > -- > 2.34.1 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot