public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ajanth Badiger <badigerajanth1301@gmail.com>
Cc: dpenkler@gmail.com, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: gpib: gpio: use sizeof(*ptr) in kzalloc
Date: Sun, 3 May 2026 11:48:12 +0200	[thread overview]
Message-ID: <2026050352-alike-scribing-ef3c@gregkh> (raw)
In-Reply-To: <20260503093558.68105-1-badigerajanth1301@gmail.com>

On Sun, May 03, 2026 at 03:05:58PM +0530, Ajanth Badiger wrote:
> Replace sizeof(struct bb_priv) with sizeof(*board->private_data)
> to follow kernel coding style and improve maintainability.
> 
> checkpatch.pl also reports that LINVAL macro should be enclosed
> in parentheses. However, LINVAL intentionally expands to a
> comma-separated list of arguments matching the LINFMT format
> string used in dbg_printk() calls.
> 
> Wrapping it in parentheses would change semantics due to the
> comma operator, causing only the last expression to be passed.
> 
> Therefore, no change is made to LINVAL.
> 
> Signed-off-by: Ajanth Badiger <badigerajanth1301@gmail.com>
> ---
>  drivers/staging/gpib/gpio/gpib_bitbang.c | 2 +-

This file is not in the tree, what version did you make this against?
Please always use linux-next for development work.

thanks,

greg k-h

      reply	other threads:[~2026-05-03  9:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-03  9:35 [PATCH] staging: gpib: gpio: use sizeof(*ptr) in kzalloc Ajanth Badiger
2026-05-03  9:48 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026050352-alike-scribing-ef3c@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=badigerajanth1301@gmail.com \
    --cc=dpenkler@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox