From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f51.google.com (mail-oa1-f51.google.com [209.85.160.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8D0631B131 for ; Mon, 4 May 2026 20:45:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777927527; cv=none; b=j0Q2KaO2OaX5AeRRjuOA/JO9fxCqpUXUjjPfDlD+ESv4H1MmCQl+Ya0JtDbLn5OKLrp94sbLiaAfumZACUDcRfHlUl27rC/rYrs4ndqOxhK0BssBxrTPZtLOf0+H7B+CtWG68fEuxnq/N/MwKCewq/0Qxscl93C93lrC87dCpOc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777927527; c=relaxed/simple; bh=fQtxjBBlsfrbVNeHFs+VzNlAPJfQpt7R7uonizgiLgM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=C+wbCgHa8dMAaTDfmvHBWO2yuh6SzMgnLFz0R/o37EH/cmvMVfSuoO6C9VomFcK/1Cw72BfKIndBAaRmUMlQdSPkRmhaiHBbARvOd/OwvsbTeOthXw/rHyMMJjokdsrKDUAtEgnj+WaJQlyHX0RwITB75mkx9Je7iWp3isLrj5s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lv9eJXyq; arc=none smtp.client-ip=209.85.160.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lv9eJXyq" Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-40f1a1f77a6so3618484fac.2 for ; Mon, 04 May 2026 13:45:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777927521; x=1778532321; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=V0og+a8kac0IiyPYwMTiYKdKkV179BGjDAZzwYpwxKg=; b=lv9eJXyqRYzjGnA0fTU+PUUzBqf91Fm+wBP8kea835C5BTCD1IPa2NYiGq0vxENsly UEXSv3Klujg4Wwnx90jTLd5+8stby1/ODBRsKiSAhalTJ2aDcqD5kYtJvsyNDGYPAAAB OWP0jjJXEDUafr3CODz8BJc5pePccpcz+Me4fdFsexPUnKpK+b6NZw28BVX/+1+tNLLR ojH/VNt158fCCMrfyME65G4i6fAT7vPoAR/lOOO5jU+ut0vFRATLWQbiGUTkx1gn4ydd zBhS5t1715HcAzzSWieHh1TN9/3f7fAvW3Q/7OF3KAfK5C3TXdtHPb8eRYoxMg73eEUA /rhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777927521; x=1778532321; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=V0og+a8kac0IiyPYwMTiYKdKkV179BGjDAZzwYpwxKg=; b=DgvzjowyqgKwJ3pjJPWLObCf8xEwv71IRYATSG08xiO5+3ayCKfWJnKs84TrnvYOkq m5ENCvaxi5WZlG1GLMMK3DLUcvNfoou3yGpWUQ+Lj1jW/90CiSKiAePme+xdH8aHln9K 6OUdKni0FgKBwYxMRGlBTTP5vu1gXwK9PnGJqxtOgmbySPVKk8dx1wSfUxJCJa1K6a/S zKIcq+96AE7Sn65mIrguKgbDFRif+/2ho8c1M+1Z9bmW6TiDzP+4Pydx7ki63sOMLeow HfcABi6e+mjxc2Fz2WbG2ZeoXrpcudM7CXIcVpivbG+n83DXRypxmrqtj7VMfExV4LxR cuhQ== X-Gm-Message-State: AOJu0Yx1ZG5Kh9UmnXK1SvrvPo08pcuSfMtX78uVrDR5givkqDRRVjF6 8WmSe+Zet6+3AVAn7dL6xO2uoh9oi1cxYfOIiF/SiqwHVGDKXjcE2s6P X-Gm-Gg: AeBDiev2jpsjdxHKLh12A7DK+7TpmMANckHLiDzpw/enMi4XcTl/smeaos0eHHIzUf2 llAu/J/f5b96MU+jjLGt1etcTGVnk0lvulBI0h02HHpAPxSPnZ1YwayOclTVG7TXslGMlh8DJgJ 2RXlw7ElIOqEPo7RkmbGUSarKQMOogclbs5IkOqo+T2lKbQvPVQvJUYmfWvv01E1l1+VDVLs6lZ WqjtkYDX4IJVhIa+FaO7iaZV7ocL1g0hvRxJg26TTopKRtiJaH+2srOsbdiA0mxfaJ0y8B5cYQ3 2mR2sFAqkhHTxpgvtwCAx3mPnS6H5Wiv/qJRw9uD79r4NbcgJSm17YX8UxDLDKwDOOj5oQaK8fO homMTOgdSVmdcr58my4d5D/tO5lXHXEQNblZg8lB20PGVL77Kmf+RGh7GgnvTP8WnyystkcH0XG S6f2H3paAz3VXslTPtbFJO/Exu5seyQQqPe775zz79GUfdiZUIN6CRqCEvaRsHyyvgEzpWKMCu X-Received: by 2002:a05:6820:1687:b0:696:6bf1:b8da with SMTP id 006d021491bc7-69697d69e55mr5450314eaf.42.1777927521511; Mon, 04 May 2026 13:45:21 -0700 (PDT) Received: from [100.82.231.29] (c-98-38-17-99.hsd1.co.comcast.net. [98.38.17.99]) by smtp.googlemail.com with ESMTPSA id 006d021491bc7-69689266bacsm7144713eaf.0.2026.05.04.13.45.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 13:45:20 -0700 (PDT) From: Jim Cromie Date: Mon, 04 May 2026 14:45:10 -0600 Subject: [PATCH 04/17] dyndbg: make ddebug_class_param union members same size Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260504-dd-cleanups-2-v1-4-6fdd24040642@gmail.com> References: <20260504-dd-cleanups-2-v1-0-6fdd24040642@gmail.com> In-Reply-To: <20260504-dd-cleanups-2-v1-0-6fdd24040642@gmail.com> To: Andrew Morton , Jason Baron , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Shuah Khan , Louis Chauvet Cc: linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, linux-kselftest@vger.kernel.org, Jim Cromie X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777927513; l=1479; i=jim.cromie@gmail.com; s=20260203; h=from:subject:message-id; bh=fQtxjBBlsfrbVNeHFs+VzNlAPJfQpt7R7uonizgiLgM=; b=ttLRyXE6cZ85k5IAGBKzfNeOHmjsQMSdBe0oJuY+GuqeR5kO7dRO2UTAOXb6Z/uCC5xzVY3Uu k7pB5IiC37BAmfaXmLuWDjqegWQkmZL7ULDACaH/AQppR+9Hq0uDuxo X-Developer-Key: i=jim.cromie@gmail.com; a=ed25519; pk=C6E5ODlPQo7ZBynATXH9wg7K6HxP0pIXyf4s38Qw0XE= struct ddebug_class_param keeps a ref to the state-storage of the param; make both class-types use the same unsigned long storage type. ISTM this is simpler and safer; it avoids an irrelevant difference, and if 2 users somehow get class-type mixed up (or refer to the wrong union member), at least they will both see the same value. Reviewed-by: Louis Chauvet Signed-off-by: Jim Cromie --- include/linux/dynamic_debug.h | 2 +- lib/dynamic_debug.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h index a10adac8e8f0..441305277914 100644 --- a/include/linux/dynamic_debug.h +++ b/include/linux/dynamic_debug.h @@ -104,7 +104,7 @@ struct _ddebug_info { struct ddebug_class_param { union { unsigned long *bits; - unsigned int *lvl; + unsigned long *lvl; }; char flags[8]; const struct ddebug_class_map *map; diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index a9caf84ddb22..ffa1cf7c2c72 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -811,7 +811,7 @@ int param_get_dyndbg_classes(char *buffer, const struct kernel_param *kp) case DD_CLASS_TYPE_LEVEL_NAMES: case DD_CLASS_TYPE_LEVEL_NUM: - return scnprintf(buffer, PAGE_SIZE, "%d\n", *dcp->lvl); + return scnprintf(buffer, PAGE_SIZE, "%ld\n", *dcp->lvl); default: return -1; } -- 2.54.0