From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3893D351C22 for ; Mon, 4 May 2026 10:55:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777892108; cv=none; b=WhtQrUrReFWY/ZnB26FVEBanAatVovVqnZ50xfnqKjupHy51mQqQuOAI8FbMCFMG7wodOErH9q/UZYRglztpHvlDs3CnD0SpM4Ri4VNDO5ajDFAOWSlQ1sfk1/yYS/GtP8lrcyyj/ovVlePa/70TikdV/49u3BUFLsdMvVZvUjI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777892108; c=relaxed/simple; bh=+dgffLgBiEP6ZBRGedun1KaOTrk/q8XcHD/7lgiAyQE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=cP1PNHlj2DhTrRTX2Otmx9w/2iBPb9VLr5R01BVFKRX4jGpxm0WS4/TKkYYoUZ8PAGYx1blwqlvgXO2JTtgGgqq2BJ++8c365sPpl6n1BaSKvlqo+HzQNPrx82WaevWV8uXbq/1JjRzrAMxBwGnIaUIkT0cBdr7TGm1wd4i8Deo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=aHCG4sEt; arc=none smtp.client-ip=209.85.208.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="aHCG4sEt" Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-393925cb1baso13488971fa.0 for ; Mon, 04 May 2026 03:55:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1777892105; x=1778496905; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=ZcDLjx4hLgTrt8Ve4u4lIZsmkmGxyF9I6wHEUsyYi7c=; b=aHCG4sEtExwCG0zgv0l48pTohS4tt2KR1AyCDBSxrEuVHN68AnRzO9OYWsotnCZ6fY 7jIQDGyHAMcp3bzt5j125jPvikl0GmkCLEaCw5NquWK7xAnE/UYrU8PDTCZB0V6hlEES DHGi1HB6dvI960WOJKTOQIqRliCMeoKMx5elk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777892105; x=1778496905; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZcDLjx4hLgTrt8Ve4u4lIZsmkmGxyF9I6wHEUsyYi7c=; b=jUh/KgeMUY4I/FV+EvpZeDtnht89qmMwS2XmxCj0h3EdTJhJxOwEpOubVmPm/9Fra7 4QocS9c9B/CEKt9WC47rn8PGItmaIOK8Oxi7qO+6z66YQDOHEAfUxbnwuo5r90JsJKR3 xmnFbSQyhEtPRR/LNs4tZ4zb5/eaN5uyyim9MvJ6c33/k+nxkQo7NKVKNi0dYi6aUJfm ucKAr2Xd+L7SaTb6D6PAb1TVWyfUXHlgc9fCg+KYycxEzxu9riNnD6kO55FDlx5ZcC6p cZkyUW+L4ylVcFZ1Ul+A5yksloT5WE9AbSHAc+g8+CS14TS6uo+1Jj9vzeN8XiGJ4DxS amvw== X-Forwarded-Encrypted: i=1; AFNElJ86vOs0FRt1csQmkGKw9/5xMZmBcW36yxjcbPuQamHcqKFtoeljLFx510v8ZC7Wdfz6gOA9TQRznX9pLog=@vger.kernel.org X-Gm-Message-State: AOJu0Yzb7+fz4sJdG1AbR1xQlje9ayptiTC9M2VzWVrZ4ulx821eklbQ GyvLG+EGCYCoHeWx6vdaLnOWCVH3Eiy854Vgd4NpN0qXBfxGDD8jyGpGRR4SLqhkxw== X-Gm-Gg: AeBDiesz9kqtB2JbiAUQmvNbrClORZA0Ku91y/oFMDYJaJUtoHnih7eIQDZSvIaPp7V 1RbQDa0j31V3P59+GUV9yKWjFLNRaS4HX6eth4ePPPcc22Eo3m2ka9Ncjct4Kb+PYyZTU+Pvgle IdN82YEmAvm3ZL8RAv3xMJnAFhHdOWq+o3kij2ePidQBv8wsx/M4XbKQYC17S2ydjKFHMFdiGf0 1FN6Fhsg0e2Dezak8XxTMl9xOt6X5Gu/OdQ/Rt3kY7zqpkPR+jAXdMsNCokhyv/ez/1AQwkOxNT wIqGAiKT07lLEVclqyC4y6o+tYJq+NWK43bBDIkxHy5dH750G9AK4gwY7u3DMP8jX1pD+iC4fmb MS1m23GouWeqn6+2dUyIL7SSZVNaYSL78gHxkvO56G9EOr16oceffAyzMnxE+at2VjJjCrCDTTA rhdHfb33RhhCLrLiCcJ1oSus+0PudS1qGZCj0z7UNDOjo+WF3kQG/LSvDpcyP4RIxG8GuPI5jxP vFrchNJIxYfpiBY/A== X-Received: by 2002:a05:651c:2116:b0:38a:45d6:c246 with SMTP id 38308e7fff4ca-393783ef512mr33168221fa.8.1777892105339; Mon, 04 May 2026 03:55:05 -0700 (PDT) Received: from ribalda.c.googlers.com (52.163.228.35.bc.googleusercontent.com. [35.228.163.52]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-39361323c56sm28904411fa.29.2026.05.04.03.55.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 03:55:04 -0700 (PDT) From: Ricardo Ribalda Date: Mon, 04 May 2026 10:55:03 +0000 Subject: [PATCH] Input: atmel_mxt_ts - Set byte_offset as signed Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260504-fix-sparse-v1-1-1071137cd280@chromium.org> X-B4-Tracking: v=1; b=H4sIAAZ7+GkC/x2MQQqAIBAAvyJ7TjBLD30lOqy11l5MXIhA/HvSc RhmKggVJoFFVSj0sPCdOoyDgv3CdJLmozNYY71xZtaRXy0Zi5CeQkQf0FtyAXqQC3X7z9attQ9 RBWiQXAAAAA== X-Change-ID: 20260504-fix-sparse-3bfa6ba62e5b To: Nick Dyer , Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.14.3 The calculations done to obtain byte_offset can result into a negative number, fix its type. This patch fixes the following sparse error: drivers/input/touchscreen/atmel_mxt_ts.c:1481:44: warning: unsigned value that used to be signed checked against zero? drivers/input/touchscreen/atmel_mxt_ts.c:1479:49: signed value source Signed-off-by: Ricardo Ribalda --- drivers/input/touchscreen/atmel_mxt_ts.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index 87c6a10381f2..26ba82fb60b6 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -1397,7 +1397,8 @@ static int mxt_prepare_cfg_mem(struct mxt_data *data, struct mxt_cfg *cfg) { struct device *dev = &data->client->dev; struct mxt_object *object; - unsigned int type, instance, size, byte_offset; + unsigned int type, instance, size; + int byte_offset; int offset; int ret; int i; --- base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731 change-id: 20260504-fix-sparse-3bfa6ba62e5b Best regards, -- Ricardo Ribalda