Re: [PATCH v4 07/17] iio: magnetometer: ak8975: pass conversion timeouts as arguments

Andy Shevchenko
2026-05-04T14:06:24Z

On Mon, May 04, 2026 at 01:25:11PM +0200, Joshua Crofts wrote:
> On Mon, 4 May 2026 at 13:10, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Mon, May 04, 2026 at 11:48:19AM +0200, Joshua Crofts via B4 Relay wrote:

...

> > Hmm... I don't think we need those, esp. taking into account the difference in
> > the timeout_ms for different cases.
>
> Okay, this was suggested by Jonathan on your v0 version, but I guess there
> is no need now that there are poll and timeout parameters added in the function
> (or maybe the suggestions were for the parameters only and I
> misinterpreted them).

The idea is to see them on an average one page in the text editor, all of them
at once. As long as they are quite close to each other, the temporary variables
are not needed. Moreover, I found them a nit harmful in terms of readability as
one will need to jump over the code to see the values, while with explicit
numbers it's all being concentrated in a small code stanza.

--
With Best Regards,
Andy Shevchenko