Re: [PATCH v4 06/17] iio: magnetometer: ak8975: modernize polling loops with iopoll() macros

Andy Shevchenko
2026-05-05T08:17:14Z

On Tue, May 05, 2026 at 10:07:57AM +0200, Joshua Crofts wrote:
> On Tue, 5 May 2026 at 09:26, Joshua Crofts <joshua.crofts1@gmail.com> wrote:
> > > It's better to integrate it into the series either as a fix (should be first in
> > > the series) or as just an improvement after readx_*() conversion patch.
> >
> > Better to do it as an improvement after readx_(), rebasing would be easier. I do
> > agree with it being added as a separate patch though.
>
> Before I forget, is it better to return the negative 'val' or -EINVAL?

The (negative) contents of val. Shadowing the error code must be justified.

--
With Best Regards,
Andy Shevchenko