Re: [PATCH v4 07/17] iio: magnetometer: ak8975: pass conversion timeouts as arguments

Joshua Crofts
2026-05-04T14:12:01Z

On Mon, 4 May 2026 at 16:06, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> > Okay, this was suggested by Jonathan on your v0 version, but I guess there
> > is no need now that there are poll and timeout parameters added in the function
> > (or maybe the suggestions were for the parameters only and I
> > misinterpreted them).
>
> The idea is to see them on an average one page in the text editor, all of them
> at once. As long as they are quite close to each other, the temporary variables
> are not needed. Moreover, I found them a nit harmful in terms of readability as
> one will need to jump over the code to see the values, while with explicit
> numbers it's all being concentrated in a small code stanza.

You've convinced me :)

--
Kind regards

CJD