Re: [PATCH v4 00/17] iio: magnetometer: ak8975: modernize and cleanup driver

Andy Shevchenko
2026-05-04T11:01:53Z

On Mon, May 04, 2026 at 11:48:12AM +0200, Joshua Crofts via B4 Relay wrote:
> This series modernizes and cleans up the ak8975 driver, migrating to
> more modern kernel APIs and cleaning up legacy code. Patches 7 through
> 17 were provided by Andy Shevchenko.
>
> The series was compile-tested and ran in QEMU with i2c-stub and
> no issues were found.
>
> The patch regarding switching to devm_* functions might have to
> go through an additional revision, otherwise everything else seems
> good to go.
>
> Changes include:
> - replacing usleep_range() with fsleep() for optimization
> - migrating to iopoll macros for better device polling
> - removing unused headers and adding new ones
> - checkpatch.pl fixes
> - switching driver to use devm_* functions
>
> v2:
> - PATCH 1: reverted alphabetical header ordering per logical change
> separation
> - PATCH 2: added newline between fsleep() and return
> - PATCH 3: fixed open parenthesis formatting
> - PATCH 4: fixed whitespace issues, added <linux/time.h> for
> USEC_PER_MSEC macro
> v3:
> - PATCH 1 & 2: split alphabetical ordering and header removal into two
> separate patches
> - PATCH 4: commit message fix
> - PATCH 5 & 6: split error handling and polling loop replacement into
> two separate patches
> v4:
> - PATCH 7-17: am Andy's changes into this series
> - PATCH 2, 5, 6: fixup Andy's changes to existing patches

Co-developed for those is too strong. Just use your SoB only.
You may use my Reviewed-by though.

Taking this into account, you can wait a day and send a new version with that
and --base fixed. Also it gives me and others a chance to briefly look into
the contents and see if everything looks okay.

--
With Best Regards,
Andy Shevchenko