Re: [PATCH v2 2/2] dt-bindings: mmc: st,sdhci: convert to DT schema

Charan Pedumuru
2026-05-06T13:56:01Z

On 04-05-2026 13:13, Krzysztof Kozlowski wrote:
> On Sun, May 03, 2026 at 08:35:30AM +0000, Charan Pedumuru wrote:
>> +$id: http://devicetree.org/schemas/mmc/st,sdhci.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: STMicroelectronics SDHCI-ST MMC/SD Controller
>> +
>> +description:
>> + The STMicroelectronics SDHCI-ST MMC/SD host controller, which is
>> + compliant with the SD Host Controller Interface (SDHCI) specification and
>> + is used to interface with MMC, SD and SDIO cards. The ST SDHCI controller
>> + extends the standard SDHCI capabilities with platform-specific
>> + configurations such as additional register regions,clock inputs, and delay
>> + control mechanisms required for signal timing adjustments which are
>> + necessary to support high-speed modes and ensure reliable data transfer
>> + across different ST SoCs.
>> +
>> +allOf:
>> + - $ref: mmc-controller.yaml#
>> +
>> +maintainers:
>> + - Peter Griffin <peter.griffin@linaro.org>
>> +
>> +properties:
>> + compatible:
>> + oneOf:
>> + - const: st,sdhci
>> + - items:
>> + - const: st,sdhci-stih407
>> + - const: st,sdhci
>> +
>> + reg:
>> + minItems: 1
>> + items:
>> + - description: Base address and size of the MMC controller registers
>
> s/Base address and size of the//

Okay, I will remove these words.

>
>> + - description: Base address and size of the MMC delay/auxiliary registers
>
> Here the same

Okay.

>
>> +
>> + reg-names:
>> + oneOf:
>> + - items:
>> + - const: mmc
>
> Drop three lines above

Sure.

>
>> + - items:
>
> So this is just items like you have in "reg" part. Same syntax.
>
>> + - const: mmc
>> + - const: top-mmc-delay
>> +
>> + clocks:
>
> Here and:

Should I add minItems and maxItems instead of items?

>
>> + items:
>> + - description: Clock for the MMC controller
>> + - description: Interconnect (ICN) clock
>> +
>> + clock-names:
>
> here: Old binding icn is optional. You need to explain in the commit msg
> all the changes done during conversion.

Okay, I will write this change in commit message.

>
>> + items:
>> + - const: mmc
>> + - const: icn
>> +
>> + interrupts:
>> + maxItems: 1
>> +
>> + interrupt-names:
>> + const: mmcirq
>> +
>> + resets:
>> + maxItems: 1
>
> Best regards,
> Krzysztof
>

--
Best Regards,
Charan.