From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2EC9378812 for ; Mon, 4 May 2026 14:53:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777906414; cv=none; b=uckSmiJnEqXSF62bhf2wK74I78uPeNb8K0qeoc4m9XLvb+STnJkQ+Z8XL0YKwNTWu0zTxralXKk8FvN0PEcnzHMyh/FQ6Mpolycku2QpGilXUHekotKwM8zPipQ9sRUEIDd4lA15ilT/TVjYc71yfe1dUqRw7FF9wS4meDqprvY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777906414; c=relaxed/simple; bh=KsGehUIs9yjLgFhJm+ALM6CihYTUD9IxFPyF+rbn54Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=V0IxY7KuykE7tIqSmGVq5U2Rd8/YPcE6m0Lk91L3kjftk8+rbqAWB0gwjzecVv/HJqqTfj9hjl7urELS57YBZN0paqPxKJvlsakLZ40qOYoz/fRfkT5UgQ+Uc7KXiCIuEgOY6Ve7KYS8o+lnQmPUX9kup7D+ygWLJN0DoisKgwo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Vnni7daF; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Vnni7daF" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-362bb3260f1so3022570a91.2 for ; Mon, 04 May 2026 07:53:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777906413; x=1778511213; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=L68A0nliiu2Q3xuxzZG34RHvsW2Cqh1HButFAloiLuY=; b=Vnni7daFHiQtPUTPwAC5VPvcWlkiSfDDTcHDsOguprYLJCPCctBmQbXXOymx4dLJNx kD6L/+pO886c3Zg+EzpQRwX3JP9kB7Gv1HkiKSejZ6L/CVbCEa2SRBJBLEZRn0D3rWtE vUL1Ljig/PPfB+MZi8fyK7iF30EXtU2eJCKUS2FH17VR96qwrwOgEzmpyIpq0dUTqa+i ObODjY94AR4wuogW3s7fqlOzeUofbVZfCNFIcks97AOif4vp+hU2mSf662o3x73kN5De Tz+y2YMqGR5H3SiH1+6KLQq5A+9jO0+M4vjHLM2Gu/U2JzaKk1w8eUiF1qEUyStlOJQo w6Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777906413; x=1778511213; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=L68A0nliiu2Q3xuxzZG34RHvsW2Cqh1HButFAloiLuY=; b=EKHMZW6Mj41T2LKqBBU3izi2WgVX03A5X96kztDWMJN7pOd+iOz0QR4G2lKm9iI66/ 1qwHvXcYFeNa+ZnoZgho6TCg0Me6fWr9pd/l8hL7znekX4yfpKW4/BrSSrTLT2vtMN4d EYIkUJ50dEl3xoQAsllshxPIWWWDw/wWCZWfjAIUS6Q7v4ZQIPxZqkqwwpUfHg/xV2h+ q7Xbc2wTALPMNqdmgpHKrEnUrlzMwtibfom7IbHjwI1s/gJxRdIlMffjdGK7vk5HNPkM mVhbePlFEx5DVtnmVQilOopBykqVMXl5r83tngBO2wtyo6ivpz2pnh5cxOBVEAYnYraK rUEw== X-Forwarded-Encrypted: i=1; AFNElJ8DjdrJGEoZaS0ZU+nJJJh5Sud2Vm3dKAS8fseYjvGBxV+X9lGkEoim9E4zoqVa9COT116B/nHEh9s2CRA=@vger.kernel.org X-Gm-Message-State: AOJu0Yxh7ri5FWT6aR3im8UFkIcASZ4+kT5hXq/PcCHbGbq3ScIDEwBQ DZ8hFLwhYtnhWpfinan0npIxhJ2QbzJfY1BDbWtD9pbAxPi+x0QEs37C X-Gm-Gg: AeBDievrfguASVZj+hYQkhBalKkaSkPL3ASv+BrG5DMybUZOGtI1wUMP1JLA7CRdA0C gPqwObTrJvuYYAcx8taXF/nCtG0HRbXod0dVqropRW6cRuUzK/DL+V8wK+LRD9vz4QwWF1qKl7S +K+Gv9Ha7cQGyWXHoKpmExrujZ9uRKTWPGBR9Cqq5uwheOSS1SAlK80fNurfWBIkcEZbJ3av0sO T7qyqZg2JJXBYTnQUwCbYkR3fU/Vo96cWvyuSVfkagR/wkssy63XksA5sQzGIr/v7Rch8volAfC D0YpOsOsi4y4Yv3HRSYyHLXxQBYB3Q909Nz5NBIFuyWVRlHdIb7CKm7gcITkfwVOz8CC0PPtgD8 Azftr8mo1n3UKRfhhL7+RAiQXfFSmGTek+2TpZeQX5DNTWihOpvHT57MNOpyp9LjK+TqPwZrMpd 5LCwM1dq6SccE9NBkrQ1/LZRVN1RYb46q4RjtUFKKwZe4672rHckRF0EmXiQNPOhWcgBC2vXxKH Ho11hIi52Nqr2Gza5Q1tMPUdM+X9g== X-Received: by 2002:a17:90a:d444:b0:364:6558:99be with SMTP id 98e67ed59e1d1-3650ceaab7fmr9463975a91.22.1777906412786; Mon, 04 May 2026 07:53:32 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.166.246.30]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c7ffbb05798sm9926085a12.0.2026.05.04.07.53.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 07:53:32 -0700 (PDT) From: Felix Gu Date: Mon, 04 May 2026 22:53:26 +0800 Subject: [PATCH] pinctrl: sunxi: fix regulator leak in sunxi_pmx_request() error path Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260504-sunxi-v1-1-c0fd0df52776@gmail.com> X-B4-Tracking: v=1; b=H4sIAOWy+GkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDUwMT3eLSvIpM3eSUREtDMzPDZEMLQyWg2oKi1LTMCrA50bG1tQCZt7F DVwAAAA== X-Change-ID: 20260504-sunxi-cda91661c181 To: Linus Walleij , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Ripard Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777906408; l=1142; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=KsGehUIs9yjLgFhJm+ALM6CihYTUD9IxFPyF+rbn54Y=; b=HeZnzJUAEwh2zXD8lRSUzBtxzjVKqCO0BBfYZRyGOZBJ5CwDrdBrjEiQHQdwkS1QwwsLUSbpO 6SW0IlZZ5BXCjzD1FqEQUkVaPWVJsfKl5GiXk3mGGLFIUcMtZBXaX+U X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= In the error path of sunxi_pmx_request(), the code calls regulator_put(s_reg->regulator) to release the regulator. However, s_reg->regulator is only assigned after a successful regulator_enable(). This causes a memory leak: the regulator obtained via regulator_get() is never properly released when regulator_enable() fails. Fixes: dc1445584177 ("pinctrl: sunxi: Fix and simplify pin bank regulator handling") Signed-off-by: Felix Gu --- drivers/pinctrl/sunxi/pinctrl-sunxi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c index d3042e0c9712..25489beeb312 100644 --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c @@ -925,7 +925,7 @@ static int sunxi_pmx_request(struct pinctrl_dev *pctldev, unsigned offset) return 0; out: - regulator_put(s_reg->regulator); + regulator_put(reg); return ret; } --- base-commit: b9303e6bff706758c167af686b5315ad00233bf8 change-id: 20260504-sunxi-cda91661c181 Best regards, -- Felix Gu