From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC421222580 for ; Mon, 4 May 2026 06:23:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777875784; cv=none; b=jAL93/XkjVF5cvl0sDzVo3jESjazpvl6a/uI747MP8+Kb8jsP4hqh0pb399TTXUypVqnUlZPPFVsNdCn628COCPLc4k2ePcYNwxUicSGdjL7CI+QKblY31asXTY32iX5sDRHHa/ZQOfCFI0f9ODnBthvjC46Xq4CtP0hBUzLydg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777875784; c=relaxed/simple; bh=OUJKAnSSKBK4NVixGUpnELUihzSk6cas2RIndIcRiLM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=PWdwvw79IkU7tlpaay7lb94ubJnZWW3/d8RVswqU5er/fpIjYRj9Ctt+T/NxHcXgSFlqmbMEgx7ZfgSdv1NvI0v73/MOzidroAoJnQYBPeWAnpGl+cQj232rYSUNG8DLjbGUhgX6mvF6+kUBPt+eD75mz5kJKly9+ZaA7h4qiNY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jKwhjDfP; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jKwhjDfP" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-488e1a8ac40so34980735e9.2 for ; Sun, 03 May 2026 23:23:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777875781; x=1778480581; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=SsKY674gEcmVloxh8QcPPtKruXs8CJmiJS+7itrX6N0=; b=jKwhjDfP55dnzcjlbdaQiQ13PX8YQ1gPGXHS/itau/WvctBdu6X6UmXC+78b2qCumH ypfRzhTGdLl774ejJN3UBrRpSUcDi4xiU1rlVDQXYSX8sH6vMFPzOIu/Hzk2FwPmf5QU dVzFzKO38MVPG0zF3WccKDLc7Rtcz6NV1vKTpmR6vypl2Jvqq82p6hbkPe73k4fZmVYf MV1xj3rs0oOI61stMMN0lwJo+eOak3KxssNpMSQeoOJyTa2VrVx3X3EmPYSL13XorJPk EfuT9uKshCuQKCoW4qj5bEDIhkCkIxn24wDhONI5OPtwNIXQPq3qeyCYaTnA/gQOJPAX +oug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777875781; x=1778480581; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SsKY674gEcmVloxh8QcPPtKruXs8CJmiJS+7itrX6N0=; b=JbMYbmHo1tVssOB4BRHOAEPb0Wp95/v12jecJNZO09zjBY31onQp6sIwiWAyGFjapf xEdYoJZwhV8JaQu0EV4RJ9kY8bYtjUNBF8/YiuLMhTG5XkawQCUGynVDXPy/etI0adB9 jkbodwMwaiQmwcvvDyRH5gQpVtb4oje8l/YYC3LDMDz1RYtTMxPMMXwXPn5hDO87Vh0q sWOUCXe+goSHYMBZxZ10e1vIfsDrt8LLdULPj6pv1+pEvQqEC0QfL4DmV0TOef82u7ag QhXlfshDXddZdrVyWvXXXSHCjbFDNbgqgI+7jF8PZsFU2MhLLWoGZAwQn6Qm++YpThPO H+Dw== X-Forwarded-Encrypted: i=1; AFNElJ8C4K40ZYl0zzPNOo3xukhWZEV45dX7TesD3mafra1b9LjSdWup5NlSkoQOiGxdtASKbtmcegBj845FlXw=@vger.kernel.org X-Gm-Message-State: AOJu0YwOd7dyz7angj6O7EMmVtBrHcGwlG06z9e9ZwcjpPVyb+WBJPHG e0rt4Qq0CcsrgogDMa+MGvmh0X1q6Df5fvpI5xYKGKKy95YWtbGXFh/l X-Gm-Gg: AeBDiesJQfbPrGV0QyHo4ftgFBQwCt4Q828qcxYIWuBnMpolLScsa2vQV/HtrWuPgVJ KXFQPZ5a+75yEJf+yV/n3rSr9WpuWlNo5xgcky8gCmpoZjV4D9r5zz2ufvEgo/wXjoAcveMESdi r5ZYsvFprk3vzW5R/inK1ZAKhA0CuU8mar6H6TRwEHH3fW3KUghhZqnxEIiI90QGRKM/EeBQTut bXxeWA1KSwpJq1DoBCDKP9vey8gMIwrND61CUvWMxbPh6t3uSLLUChMf2WI87GmoiAR+6iR+BAS GVVrbVSBe+40tpB24zIBt9VxPX1EQ6MqDKebc4lBKYu7IMM3VLf5HhhZyOOfOMjVl/P90xpGkZH VtzFrAbOxpDqzPZpjX1vZAaO/PEh916S4xtmv2By70hZyKNbJHnKWke5g7WGLmj+MtpKD4qTWkN hQ5iYDaFOAkhp1QkHJ49+2dy2W2gb53/a2aGabhejgUV1N+hZIWMoobpPGiGM2YWcbBJ1PazSdJ K0weuKiqjrJsIvE/uN/fg== X-Received: by 2002:a05:600c:8590:b0:489:1f3e:5f6f with SMTP id 5b1f17b1804b1-48a98636c00mr95678385e9.12.1777875780935; Sun, 03 May 2026 23:23:00 -0700 (PDT) Received: from dohko.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a81b99127sm297500385e9.0.2026.05.03.23.22.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 May 2026 23:23:00 -0700 (PDT) From: David Carlier To: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jedrzej Jagielski , Aleksandr Loktionov , Jacob Keller , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: David Carlier Subject: [PATCH] ixgbe: E610: do not fill EEE lp_advertised from local PHY caps Date: Mon, 4 May 2026 07:22:57 +0100 Message-ID: <20260504062257.77460-1-devnexen@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ixgbe_get_eee_e610() fills kedata->lp_advertised from pcaps.eee_cap returned by ixgbe_aci_get_phy_caps() with IXGBE_ACI_REPORT_ACTIVE_CFG. That report mode (and the other IXGBE_ACI_REPORT_* modes) describe the local PHY only, not the link partner. The X550 path uses a separate FW_PHY_ACT_UD_2 activity for partner data; the E610 ACI has no equivalent. Leave lp_advertised zeroed via the existing linkmode_zero() and drop the now-unused ixgbe_eee_cap_map[]. eee_active/eee_enabled are unaffected (sourced from link.eee_status). Fixes: b61dbdeff3a9 ("ixgbe: E610: add EEE support") Signed-off-by: David Carlier --- .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 20 ------------------- 1 file changed, 20 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c index 6990fe53f049..36e43b5e88d1 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c @@ -3558,17 +3558,6 @@ static const struct { { FW_PHY_ACT_UD_2_10G_KR_EEE, ETHTOOL_LINK_MODE_10000baseKR_Full_BIT}, }; -static const struct { - u16 eee_cap_bit; - u32 link_mode; -} ixgbe_eee_cap_map[] = { - { IXGBE_ACI_PHY_EEE_EN_100BASE_TX, ETHTOOL_LINK_MODE_100baseT_Full_BIT }, - { IXGBE_ACI_PHY_EEE_EN_1000BASE_T, ETHTOOL_LINK_MODE_1000baseT_Full_BIT }, - { IXGBE_ACI_PHY_EEE_EN_10GBASE_T, ETHTOOL_LINK_MODE_10000baseT_Full_BIT }, - { IXGBE_ACI_PHY_EEE_EN_5GBASE_T, ETHTOOL_LINK_MODE_5000baseT_Full_BIT }, - { IXGBE_ACI_PHY_EEE_EN_2_5GBASE_T, ETHTOOL_LINK_MODE_2500baseT_Full_BIT }, -}; - static int ixgbe_validate_keee(struct net_device *netdev, struct ethtool_keee *keee_requested) { @@ -3645,7 +3634,6 @@ static int ixgbe_get_eee_e610(struct net_device *netdev, struct ixgbe_aci_cmd_get_phy_caps_data pcaps; struct ixgbe_hw *hw = &adapter->hw; struct ixgbe_link_status link; - u16 eee_cap; int err; linkmode_zero(kedata->lp_advertised); @@ -3670,14 +3658,6 @@ static int ixgbe_get_eee_e610(struct net_device *netdev, if (kedata->eee_enabled) kedata->tx_lpi_timer = le16_to_cpu(pcaps.eee_entry_delay); - eee_cap = le16_to_cpu(pcaps.eee_cap); - - for (int i = 0; i < ARRAY_SIZE(ixgbe_eee_cap_map); i++) { - if (eee_cap & ixgbe_eee_cap_map[i].eee_cap_bit) - linkmode_set_bit(ixgbe_eee_cap_map[i].link_mode, - kedata->lp_advertised); - } - for (int i = 0; i < ARRAY_SIZE(ixgbe_ls_map); i++) { if (hw->phy.eee_speeds_supported & ixgbe_ls_map[i].mac_speed) -- 2.53.0