From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94C1F3D6CAF; Mon, 4 May 2026 14:56:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777906562; cv=none; b=i8064fGhcDYvtLKBbQwxv6EbFhBMJTmLYiNQxs4ypwhMxI9P8kX2H4lA/2TxJHFSoZbIpvW0X9k7suI9TgUUuWryT3m8cYf3TO6laB68Wb1WtJUhWf/QqJCX4PLIdcgE/8MAB2MiBFNP3IxCsPDj0mnNnHCoVyfG8DWUq4nqLgU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777906562; c=relaxed/simple; bh=ll2v9LtrrjMsGgNSxTPb6ZqOV1wGfR+gmcgznhRqy/Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YBIncwvX4rB41ppsN6i207SIo5M+lHY0wB1me72EAOsHZvbbYdyXwz7Tq6rnMSlpp2uej/EoQWGOpm/aZ+gUNzKmnyPhSiEETfWChdPfRpB67Py/HixzgFf0xydk2T2iO/8lxDmt0S4tc3Z4qGAzYe/o0JMpaNxcL2Jj8ByaHuc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=WdZQGZZb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="WdZQGZZb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D63C4C2BCB8; Mon, 4 May 2026 14:56:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1777906562; bh=ll2v9LtrrjMsGgNSxTPb6ZqOV1wGfR+gmcgznhRqy/Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WdZQGZZb8opP8HLqbENELliDurAIeeR0GiwccSngxzIaXg6MeJ5dqipaN/l/lAIoC XUCoeM3dTkyvZFG9zGLW+9sU9tEhYVvZ35BKPqeZyGSGdoW+CXiDEuClP7N1yesqWb udcIqiVpXAoKhUjcMpjO4jfxa1yxmEYfgROGaDXs= Date: Mon, 4 May 2026 16:09:23 +0200 From: Greg Kroah-Hartman To: luka.gejak@linux.dev Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dan Carpenter , stable@vger.kernel.org Subject: Re: [PATCH v4] staging: rtl8723bs: fix remote heap info disclosure and OOB reads Message-ID: <2026050408-simmering-widen-91e5@gregkh> References: <20260415163322.42682-1-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260415163322.42682-1-luka.gejak@linux.dev> On Wed, Apr 15, 2026 at 06:33:22PM +0200, luka.gejak@linux.dev wrote: > From: Luka Gejak > > When building an association request frame, the driver iterates over > the ies received from the ap. In three places, the driver trusts the > attacker-controlled pIE->length without validating that it meets the > minimum expected size for the respective ie. > > For WLAN_EID_HT_CAPABILITY, this causes an oob read of adjacent heap > memory which is then transmitted over the air (remote heap information > disclosure). For WLAN_EID_VENDOR_SPECIFIC, it causes two separate oob > reads: one when checking the 4-byte oui, and another when copying the > 14-byte wps ie. > > Fix these issues by adding upper-bound checks at the start of the loop > to ensure the ie fits within the buffer, and explicit lower-bound > checks to return a failure if the length is insufficient. For > HT_CAPABILITY, also clamp the length passed to rtw_set_ie() to the > struct size. > > Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") > Cc: stable@vger.kernel.org > Signed-off-by: Luka Gejak Please address the review comments found here: https://sashiko.dev/#/patchset/20260415163322.42682-1-luka.gejak@linux.dev thanks, greg k-h