From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@linaro.org>,
Zecheng Li <zli94@ncsu.edu>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Ian Rogers <irogers@google.com>
Subject: [PATCH v5 0/9] [PATCH v5 0/9] perf DWARF: Fix libdw API contract violations and crashes
Date: Mon, 4 May 2026 01:12:18 -0700 [thread overview]
Message-ID: <20260504081227.2203848-1-irogers@google.com> (raw)
In-Reply-To: <20260503171032.1559338-1-irogers@google.com>
This patch series addresses a number of DWARF/libdw error-handling
bugs and contract violations, preventing several real Userspace
segmentation faults and memory/FD leaks.
In v5, the series has been extensively restructured and polished based on
comprehensive review feedback on v4, focusing on history granularity,
bisectability, and defensive styling:
- **Commit Splitting for Review Granularity**: Split the previously large
libdw contract fix patch into 4 granular commits to cleanly isolate
independent improvements: introducing clear_frames refactoring, fixing
ORDER_CALLER parent update corruption, adding line 0 support, and
consolidating core contract/leak cleanups.
- **Bisectability & Correctness Hardening**:
- Fixed an unused variable compilation failure (-Werror) in the split
history to guarantee perfect git bisectability.
- Fixed a line 0 fallback regression to ensure that if an optional call
line is missing but the call file is valid, we fallback to line 0
to preserve the filename rather than discarding the caller info entirely.
- **Style & Robustness Polish**:
- Standardized all newly introduced C++ style (//) comments to
preferred C style (/* ... */) comments.
- Implemented explicit safe string duplication style fix in annotate-data.
- Corrected CU DIE propagation context inside probe-finder.
- Enhanced the Patch 2 commit message to explicitly detail the removal
of strict optional attribute aborts (decf) to clarify review queries.
- **Tags Collected**: Integrated Acked-by tags from Namhyung Kim for Patch 1
and Patch 9.
v5:
- Restructured series from 6 to 9 patches by splitting the libdw commit.
- Fixed compilation bisectability and DWARF line 0 filename preservation regressions.
- Standardized comment styles and applied safe duplication formatting fixes.
- Updated commit messages with detailed optional attribute justifications.
v4:
- Localized and squashed robust error handling, memory/FD cleanup
paths, and safe DWARF printing.
https://lore.kernel.org/linux-perf-users/20260503171032.1559338-1-irogers@google.com/
v3:
- Minor formatting fixes.
https://lore.kernel.org/linux-perf-users/20260503003552.1063540-1-irogers@google.com/
v2:
https://lore.kernel.org/lkml/20260502155656.478642-1-irogers@google.com/
v1:
https://lore.kernel.org/linux-perf-users/20260502064839.282422-1-irogers@google.com/
Ian Rogers (9):
perf dwarf-aux: Fix libdw segmentation fault in cu_walk_functions_at
perf dwarf-aux: Fix libdw API contract violations
perf srcline: Introduce inline_node__clear_frames()
perf libdw: Fix callchain parent update in ORDER_CALLER mode
perf libdw: Support DWARF line 0 in inline list
perf libdw: Fix libdw API contract violations and memory leaks
perf probe-finder: Fix libdw API contract violations
perf annotate-data: Fix libdw API contract violations
perf debuginfo: Fix libdw API contract violations
tools/perf/util/annotate-data.c | 27 +++++----
tools/perf/util/debuginfo.c | 9 ++-
tools/perf/util/dwarf-aux.c | 39 ++++++------
tools/perf/util/dwarf-aux.h | 5 ++
tools/perf/util/libdw.c | 72 +++++++++++++++++-----
tools/perf/util/probe-finder.c | 102 ++++++++++++++++++++------------
tools/perf/util/srcline.c | 9 ++-
tools/perf/util/srcline.h | 1 +
8 files changed, 179 insertions(+), 85 deletions(-)
--
2.54.0.545.g6539524ca2-goog
next prev parent reply other threads:[~2026-05-04 8:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-03 0:35 [PATCH v3 0/6] perf DWARF: Fix libdw API contract violations and crashes Ian Rogers
2026-05-03 0:35 ` [PATCH v3 1/6] perf dwarf-aux: Fix libdw segmentation fault in cu_walk_functions_at Ian Rogers
2026-05-03 0:35 ` [PATCH v3 2/6] perf dwarf-aux: Fix libdw API contract violations Ian Rogers
2026-05-03 0:35 ` [PATCH v3 3/6] perf libdw: " Ian Rogers
2026-05-03 0:35 ` [PATCH v3 4/6] perf probe-finder: " Ian Rogers
2026-05-03 0:35 ` [PATCH v3 5/6] perf annotate-data: " Ian Rogers
2026-05-03 0:35 ` [PATCH v3 6/6] perf debuginfo: " Ian Rogers
2026-05-03 17:10 ` [PATCH v4 0/6] perf DWARF: Fix libdw API contract violations and crashes Ian Rogers
2026-05-03 17:10 ` [PATCH v4 1/6] perf dwarf-aux: Fix libdw segmentation fault in cu_walk_functions_at Ian Rogers
2026-05-03 23:33 ` Namhyung Kim
2026-05-03 17:10 ` [PATCH v4 2/6] perf dwarf-aux: Fix libdw API contract violations Ian Rogers
2026-05-03 23:36 ` Namhyung Kim
2026-05-03 17:10 ` [PATCH v4 3/6] perf libdw: " Ian Rogers
2026-05-03 23:44 ` Namhyung Kim
2026-05-03 17:10 ` [PATCH v4 4/6] perf probe-finder: " Ian Rogers
2026-05-03 23:49 ` Namhyung Kim
2026-05-03 17:10 ` [PATCH v4 5/6] perf annotate-data: " Ian Rogers
2026-05-03 23:53 ` Namhyung Kim
2026-05-03 17:10 ` [PATCH v4 6/6] perf debuginfo: " Ian Rogers
2026-05-03 23:54 ` Namhyung Kim
2026-05-04 8:12 ` Ian Rogers [this message]
2026-05-04 8:12 ` [PATCH v5 1/9] perf dwarf-aux: Fix libdw segmentation fault in cu_walk_functions_at Ian Rogers
2026-05-04 8:12 ` [PATCH v5 2/9] perf dwarf-aux: Fix libdw API contract violations Ian Rogers
2026-05-04 8:12 ` [PATCH v5 3/9] perf srcline: Introduce inline_node__clear_frames() Ian Rogers
2026-05-04 8:12 ` [PATCH v5 4/9] perf libdw: Fix callchain parent update in ORDER_CALLER mode Ian Rogers
2026-05-04 8:12 ` [PATCH v5 5/9] perf libdw: Support DWARF line 0 in inline list Ian Rogers
2026-05-04 8:12 ` [PATCH v5 6/9] perf libdw: Fix libdw API contract violations and memory leaks Ian Rogers
2026-05-04 8:12 ` [PATCH v5 7/9] perf probe-finder: Fix libdw API contract violations Ian Rogers
2026-05-04 8:12 ` [PATCH v5 8/9] perf annotate-data: " Ian Rogers
2026-05-04 8:12 ` [PATCH v5 9/9] perf debuginfo: " Ian Rogers
2026-05-04 23:50 ` [PATCH v5 0/9] [PATCH v5 0/9] perf DWARF: Fix libdw API contract violations and crashes Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260504081227.2203848-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=zli94@ncsu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox