From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBDE737CD49 for ; Mon, 4 May 2026 10:13:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777889624; cv=none; b=HJjZrto/kEVB2pBE58D4K1awxxiLDHzuLyj/N+Bg6rq0p7Xq/JEu0ZCvN+iZdpHKoySirhW7Gxy1DOA5dCvgKLCia3zS0EeTA6ab/QWGqFYs6pRyewutf0unSYuP+X7hzsLjevY+A8OCAM8ggnuindURxFeAhShUwKdPwlDfMzQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777889624; c=relaxed/simple; bh=3STGZFIGp1QI0P9KYESK3j78npCaPdnySXuzfK9UW/E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jmBlIAcYQ6oZ4fu3xKkyc846nKAyxRA4q+vHRVZAsfPl+kE5G4p7y+kBgC34I+O4Sf3tdIbAP8Gnyi+fwv5U0aAEls3758lVMLrNwOdFcTSNnTKMcEvk5YD3iP1xq9vw+SsYK2/BJlBXrkSzE2lKQTild+3DrCywW96dId7YOhI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KOWo1IrF; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KOWo1IrF" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-82748257f5fso3414797b3a.1 for ; Mon, 04 May 2026 03:13:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777889621; x=1778494421; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XVeN/tIgR68DwC5ZYD/OpJgnTRgKD56zUbPN+aZwxQg=; b=KOWo1IrFxJndDFpJiO5wtNLoGnJ/9PGw6Hf0SBnecSwyhW/BSPY8q4T4EvIVQwcI4p /+omCbrEyssRR302C5CQIMm3YPg0TsVHx9cgi4jBOpXmOJ+zY2QldHqQ81ztMdqfdwCD IykRMhf3E+B58lvNLSrHu8PxP7nBc+O8bTaMh4vVXSkkEoIzzbmAwXeErAqjQAstmvYk AXDe1NRET9rMbGxaOtlZptEiLewUOGvnc7LLsqyJSvzXRALFPJ5n2JybMTrCRFXvyPrh 0DVwrVlYS8tDPVBDaYO2pDYvwfDKbrTGx3Wlpb3qmcker9hnECqx6FP9jH8NOF2cMlUm 706w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777889621; x=1778494421; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XVeN/tIgR68DwC5ZYD/OpJgnTRgKD56zUbPN+aZwxQg=; b=fqOErHxNoqSPFfB8WzZuhM9eeGPX+c74XUl19c6EwO4fQU2y05tKxQsQ3W7ilPkuMT kBhGdBuWd/yE2+R1Bd8q9QGGuj7swvUrgLTdXj6+R1mSNP6ZsYmyInVx6BFM90pxmZoh xB7BE8xBJYUPRbOkdEefKOQx9Dj6u5K1RR/5g1zWNAwCI9u3DFDuOO5VF1oDCq/A9dRs 980EIaZiJ3vFl3aX0KXNHihm1YN2EUsE8VkpwvU383Br5qSvJxBXZohmfIvIPzpEfQn0 C4/XgWr9ljDrj9wfk8AwbY+xLUjUqSi4S90uXz0QpXXciIMmMgD+ZkIwhep6x9cThEma +b8g== X-Forwarded-Encrypted: i=1; AFNElJ8N7xqr+oScdNxnzzanIMy8FAO1VDpdsQHsCuYzK/guw8el870jBPuadtPIDUhPRBUPXAL/JnPajus4nVo=@vger.kernel.org X-Gm-Message-State: AOJu0YxkP8UQKG2NEqc+dB6wTEGV67Z3Bcl4SwNBJDuEODPpgbdmmEZ8 luEDgVBCw/DIsaEG0s96t4mKUcBz4/EdT5ZCUXYGMW4U7kEH1nwQDFHaxz6ZMvcw X-Gm-Gg: AeBDietVTxfCP9u0ha1C9GxxWJ9DWD2KAMVswQ6VypN/fgMACnYzVtj1+4L2qI/Y5PL pgUE+3jtxuaKbs5wCbcAQAfY3Cyj5HoN46yxM4ITLz10zuFEuQOKHSPnkqJHMpiDydyAELyEAGy 9dJvKIZH5dFSyYWjxt5YElavyM6uc1q5DKzxQvlDS5sdATj/lUkbGyfRWHgUBVzfQjkBSEyt0Lv 06ZxpMBN15IPOsINGKqnLA2ViPs8/nbGKiQ+bgnSocv7c/ihR7DeQYUMC4fBcNJn61KUhDXEuZg CMw3XrIGdzfUqvRfCCKG6usropcC56QBFuVotp+t/UV4RxuPo1TEopl0b1bTZs0hUZROwcAmlE0 RFTC7W50vJ481O8ZWHmE0H7iGbONRh/05yHw+draOGi7h6CiZIRvCitBghdyGfVvTsgQ2y/95aH /a1oSZOzEEKDsOvJg9uA+R1EfTjJjlrnAhpbFZBcMEkJTLtRi+OwirULgXG7Np X-Received: by 2002:a05:6a00:aa06:b0:829:7a62:6a with SMTP id d2e1a72fcca58-8352c4fd461mr7141618b3a.22.1777889621211; Mon, 04 May 2026 03:13:41 -0700 (PDT) Received: from d.home.yangfl.dn42 ([2a09:bac5:6619:3046::4cf:90]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-835158bd62fsm10813486b3a.24.2026.05.04.03.13.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 03:13:40 -0700 (PDT) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jamal Hadi Salim , Jiri Pirko , Simon Horman , linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 1/3] net: sched: tbf: add extack to offload params Date: Mon, 4 May 2026 18:12:53 +0800 Message-ID: <20260504101258.1608004-2-mmyangfl@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260504101258.1608004-1-mmyangfl@gmail.com> References: <20260504101258.1608004-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Drivers might have error messages to propagate to user space. Propagate the netlink extack so that they can inform user space in a verbal way of their limitations. Signed-off-by: David Yang --- include/net/pkt_cls.h | 1 + net/sched/sch_tbf.c | 9 +++++++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h index 99ac747b7906..3bd08d7f39c1 100644 --- a/include/net/pkt_cls.h +++ b/include/net/pkt_cls.h @@ -1046,6 +1046,7 @@ struct tc_tbf_qopt_offload_replace_params { }; struct tc_tbf_qopt_offload { + struct netlink_ext_ack *extack; enum tc_tbf_command command; u32 handle; u32 parent; diff --git a/net/sched/sch_tbf.c b/net/sched/sch_tbf.c index f2340164f579..4576111fe075 100644 --- a/net/sched/sch_tbf.c +++ b/net/sched/sch_tbf.c @@ -139,7 +139,8 @@ static u64 psched_ns_t2l(const struct psched_ratecfg *r, return len; } -static void tbf_offload_change(struct Qdisc *sch) +static void tbf_offload_change(struct Qdisc *sch, + struct netlink_ext_ack *extack) { struct tbf_sched_data *q = qdisc_priv(sch); struct net_device *dev = qdisc_dev(sch); @@ -148,6 +149,7 @@ static void tbf_offload_change(struct Qdisc *sch) if (!tc_can_offload(dev) || !dev->netdev_ops->ndo_setup_tc) return; + qopt.extack = extack; qopt.command = TC_TBF_REPLACE; qopt.handle = sch->handle; qopt.parent = sch->parent; @@ -166,6 +168,7 @@ static void tbf_offload_destroy(struct Qdisc *sch) if (!tc_can_offload(dev) || !dev->netdev_ops->ndo_setup_tc) return; + qopt.extack = NULL; qopt.command = TC_TBF_DESTROY; qopt.handle = sch->handle; qopt.parent = sch->parent; @@ -176,6 +179,7 @@ static int tbf_offload_dump(struct Qdisc *sch) { struct tc_tbf_qopt_offload qopt; + qopt.extack = NULL; qopt.command = TC_TBF_STATS; qopt.handle = sch->handle; qopt.parent = sch->parent; @@ -193,6 +197,7 @@ static void tbf_offload_graft(struct Qdisc *sch, struct Qdisc *new, .parent = sch->parent, .child_handle = new->handle, .command = TC_TBF_GRAFT, + .extack = extack, }; qdisc_offload_graft_helper(qdisc_dev(sch), sch, new, old, @@ -477,7 +482,7 @@ static int tbf_change(struct Qdisc *sch, struct nlattr *opt, qdisc_put(old); err = 0; - tbf_offload_change(sch); + tbf_offload_change(sch, extack); done: return err; } -- 2.53.0