From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6B4B35E955 for ; Mon, 4 May 2026 09:13:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777886041; cv=none; b=ne18or9NfBcKjkeR0c+qn4gNj9Jn19EyPz3/3g0q4uBr1GcyyijpjRRcYLajYX6aslodN3OnifZeFzf1qDc9hyjyeFscvUydH/3GZjggjoXqQVOOCntePER2x15BIGZOIgfJTF1ZOCv8YPHp2QpZg6f9RAN9ym7SNiYWB6/jkTs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777886041; c=relaxed/simple; bh=YTGIZWPU9y22Ivqcul+wFlsNQEPi7ai8o4vbiM2MlQ4=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type; b=g2Bdh4DgBesz+CJvTW/2KfUZfe5P9M8Fv85DSBl26TR9+EmnnddHWEeRDyv+wa540KmEP106VLYWAQpc4kyOdZ09XuoVIf8gLWOjBSDzT5irqllIEQkW6TqUJD+30Keu8+IXSD6xgVrNxdDwbJBEuhdKQYtcyYyXOovhIf5IxPM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l8JJ5BXe; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l8JJ5BXe" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-44b052142e1so1210038f8f.1 for ; Mon, 04 May 2026 02:13:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777886038; x=1778490838; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:subject:cc:to :from:date:from:to:cc:subject:date:message-id:reply-to; bh=uEFiXqc4wlSqY+RDlXEzibsdFvgDZPhLEgJ5WepC+Us=; b=l8JJ5BXe4SmizBVhQtz0VMQ3up4sVURpjhCljJErvkLZWnd0tMZD36hMtczSrw6qeE fU1gaFzAWLVK4Xarx4aRsGbrhUlYMUT919vl0RrQtZgY22VZZR195w7dBGjpZwPcFlMP NAVR7IJP/s8QZp5VI24ab2PLohZn68KqhX0XFq27S7EWLhtdRxkmdymS+cz9e6MZCSdr 4s/o1dIk3ezJuuRwyHHg3mpsR9HR1v2tYilBRtVDzLfUBTO/YqhAQ8wonrP0mXESRugs UZPt1BoXZERKHK1wWwNzF8tqqb9QZErpBB6NeaLwXNf0e5j8fVp9+atEMCr/dUPpbHVm rq7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777886038; x=1778490838; h=content-transfer-encoding:mime-version:message-id:subject:cc:to :from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uEFiXqc4wlSqY+RDlXEzibsdFvgDZPhLEgJ5WepC+Us=; b=eM/oV2Chauy0+rwXbVGKOTPCbngkHNS2PMor5/fpCOykM28Kq8xmUAQlgFIBk6MJJ7 tRpDM2TN2TF/pH+jaZhbbKVQsOPAP+T9+o0nZvzcJ1HKjKlEkxtbbz1+yK6qeqk3JXmG YSuzV9uqVhlMjjAx4FbqTpDaFHy0PMUnmB+csBbvwW7AMQ+6AglTncPIB0xub0KnyLl1 GPbVpkLApPbNohE0XIM6zoGD/1eFUHQrA0mUiYFx3v4jjGVTj8Hq35pqPF2VLrI3HSPL Rx/qQL1giiSMaGnIWbtFMbkr5hcgyPWDtznBVDhFkXm0OeEuhersFs3BQE7b2e7v0xLg DPaQ== X-Forwarded-Encrypted: i=1; AFNElJ+3OHkBNgQuAOBG/NJGIqtn1wwMZtuWWVUMaoroL4hpuMKt0qqa4l+Sj7pZVuNYbBx2/wU6C6oFGAFJybQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzxXzs3Idc7ZXoU2RDRuHJ4Bx70wvRpTmLI9XQLUT6Xrwhu/e+4 f0zqW85VlBDDTO5UJYT+14Xj0yG4zaqbvjtRTD4nyvhHrGP4LOHmjPZw X-Gm-Gg: AeBDieseD5hWk+gEovARanHTvLB3oeyknLCCvs2w6yE52YK/hWW4Th0HRhw3Pb8ZCHR 5J9nbY6U45es2gDS4dslsWqqrKADgNjHz3f4TxiyfBaCdZmProS6YdL9Q9OyhXjcdIJt2VgXalB 1OeEgsM2g18EuItk+CBhF3Bs0LNeCWinydL94MgQxNfR5qjkFA3bsy7xGcQqM0/sc03mZ6kE4iZ F3Ew6EQv/TR1o6JW5ETx6lTIbfa2VAyazjRVip3gbszCCV3V32z3V00FesurDAOg8Gpzj3XHdJk wStHdtalKy5Vz2UdEkEaLujLXK5CZ0IjN0E33wct5+Ed4pQ03D/gSOz4kTDKIIpfEtNNomFQ9YU efHDTFnu6p9VlZkyZybD6MhUjU1fvcx89hv7G8O1c9+tmN6pW+eSXh2v60RnZvRh6acT/vQa+cq Ks8GVCUL9H10XUgWTiERjO5FC2/yKJGU8dzIjFmFyecYHx6063p/uydSPY X-Received: by 2002:a05:6000:26c4:b0:43c:f247:4792 with SMTP id ffacd0b85a97d-44bb32fd802mr14989092f8f.12.1777886038122; Mon, 04 May 2026 02:13:58 -0700 (PDT) Received: from foxbook (bgt227.neoplus.adsl.tpnet.pl. [83.28.83.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-44a986aa70dsm24848370f8f.25.2026.05.04.02.13.57 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 04 May 2026 02:13:57 -0700 (PDT) Date: Mon, 4 May 2026 11:13:53 +0200 From: Michal Pecio To: Greg KH , Alan Stern , Mathias Nyman Cc: "Xuetao (kirin)" , , , Subject: [PATCH v2 1/3] usb: core: Fix root hub descriptor wBytesPerInterval Message-ID: <20260504111353.55ba2530.michal.pecio@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Per USB3 9.6.7, it's "the total number of bytes this endpoint will transfer every service interval". There seems to be no good reason to have wBytesPerInterval < wMaxPacketSize - either one is too low or the other too high. Here, wBytesPerInterval is too low for hubs with more than 15 ports and xHCI spec allows such root hubs. This is inconsequential for emulated root hubs, but we may want to override and log suspiciously low wBytesPerInterval in descriptors, so fix this to prevent nuisance warnings. Signed-off-by: Michal Pecio --- v2: same as v1 drivers/usb/core/hcd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c index 89221f1ce769..fc8130f94ca5 100644 --- a/drivers/usb/core/hcd.c +++ b/drivers/usb/core/hcd.c @@ -339,7 +339,8 @@ static const u8 ss_rh_config_descriptor[] = { /* Companion */ 0x00, /* __u8 ss_bMaxBurst; allows 1 TX between ACKs */ 0x00, /* __u8 ss_bmAttributes; 1 packet per service interval */ - 0x02, 0x00 /* __le16 ss_wBytesPerInterval; 15 bits for max 15 ports */ + /* __le16 ss_wBytesPerInterval; same as wMaxPacketSize */ + (USB_MAXCHILDREN + 1 + 7) / 8, 0x00, }; /* authorized_default behaviour: -- 2.48.1