From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E0E137F73B for ; Mon, 4 May 2026 09:34:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777887262; cv=none; b=oHEhH3bLj+qiRjXk4X0qlE/oVqG/qw7xIPXqCg3ofUJ4RKZHLIvtzaPdW2DWZCy89mnWZ1u0SqyvHSoaOwN/u/7cWBDy/VaN6gZWjemvLDy476+Bdy0N5MjeL9c6WDnktxMsswCKeOLEnVNrRYoH5Dyxy2Q8l96br7GBnIotOVo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777887262; c=relaxed/simple; bh=2MtHJqOE09wNQuT2vYsaJzmrMMPEm631CqKprZrY760=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=nbhQZNqhe5GzY/omJxZoxaVT2ZGSXYdJuP17Laz6C0ZhElRYK/pI+AoAoWsCaw5g+58JTgRxAA4wCwYQQGj1Yi/JYhRhbRninciv4unZSX8N7JgMY4Y99rFJiFmUAi76KYnvsPC3Jfq8/RsCjQVEZyoCoN4Wbq8otcQFoIRv9F0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=B0a50oH8; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="B0a50oH8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1777887257; bh=2MtHJqOE09wNQuT2vYsaJzmrMMPEm631CqKprZrY760=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=B0a50oH84hTTfJ/wPH05tRGqpvzIPFEF6xPbkMA2R+aVTb3bYfP5LkENbO1vWJWUW 9ozuBMolslK7SZQvw6QrJsVhdI06NTJUmpoRHD0AvC1lDACi7GY621olSsth+nrjVD LKBo2n1sajzyXLDtr8aXfYDGdKYxWFuPOiVOLIZ4DpoYEdjXh25SbozOyr9GuL+xGL ysBaPyRVZhSx/8eSl+vNXzbSGejopzdcfQK0RYLf2RZlitGLXwk9PBI+40USgtvVM4 hMwPpN0aH/3WlZfi1pKzuB37XjazHVhgLYVBpmRKbSz7cQ9zecABkTTsjks+RPXHBa 2n5ml4Pr4xJEA== Received: from fedora (unknown [100.64.0.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id BBE5317E061E; Mon, 4 May 2026 11:34:16 +0200 (CEST) Date: Mon, 4 May 2026 11:34:13 +0200 From: Boris Brezillon To: Steven Price Cc: Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/10] drm/panthor: Prepare the scheduler logic for FW events in IRQ context Message-ID: <20260504113206.747a183c@fedora> In-Reply-To: <323eb2e0-9ed5-4be6-8ec9-b6c0b52262f5@arm.com> References: <20260429-panthor-signal-from-irq-v1-0-4b92ae4142d2@collabora.com> <20260429-panthor-signal-from-irq-v1-6-4b92ae4142d2@collabora.com> <323eb2e0-9ed5-4be6-8ec9-b6c0b52262f5@arm.com> Organization: Collabora X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 1 May 2026 14:47:59 +0100 Steven Price wrote: > On 29/04/2026 10:38, Boris Brezillon wrote: > > Add a specific spinlock for events processing, and force processing > > of events in the panthor_sched_report_fw_events() path rather than > > deferring it to a work item. We also fast-track fence signalling by > > making the job completion logic IRQ-safe. > > > > Signed-off-by: Boris Brezillon > > I think there's some locking problems here. With some AI help I found > the following path: > > * panthor_job_irq_handler() > * panthor_sched_report_fw_events() > * [takes events_lock] > * sched_process_csg_irq_locked() > * csg_slot_process_progress_timer_event_locked() > * lockdep_assert_held(&sched->lock); Oops, this one should check that events_lock is held instead. I'll fix that.