From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F34003BED5F for ; Mon, 4 May 2026 11:34:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777894460; cv=none; b=C2HmL07fcHWtT++RmP6LACxUVaHOgllPkmE1AkvHxzTdk/vm9JE8tp45N3JQXuAQX4MWG38jCzwygFP6NhapAWGfgd9NPLlrASPHOtMWJ/7yKuLPH3yAHdgH2giigXRO3xf2OZn0D9X5Vu7tVdvgHerb8QYzzskLDN1re71cTzY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777894460; c=relaxed/simple; bh=ziNVxdUbaASwghi8AIhL9hLaXeTgfUuYFZaqap0QkWg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QNXoNhnQAeKh+U2ipX73bvPXmbZvn8mAOtNtzK/dJaTwoTENJzB/kzosioyfOnkVCgyVVOA0JLRqUhAypO8r9N9740nK8td6TXLmM9hu76puqHNpF9ushntFQJD8rf1AF40Bqcuj2PdNDj+cd5CQEMJ1IUH6Jwpbqm4FKspgkj4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Hop2bztS; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Hop2bztS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777894456; x=1809430456; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ziNVxdUbaASwghi8AIhL9hLaXeTgfUuYFZaqap0QkWg=; b=Hop2bztSH/NwbqDEPEUfYaRzgiKB7nOcS+IgFFohrBwDvzZ3Hk1zotIl lTkxOlg7Yxbpndb98JsxiDacstclcmo+yvE3uKd5xSR6j/LRGB1BSICIx mC08p1rm2l2/+5ePhrcc6bkUwRWM1mEsvobFDzKU4rcsFe3v+qhwSRPna S3rwoe4vkszxoCVKW4t2gg4dB69QTkNFhkmZ3P63Db8mKjmuaoBBY2Qmf /dMqpvRzC9iMWbhUlvoKyHuFNUjL5LpkRHFE7HE8/I2bzKRNauJwoM1AI hxvTwRg6Xa6gmahQYwuwVNrwfRK3BuIrxhXrfCI0KfoxP29qwijAjuOsJ A==; X-CSE-ConnectionGUID: dUOoiIrmTGGhAxV3dTvJ7g== X-CSE-MsgGUID: Ht5xqsG3QO+eJynioVfUqg== X-IronPort-AV: E=McAfee;i="6800,10657,11775"; a="81315171" X-IronPort-AV: E=Sophos;i="6.23,215,1770624000"; d="scan'208";a="81315171" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2026 04:34:16 -0700 X-CSE-ConnectionGUID: w0vSKyivQFiKopr4EXu1PA== X-CSE-MsgGUID: W2aXWlvIRcCmruNiEujnoQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,215,1770624000"; d="scan'208";a="240478249" Received: from hrotuna-mobl2.ger.corp.intel.com (HELO ahunter6-desk) ([10.245.245.92]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2026 04:34:14 -0700 From: Adrian Hunter To: alexandre.belloni@bootlin.com Cc: Frank.Li@nxp.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 07/16] i3c: mipi-i3c-hci: Complete transfer lists immediately on error Date: Mon, 4 May 2026 14:33:43 +0300 Message-ID: <20260504113352.38490-8-adrian.hunter@intel.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260504113352.38490-1-adrian.hunter@intel.com> References: <20260504113352.38490-1-adrian.hunter@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Finland Oy, Registered Address: c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Content-Transfer-Encoding: 8bit In DMA mode, transfer lists are currently completed only when the final transfer in the list completes. If an earlier transfer fails, the list is left incomplete and callers wait until timeout. There is no need to wait for a timeout, as the completion path in i3c_hci_process_xfer() already checks for error status. Complete the transfer list as soon as any transfer in the list reports an error. This avoids unnecessary delays and spurious timeouts on error. Complete a transfer list completion immediately there is an error. Signed-off-by: Adrian Hunter --- Changes in V3: None Changes in V2: Renamed completing_xfer to final_xfer drivers/i3c/master/mipi-i3c-hci/dma.c | 6 ++++-- drivers/i3c/master/mipi-i3c-hci/hci.h | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/i3c/master/mipi-i3c-hci/dma.c b/drivers/i3c/master/mipi-i3c-hci/dma.c index 28e4d38f55d3..899fdf6555a8 100644 --- a/drivers/i3c/master/mipi-i3c-hci/dma.c +++ b/drivers/i3c/master/mipi-i3c-hci/dma.c @@ -502,6 +502,8 @@ static int hci_dma_queue_xfer(struct i3c_hci *hci, struct hci_xfer *xfer = xfer_list + i; u32 *ring_data = rh->xfer + rh->xfer_struct_sz * enqueue_ptr; + xfer->final_xfer = xfer_list + n - 1; + /* store cmd descriptor */ *ring_data++ = xfer->cmd_desc[0]; *ring_data++ = xfer->cmd_desc[1]; @@ -576,8 +578,8 @@ static void hci_dma_xfer_done(struct i3c_hci *hci, struct hci_rh_data *rh) tid, xfer->cmd_tid); /* TODO: do something about it? */ } - if (xfer->completion) - complete(xfer->completion); + if (xfer == xfer->final_xfer || RESP_STATUS(resp)) + complete(xfer->final_xfer->completion); if (RESP_STATUS(resp)) hci->enqueue_blocked = true; } diff --git a/drivers/i3c/master/mipi-i3c-hci/hci.h b/drivers/i3c/master/mipi-i3c-hci/hci.h index d630400ec945..f07fc627d4d2 100644 --- a/drivers/i3c/master/mipi-i3c-hci/hci.h +++ b/drivers/i3c/master/mipi-i3c-hci/hci.h @@ -104,6 +104,7 @@ struct hci_xfer { struct { /* DMA specific */ struct i3c_dma *dma; + struct hci_xfer *final_xfer; int ring_number; int ring_entry; }; -- 2.51.0