From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3CC93DBD47 for ; Mon, 4 May 2026 13:21:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777900917; cv=none; b=CIezVdBVH/dTrjVoTYMvLn7EbfmI/A2j1K6WRnTyal1EqzYb3tDgVqy7DgReOtXQZa2jtIijaWTSSlpPu7bXMJnq+qap3EdseoT5Qh1Toe6tbeYBeHjnbHUUskWkIrwhtvTGqoqlLpKWrpxckPJDSsHprTAFthaEVhcE+0kmGHE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777900917; c=relaxed/simple; bh=r9eQVf4VASyFYaE/ZIlyDRbmFOv6clE/O8XKlS0U8ZE=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=u4ttZisKRceDbyxEOPJeG6CQ/2SqzjajMnG2vxuNRQ7Xaptq/Sg/hjulhXYIj5xH+uH4mzy+h9NpXmeT6XFSWAIvewQN3wdLj5jkYb2WMjnyp7q6vGDCl5AIzl0swL1DPWbNFqwLwC6zy0hZ2jVxvxsQEST1YyxXrWXoCp5Jxos= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eETDozoa; arc=none smtp.client-ip=209.85.208.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eETDozoa" Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-393a61ca482so799701fa.2 for ; Mon, 04 May 2026 06:21:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777900914; x=1778505714; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=NzTvXmtIHVqLoOxlkNflVv2HMvkwESIZVj/UhIYYlUU=; b=eETDozoa2mte/9xI3UtGg89nJVlTKs7Qu/8AoSV1SwSNjOwY5q3AcZ+7exyGlhg96Y 7lRiBZHauBw5UrZMeBoyLHmS75s4DkElYjmhnLplzIN3tqVUhQVZgpD1ISrXRblGm2+b tEixkQl+vzbArzT6Kp3MNx+Vs1/ghuTpq3y0nXlpqTCUtlXwwdeWXrmiN+z8jzSUT4cM lL/+mt3XlZhRttmSXzCFbmbB4uELjrY6BIMoJ3O5zdfioK5VbLFiNWFnbfZno2+kZr6k N/UdfGd0FtVchvVjVm6t5s5EnzW+3IZdCA2z2vJZDB1l8r+2tnnhnlh3Fg6hXnABAw1L L4BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777900914; x=1778505714; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NzTvXmtIHVqLoOxlkNflVv2HMvkwESIZVj/UhIYYlUU=; b=aXkopgksy0c9UX38ULhNyb/OfHFL7xeKWV9JWTH5uVyOfIOxZ+Uj4dzl4eWq6VEIfl CMFv7I/EZMBIWy9xV2u7f4YFnST9X3+J0npc+S8IrZSbPefohiJoq5stUGKEChmuiufZ 5WJioHVEoPNkmsj0SdE8FYxicSwVvKitWTmK0R7KwZ2YAdRYgRZGxhF76No/mnrdnj2I VQwpFjs6IzRWRUzWZeFdMHX13mITuWQD7oGlqr8aSAPL5qXqpyDCaIlpVb8paW59xPiO I9KoF36rFWciA1Sgv6rig+9XxlZNPVf9B+YPzP7m1MYVTBf4yZgGg1uvuZho9j5/vySa 2KVw== X-Forwarded-Encrypted: i=1; AFNElJ8Ida+wbd+pHVxRsXksH16r+Lygub0SkO62+1FW8W8pyJsEyo291/GbIb3iGqcyiMJ/OO9j0OiA08TkeWI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/WlRXtIFtfYGTc6drfF6ZIEKN+VUFHLBeO0XvYDSyRr3iCp0u xdyH+bolfLuoJ7Gtxf4zrq5X//DyQBtKCXpKNz/3kuYo3A9WKq0SlBQ7ed227qkM1XNQMg== X-Gm-Gg: AeBDieumnJDdAlLutZBjROQRnDI+LphSG3wWVFlG+Wkh8n46/t26ytJR0SldFu6tY1g tTZ7hyxe2bUbD7QXO4BzFt37jSIPADDOE28JQGN5giErU5v25awPdHQ+Db65V3C1NHvmCAsttSM m07EKuAYImI6EOEvrx1haYgxqs6PePw43Ol57kBWm/yZSF1L860DJujQ94aGNvJ6Pk7LVrcOWp2 puHKebmKZ5wivHbcNaSwGgzh+Ct5v+Kti3j5E28cz0GfepFmmnk9RXSQ7QdGOkNh8CfyZ12U0hL 6BeT43Rbe0F482PwsVVm6Vb4Ep6l2EneI2kQI25NgjonOpeMtfuYeKWa5nSqta23RTcjFYrN2Wu TJ5T9i/K5Yn95XWIUnpZHuuaeA3vtDPvd2JOPp4T5MSDvvB9YGq97N2uGrIph+FlMImRxj9zolK P15x3bAuLO/DOFQb4+qyqht5AZz/s3M7LkCpj5okx3e7jr2PB1kaAtJg== X-Received: by 2002:a05:651c:505:b0:393:a31a:ab30 with SMTP id 38308e7fff4ca-393a31ac91cmr4741351fa.0.1777900913930; Mon, 04 May 2026 06:21:53 -0700 (PDT) Received: from localhost.localdomain ([94.158.58.95]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-393610ba631sm31780481fa.12.2026.05.04.06.21.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 06:21:53 -0700 (PDT) From: Stepan Ionichev To: mchehab@kernel.org Cc: gregkh@linuxfoundation.org, dan.carpenter@linaro.org, aadarshmandal9354@gmail.com, luka.gejak@linux.dev, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Stepan Ionichev Subject: [PATCH] staging: media: av7110: remove dead av7110_reset_arm() Date: Mon, 4 May 2026 17:21:05 +0500 Message-Id: <20260504122105.1428-1-sozdayvek@gmail.com> X-Mailer: git-send-email 2.33.0.windows.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The av7110_reset_arm() function in av7110_hw.c is wrapped in an "#if 0 / #endif" block and therefore not compiled into the driver. The function name is not referenced from anywhere else in the av7110 driver tree: $ git grep -n av7110_reset_arm drivers/staging/media/av7110/ (no results after this change) The actual ARM boot path is implemented by av7110_bootarm(), so the disabled av7110_reset_arm() is leftover code with no remaining purpose. Drop it; "#if 0" blocks are dead code and should be removed rather than kept around (see coding-style.rst, section 21, "Conditional Compilation"). The "/* av7110 ARM core boot stuff */" section comment is kept, since it still applies to the helpers that follow (waitdebi(), load_dram(), av7110_bootarm()). No functional change. Signed-off-by: Stepan Ionichev --- drivers/staging/media/av7110/av7110_hw.c | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/drivers/staging/media/av7110/av7110_hw.c b/drivers/staging/media/av7110/av7110_hw.c index 49ce29577..3cd0988db 100644 --- a/drivers/staging/media/av7110/av7110_hw.c +++ b/drivers/staging/media/av7110/av7110_hw.c @@ -96,27 +96,6 @@ u32 av7110_debiread(struct av7110 *av7110, u32 config, int addr, unsigned int co } /* av7110 ARM core boot stuff */ -#if 0 -void av7110_reset_arm(struct av7110 *av7110) -{ - saa7146_setgpio(av7110->dev, RESET_LINE, SAA7146_GPIO_OUTLO); - - /* Disable DEBI and GPIO irq */ - SAA7146_IER_DISABLE(av7110->dev, MASK_19 | MASK_03); - SAA7146_ISR_CLEAR(av7110->dev, MASK_19 | MASK_03); - - saa7146_setgpio(av7110->dev, RESET_LINE, SAA7146_GPIO_OUTHI); - msleep(30); /* the firmware needs some time to initialize */ - - ARM_ResetMailBox(av7110); - - SAA7146_ISR_CLEAR(av7110->dev, MASK_19 | MASK_03); - SAA7146_IER_ENABLE(av7110->dev, MASK_03); - - av7110->arm_ready = 1; - dprintk(1, "reset ARM\n"); -} -#endif /* 0 */ static int waitdebi(struct av7110 *av7110, int adr, int state) { -- 2.33.0.windows.2