From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DF2C3D3319 for ; Mon, 4 May 2026 12:36:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777898175; cv=none; b=nbpDDk0/Z894kQY+jM/qo9yAL5zTGqBYOwTi/4rzyt9Afe7/JylM13RY2hGPJuw1t90NiFZkwcnR8fv6Z4C4sm4KAo/EbfHfUio0o3EbKIEyZiktvW9JzCvb1NuZWHeWlt0A5OfYKsS5yP31Mgi9GWomkL6DmtFXWfgejnzD65U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777898175; c=relaxed/simple; bh=x7BJo8G4BQ7mbaqD7pOmIDjCj2u1uZCK/VcKKVwplxg=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=kfT8m00shV/sY44NjjyuQnmA1w9Td3lUA7aAriPP5+Lohde2IhEB5YqewhU94CZyIyPp14ruWtNSGxAtKgnw8NnYVIye9zydPBGC3ApVNCgjafzES/jXb81PMlbChaOLUa6v7t/3G3Iek8DbjCm2yzY01bp5aCea8MqcbCHOi18= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lzQgOQ2o; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lzQgOQ2o" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-356337f058aso2574325a91.2 for ; Mon, 04 May 2026 05:36:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777898173; x=1778502973; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=u1rtTuY5BE7rdQoV+ciJbr7UnJ/IDuL1onVBT7GuRBM=; b=lzQgOQ2oxyHho4n3O5mv0obWPTYoSkdZgMbASJTAlRpcQbpCjCnnoXa9rrCRQgxOuv ZDb8BO1XvLNCvtO+HO7Ym9Z30A8txkB4QDMQdRlSo3T4MrX5TzL/BK2zmBcGfd2UhWOf Qdwb4JI8juPieW2DR/8XMcvJPNEo+0iF1NAWBZm63o3qU8M25N3TU73vaHGo2svNdkBq 0IHCXTDvw7ACuLaHTMkexqmT5pUVT4bgU4X3smew7oITtWMf3fjoC01CRDNxbss6xSjv n2qDKmESB0p6iu9SMFHJkFviU+bqkRS7q4ddp9zwJ/LMdwX6VRTUFdBdusI17+hUvzK/ 1aOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777898173; x=1778502973; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=u1rtTuY5BE7rdQoV+ciJbr7UnJ/IDuL1onVBT7GuRBM=; b=fgDGDaEGr/2ibMXutmnWEcSyvw5LyS50vUfpRKuU1Iw6bcekpriZIlcU89Zp4XBybt Rat+xPu+wvqxRnS96xRuZEkl7MvOuI13SDCffIZDXIzUsCPU6C+tcq1Oyu3iQE2iSNPy tNJnOHYtKLnF6RLdQKE7ocMplggz6CwOaCWxfCOHu8/IxOiKxT+gTv16UvkZDY5uc8dt WtSdX6sHrret4nvvMj0F9Ok83/qoNXmNA60o/meAlajFRclEGayz19DM3eEU8cQWSY7z 95i8QkZKmsrNz0A66s0rGiJqaLZruVC1hm81eMxndx/qP5O562JofimV1MPDnPsUmL2d YOFg== X-Forwarded-Encrypted: i=1; AFNElJ8bNsUHXnlBX1LoOktPco7iEjcscSS4YHYm3hHMa24CxcXjoT6npBGelVzV318rPnjUtNLx/sk4ReUbMB0=@vger.kernel.org X-Gm-Message-State: AOJu0Yyn0XofyLp5gl/m5M1veHLDhZ3r7qNvhi6wlmtta+A9zWNY+ziF bk5NbipYEVALpsLm5JpQgL6ZBT67NgZWhn+5Syy5ojkByzTvgknKYgVK X-Gm-Gg: AeBDievpLbhe0LnmGD/qRHjCYanghXVUaJnOLZI7WMjt8afa2wJnGxKOWCJo7/aZq5S tRGVNMkTjMQCR8Mn1Esj2XPHxwiJlNYGuQ5yorow83kWrR+B91lXZ4dKM1rNxEdUirIgCohobcl S6P3qcOk5KfPvwKgDzlUiCYDsYxSUmZS+oy1dnjq/W2goquL6LTTWVZtaz5lUAXcD9NPVCnT+HG rK3t80xwxV3Lr7V1wAiqlQiNiY7KHIE8oAlzFmpoQTXwZi+O7K05erz6L/KSrYoD37Uk2dYgJw1 /B63r5a8rhMnolmnKnDPfgdfZ1pCWqlTqm0vC+SuegDeKGsiFSWYDPaGZvOELpNXHJC9eiuLJLn Dc8ygcMGyvl+IkcJXTDJJgFPJ/zS+omNeTkYUmB61swNSghR7UMATd/v9CwQ9Msn4PA0/j6htAa RgHZbzka+Oj1wH0e/019dU4r7N X-Received: by 2002:a17:90b:4a4b:b0:35d:a0b7:9608 with SMTP id 98e67ed59e1d1-3650cdb749fmr9402918a91.7.1777898173329; Mon, 04 May 2026 05:36:13 -0700 (PDT) Received: from dev.. ([129.41.58.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-364f3f684c3sm4298527a91.3.2026.05.04.05.36.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 05:36:12 -0700 (PDT) From: Rohit Chavan To: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Rohit Chavan Subject: [PATCH] nvme: use str_enabled_disabled() for digest mismatch messages Date: Mon, 4 May 2026 18:05:55 +0530 Message-Id: <20260504123555.1741525-1-roheetchavan@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace open-coded ternary expressions with str_enabled_disabled() when printing data and header digest mismatch messages in nvme_tcp_init_connection(). This makes the code more readable and consistent with existing helpers used for boolean string representation. No functional change intended. Signed-off-by: Rohit Chavan --- drivers/nvme/host/tcp.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c index 243dab830dc8..b3165cd79a31 100644 --- a/drivers/nvme/host/tcp.c +++ b/drivers/nvme/host/tcp.c @@ -8,6 +8,7 @@ #include #include #include +#include #include #include #include @@ -1550,8 +1551,8 @@ static int nvme_tcp_init_connection(struct nvme_tcp_queue *queue) (!queue->data_digest && ctrl_ddgst)) { pr_err("queue %d: data digest mismatch host: %s ctrl: %s\n", nvme_tcp_queue_id(queue), - queue->data_digest ? "enabled" : "disabled", - ctrl_ddgst ? "enabled" : "disabled"); + str_enabled_disabled(queue->data_digest), + str_enabled_disabled(ctrl_ddgst)); goto free_icresp; } @@ -1560,8 +1561,8 @@ static int nvme_tcp_init_connection(struct nvme_tcp_queue *queue) (!queue->hdr_digest && ctrl_hdgst)) { pr_err("queue %d: header digest mismatch host: %s ctrl: %s\n", nvme_tcp_queue_id(queue), - queue->hdr_digest ? "enabled" : "disabled", - ctrl_hdgst ? "enabled" : "disabled"); + str_enabled_disabled(queue->hdr_digest), + str_enabled_disabled(ctrl_hdgst); goto free_icresp; } -- 2.34.1