From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A4023D75BF for ; Mon, 4 May 2026 12:48:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777898930; cv=none; b=lYzR5OL+3i8IdEIbwxW0tFM8tEAqO+vC2MFMIrpnaiW11f7CtPZMhSySlJbXVjT+c+6evoXV6JVRyYn0I1lIwkd3oJfmNhJPQoiEf/FfhnJGR76Q2MHfKXb57ncwCOvM6fNq5DqCVH2QEPKcVrF07Te/PagG0nIYvnHcboUiKr8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777898930; c=relaxed/simple; bh=lH1s4f1DsUeMWlf3k4JQdvGtPacKmGPSl5TfO1+bXNk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H3/3qjmDYktGftwaEbLGAkGSH06/iON7iKhtVmHtA+iLFIzYYYS+DhuCuyIpUu6QZa5BWSJyHBDiCmr00rEJOi10b9mCPGGhypPQaXCWh3MraABBwmnGAlB0NQfJnCnkgmUzrtyjwp8MgeRjHV9I48rPeZK+Y4iXCjwbxpRF4mA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kTV0ng8r; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kTV0ng8r" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-5a2b636b944so4160301e87.1 for ; Mon, 04 May 2026 05:48:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777898924; x=1778503724; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6Hp5CCZAjAcFJLhnHM/r6dRzm24SM3LtlL2s2xjPAQQ=; b=kTV0ng8rUOnQWbzbNTt64ZahPZULzCKBET07M0IVlowy6KeRD47g+/f+TVHXEzdyfw n5QfygX51wuIz+mW9dlgVrgcCcg7FseRb+D3cM2flqIa9Yc3sv2eV35bz+5tp6ZlUNq2 3gGa21lgOL8nkdaNZnXMowAKXbMkW5EmK6h3In3DlWIddsCSDkdfSEYtfj3QGSe11SEU PYwikP2CTeRhx5Bgq2fb8iuWhW2qjhQ7l91CclnyI6/Z/Sr/RuQOPMLFoQqZ5TxSf6c+ t4qFitoMqX1oRTUOzkm0Mi9O5h8JpH5YjbwU/DE22tcX3pAWnTuX/tsyMpwGt2cpFq/S eLXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777898924; x=1778503724; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6Hp5CCZAjAcFJLhnHM/r6dRzm24SM3LtlL2s2xjPAQQ=; b=NqxuQIbPmmgKNK/CnPhs+jUC0ln1sgrQ1OEaoKy0RxBzQMY0uq147LgzvhPKpoOYWz /h2K2uBTaofP6nJnTu7t2aG6Gl47aSeAPgAGFBgeYzdje2PBxRFnZrmNp61X6DzpErp+ AblNih3PVw0jqmxB55xPJX3o740jVyIZgOfvdQ1swzFRBROiJOAMVoAKS6D2WK5G0lqv IJai0OuVkk58aV5ZiODmkwk8aUIZDmugcT2+Z5M5t/i1YWeFIfy7NJ48EiMh08+Cwl9Q pWOEsB3PtHgsB3hl7wDSmRRN5hKYuevHx2dvjLqQW37Y8B6Pks5elyofwI042xLR14Jk nM/w== X-Forwarded-Encrypted: i=1; AFNElJ/Tz53i5sd8B3t3YOqmR/gJRadqkxWN/wguSR8Hw+lct/e6lVI/wayhzFTDtvYGDlc7rsLdNpf+ZUzacJM=@vger.kernel.org X-Gm-Message-State: AOJu0Yxij4T+Hkar5nWz3d/y/XOA0xbxbB6oMpyJahbVDi5jUdDmAsPS 5wjZeZp0gECOwbVGP280oWfpBnRsfwwoinJu3BbUdgdwBYwU0NuitPUKUQcf8HbmuL9z35uwJGw = X-Gm-Gg: AeBDiev2VpYrrwQpPmHFSC9vJdWQoOaiwvgmeN6IgvXN8GOrmxd07FWJYxkw2B43CiD s9DFAS+XGFzgL3DaFdIBlt21gN/xRGYpu9rhy9U+flGk3d8nS+4kN79+7ONdK2yKMQkQa3VjPpI 6VTyB8ejgYP9MHCoeEz5hZgIULyknSagx+cpdKg99xYaBi7efDhfnxEhEbj7Xlb5c/znHWqOD67 z2c31CqdDXlJh9p3vkhtDGFgTm69D/dU/qnM8XmeCeACB5OF07V0YrNIyjCyK4Jci7kbDDhCpH4 P2ug1juKbP7RzWHVrXiF0Jt71DTlGJ+uTaOJorSiwgy/DSpBgMmTHidr0x0zjjVQXxKoLbVXpjP tBaKLjk3O4zaElaWXpq9hcafQ6N9h+fstFZP4CEZa36X4DkIrHPqSh67jHYFbtf393Ir+nQKpS2 /ooVKYVNUQb15ATZ1rkk5dWeCaIFdZrhPw9IGCmfskfENYNJNidwPAOjj1vXo/My5MxxDEBT3nu EYslRiMhQ== X-Received: by 2002:a05:6512:3b0a:b0:5a8:5276:f0db with SMTP id 2adb3069b0e04-5a862fbccfcmr2796502e87.15.1777898924030; Mon, 04 May 2026 05:48:44 -0700 (PDT) Received: from va-HP-Pavilion-Desktop-595-p0xxx.mshome.net ([193.0.150.248]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c34165esm2922831e87.56.2026.05.04.05.48.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 05:48:43 -0700 (PDT) From: Valery Borovsky To: Lee Jones Cc: Ben Dooks , Vincent Sanders , Andrew Morton , linux-kernel@vger.kernel.org, Valery Borovsky , stable@vger.kernel.org Subject: [PATCH v2] mfd: sm501: fix reference leak on failed device registration Date: Mon, 4 May 2026 15:48:41 +0300 Message-ID: <20260504124841.443496-1-vebohr@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <6b4a9f5ae8a316b6f07f72f2fe3f0b8fc5f18dff.1777889235.git.vebohr@gmail.com> References: <6b4a9f5ae8a316b6f07f72f2fe3f0b8fc5f18dff.1777889235.git.vebohr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When platform_device_register() fails in sm501_register_device(), the platform device allocated by sm501_create_subdev() has its struct device initialized by device_initialize() inside platform_device_register(). The error path logs the error but returns without dropping the device reference, leaking the memory allocated by sm501_create_subdev(): sm501_register_device() -> platform_device_register(pdev) -> device_initialize(&pdev->dev) /* kref = 1 */ -> platform_device_add(pdev) /* fails */ <- dev_err() called, kref still 1, sm501_device_release never called The device's release callback (sm501_device_release) calls kfree() on the containing sm501_device structure. Without platform_device_put(), this memory is never freed. Per platform_device_register() kernel-doc: NOTE: _Never_ directly free @pdev after calling this function, even if it returned an error! Always use platform_device_put() to give up the reference initialised in this function instead. Fix this by calling platform_device_put() in the error branch, which triggers sm501_device_release() and frees the allocated memory. Fixes: b6d6454fdb66 ("[PATCH] mfd: SM501 core driver") Cc: stable@vger.kernel.org Signed-off-by: Valery Borovsky --- drivers/mfd/sm501.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c index 0ee6d8940e69..8276456b142f 100644 --- a/drivers/mfd/sm501.c +++ b/drivers/mfd/sm501.c @@ -704,9 +704,11 @@ static int sm501_register_device(struct sm501_devdata *sm, if (ret >= 0) { dev_dbg(sm->dev, "registered %s\n", pdev->name); list_add_tail(&smdev->list, &sm->devices); - } else + } else { dev_err(sm->dev, "error registering %s (%d)\n", pdev->name, ret); + platform_device_put(pdev); + } return ret; } -- 2.51.0