From: Greg KH <gregkh@linuxfoundation.org>
To: Debjeet Banerjee <debjeetbanerjee48@gmail.com>
Cc: dtwlin@gmail.com, elder@kernel.org, greybus-dev@lists.linaro.org,
johan@kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v2] staging: greybus: uart: clear unsupported c_cflag bits in set_termios
Date: Mon, 4 May 2026 16:15:32 +0200 [thread overview]
Message-ID: <2026050413-smell-ramp-e2a6@gregkh> (raw)
In-Reply-To: <20260427045446.16430-1-debjeetbanerjee48@gmail.com>
On Mon, Apr 27, 2026 at 10:24:46AM +0530, Debjeet Banerjee wrote:
> gb_tty_set_termios() derives UART line configuration from a subset of
> termios->c_cflag bits (CSIZE, CSTOPB, PARENB, PARODD, CMSPAR, CRTSCTS,
> CLOCAL and CBAUD). Other bits are not interpreted by the driver and are
> not represented in the Greybus UART protocol.
>
> Mask unsupported c_cflag bits so that userspace-visible termios
> reflects the supported bits implemented by the driver.
>
> This addresses the existing FIXME.
>
> Signed-off-by: Debjeet Banerjee <debjeetbanerjee48@gmail.com>
> ---
> v2:
> - Clear unsupported c_cflag bits as suggested
> - Update comment to mention the change
Has this been tested? If not, I'd prefer to leave this as-is until it
can be.
thanks,
greg k-h
prev parent reply other threads:[~2026-05-04 14:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-19 3:26 [PATCH] staging: greybus: uart: document c_cflag handling in set_termios Debjeet Banerjee
2026-04-26 19:16 ` Greg KH
2026-04-27 4:15 ` Debjeet Banerjee
2026-04-27 4:54 ` [PATCH v2] staging: greybus: uart: clear unsupported c_cflag bits " Debjeet Banerjee
2026-05-04 14:15 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026050413-smell-ramp-e2a6@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=debjeetbanerjee48@gmail.com \
--cc=dtwlin@gmail.com \
--cc=elder@kernel.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox