From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9BC73BFE5D for ; Mon, 4 May 2026 12:36:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777898210; cv=none; b=KQ+O0ZJN1eYVdRD7T9SP2u7Q8x4TqE8JF9sRpVUbWjT081TyVa3J/PObxPf/1uiD5QBsHh87yzd2YrPkAUK3BvjHuSiYtZTMvMy0sg7p6ls8ML7WNSPpCDwvQ4QuHRcBR8Qqgjdv2NHc40zOWlu62GCfplYUVZBUVvYIaxxQWNI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777898210; c=relaxed/simple; bh=pPpEVrSqrs2Hed5MCNsN0C6XndNM+lywifHhqrslFF4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NK1RVBJrcjv1D8otlx+2qDMH1w7kzaOAeePWEWVYyTp4UNxVOvtaladvytST2xcNOig3GzSSJXjDU11C8UVTBn36eHxx87WxY47fd5rYgNwkbEqVumOdLU2bYOPJLxNmNjmavVZQzEsfdSD+FHBb6SRGWbSyWSYKjzzrTFwSCPs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z8Q6kIBa; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z8Q6kIBa" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4891b0786beso27644865e9.1 for ; Mon, 04 May 2026 05:36:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777898207; x=1778503007; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=6ObbHgO79iWTpdeb3bVEymQ0c73qV4KX+gaPzQKE724=; b=Z8Q6kIBafVy3dOMyTkD36xF00y2SoiIuVxBaBog44Z1Dlt4tdcN3dhLkzYMa/TYOpx W78nAkHGXtj1lBqVoPtOx9ouai48THx2AcZ9pNN98UeUu6sdI8+W1vR6GVHv5g16NGQB SUfas03YQDjF9IHqyf/eOGWE97YerjAm+OdWhhU6gvE/jC/+G3fBFQMmLdyDWN1nM870 87Q7Rtx8gcJu3c2enVM+ZffwwujUzWiHVnIIziTZ7ITXF3IEtFncjBVi3H9uULbEzhXU /Y4QSNgJ0NbZnCw1Y6DbZmvhzIpt2uIwSaWCQAGJoJ9HUp0hjH/U3ZrTsg04GuYVQmze EShg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777898207; x=1778503007; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6ObbHgO79iWTpdeb3bVEymQ0c73qV4KX+gaPzQKE724=; b=mrYIGM4Rp/SdWlpRvvzF7bF3R4nE65AsXvo2HHq7/SXHsc6cDDcFQDRlaYQo8i97aU k9UUM7VD620tRm6BWgWmQDlWsxc1rj4iXWIQF0NEcGT+G+2vD6TthbMOI/8pzqkVnsQl ET61R4j+xqsq24OAtjpTUbzHqTXZLQ5D/5u/yioNFLS/L1Eo+HLdWEJVKGoRaUPrT+vI aP8jx0ZjSpcTts9kB/k+Oeb2rP/u5RFff/RiirqY7UmVWtY3sHs01xzwdEr4Ytl3UL6X l9HYHt92GkCkHWYV5Excv4lsZ4B2KejLYOP1Jl2c2x1CSdD6QcCFoJuLafnV726/N1Pp p2kw== X-Forwarded-Encrypted: i=1; AFNElJ/FDiiQSlDN9xxgT5xPeEMPFAWt4TMAdREsqV1rn+Vu1z2NGoYj4SWPGGWh/LwqO3tmtaYX2ZsHniG/VOI=@vger.kernel.org X-Gm-Message-State: AOJu0YxHw5N0/cKYO7Lk7nKfnnKVLw8gHZ1e9N3ERQLLVg7QAt94xhLx 4MaFKOTOcXz6eeVLEEmTeFg8rPNjokDzJRwpC2xdtR9/Bocs28xs79ck X-Gm-Gg: AeBDiet1JO8kKe1hznYjIa/wXf0Xi8pqp8fh/Td7UzL2giqak+5jxBac5XPdiResqX5 UTP7UVL8guy9SOC+jtCC1yoEQxGXET15oSToABGBuMZFovMRAv9C2s8riNbycj9ZYbz6eQyCmmj gX01yTd+Kd5FGWJSdfttgUOVrZqBTpOZSkHBn5cyjJkSVrGgIp0bIm1jFl9tIMTIeGW5OPiHQ/G m/JuvshDHOifxvGbNNlaezCJI1WGdaIHZbrUriIZG3Qb18Xay1tKA7YwwOkSdJtEYxZSWa7Op1e uH78DRW8osjnUXnma7lLltRhdSz7tLdpg+F/OAeSToG+CJWIjYG9AfBf2UFhIF/CBt70+GE0kK9 v/fpOrvNjvEVo4kgHfOOPRwNTZYYuYzvuctRVFATpc7W0qLxL1mSihCUBJl17PMNvHcVlHpf9I1 8O4U6Tv/zyx2Tg52NIIPlYxy+IFAtlYIiHrMmQuF4lARh/Ad+L2nc9e2ImQrdzrXwgxRDtVJLXG HI= X-Received: by 2002:a05:600c:821b:b0:489:1d23:4524 with SMTP id 5b1f17b1804b1-48a9852f4demr153842675e9.5.1777898206658; Mon, 04 May 2026 05:36:46 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a822bf3ffsm352036125e9.7.2026.05.04.05.36.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 05:36:46 -0700 (PDT) Date: Mon, 4 May 2026 13:36:45 +0100 From: David Laight To: Pedro Falcato Cc: Thorsten Blum , Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/mseal: use min/max in mseal_apply Message-ID: <20260504133645.517d7a0b@pumpkin> In-Reply-To: References: <20260503115915.18680-3-thorsten.blum@linux.dev> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 3 May 2026 21:58:57 +0100 Pedro Falcato wrote: > On Sun, May 03, 2026 at 01:59:16PM +0200, Thorsten Blum wrote: > > Use the type-checked min()/max() macros instead of MIN()/MAX(), which > > are supposed to be used "for obvious constants only". > > Gotta love these macros... FYI this isn't the only wrong usage in the kernel. I failed to persuade Linus to include a test for __builtin_constant_p((a)|(b)) :-) -- David > > > > > Signed-off-by: Thorsten Blum > > Reviewed-by: Pedro Falcato >