From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBBB4201004; Mon, 4 May 2026 16:33:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777912430; cv=none; b=Tubmcw4eIOQReUlu8iUvL1aOD5HgnzeE3BpJ4AiQileuUcJi/Z301ZtrIAxuFB9lZu+EtsYIk5h0eIrciBWfVqywjSXt/AgRT6RmUS/ssBac9+a3TPNjfLyyEP7K6NkkLyrS0+EYHmXEkHq6jJVRC8iDaF5yhZ3ipjeVtymlrjo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777912430; c=relaxed/simple; bh=cfzmXBDD422Por2LycrwmL6gW7qKihpcCAhAXwjAaEw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bXYsOS3MbsNO4tsXt4uI8IUwhzqV/kk2tQ8nfqAUuRc0hGwrytKmdYu53yQKNOoE4Hm30UmRAEmYrXDWah8NCwhz1xNMxifjqvr6NYzf4qk2w18UmVb2zLCNPmVXHw8O9IsuO/9UpaHIHlvzvxhNra+niKV1A7Hew0b9F6/UKyM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=rUrAPYey; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="rUrAPYey" Received: from killaraus.ideasonboard.com (2001-14ba-703d-e500--2a1.rev.dnainternet.fi [IPv6:2001:14ba:703d:e500::2a1]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7C3A09C; Mon, 4 May 2026 18:33:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1777912424; bh=cfzmXBDD422Por2LycrwmL6gW7qKihpcCAhAXwjAaEw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rUrAPYeyapt7U6A033SCkQly5hGUACZeILzTaCoo/zhWqAvQkZYig/KxXOks6nWNF +mQmvYBFY1yLdCZtTJbujncTJg3f10lZ8BQDZeh+DS2omCGMjll8J4BZ43NXelpeqm U3Hv9iUwLY8rJOcXjck2D40TI3gagvm3DdC9vo4A= Date: Mon, 4 May 2026 19:33:45 +0300 From: Laurent Pinchart To: Maxime Ripard Cc: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Shuah Khan , Dmitry Baryshkov , Jyri Sarha , Tomi Valkeinen , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Simon Ser , Harry Wentland , Melissa Wen , Sebastian Wick , Alex Hung , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Chen-Yu Tsai , Samuel Holland , Dave Stevenson , =?utf-8?B?TWHDrXJh?= Canal , Raspberry Pi Kernel Maintenance , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Stone , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v3 03/20] drm/atomic: Drop drm_private_obj.state assignment from create_state Message-ID: <20260504163345.GH1344263@killaraus.ideasonboard.com> References: <20260424-drm-mode-config-init-v3-0-8b68d9db0d8b@kernel.org> <20260424-drm-mode-config-init-v3-3-8b68d9db0d8b@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260424-drm-mode-config-init-v3-3-8b68d9db0d8b@kernel.org> On Fri, Apr 24, 2026 at 12:18:43PM +0200, Maxime Ripard wrote: > The initial intent of the atomic_create_state hook was to simply > allocate a proper drm_private_state and return it, without any side > effect. > > However, __drm_atomic_helper_private_obj_create_state(), which most > atomic_create_state implementations call, introduces a side effect by > setting drm_private_obj.state to the newly allocated state. > > This assignment defeats the purpose, but is also redundant since > drm_atomic_private_obj_init(), the only call site for the > atomic_create_state hook, will also set this pointer to the newly > allocated state. > > Drop the assignment in __drm_atomic_helper_private_obj_create_state(). > > Fixes: e7be39ed1716 ("drm/atomic-helper: Add private_obj atomic_create_state helper") > Signed-off-by: Maxime Ripard Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/drm_atomic_state_helper.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_atomic_state_helper.c b/drivers/gpu/drm/drm_atomic_state_helper.c > index 76746ad4a1bb..875149494b00 100644 > --- a/drivers/gpu/drm/drm_atomic_state_helper.c > +++ b/drivers/gpu/drm/drm_atomic_state_helper.c > @@ -729,12 +729,10 @@ EXPORT_SYMBOL(drm_atomic_helper_connector_destroy_state); > void __drm_atomic_helper_private_obj_create_state(struct drm_private_obj *obj, > struct drm_private_state *state) > { > if (state) > state->obj = obj; > - > - obj->state = state; > } > EXPORT_SYMBOL(__drm_atomic_helper_private_obj_create_state); > > /** > * __drm_atomic_helper_private_obj_duplicate_state - copy atomic private state > -- Regards, Laurent Pinchart