From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EF853DF015 for ; Mon, 4 May 2026 15:00:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777906859; cv=none; b=Pz5FLxSEBwn5/uAIsGfugY6zCJsd+WqRtAE+j/AUXFoNNu7+wvoome4gwqsAV8DXtYWF9Lh6epXZbXKDzQWdB/txhgHL1sjhTXHASkLnagj9QUan2Un9Pt1uHaml1rWfXtTzSFSYieHGc+HzvLQy2BwkB10vrBseVq1o13c/NLs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777906859; c=relaxed/simple; bh=xWfpnUZfLeM39wUROZg2x6WISFfY57/hGwZjThDIqQU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=T29j/5f0lyRT3cv65HsDBX/vhr9VrTwXyMIOF/EG6aXLUCrn5jqwCjqz5Zc9nBkRQicNQmNvgrUXBDfLGnAVxik/YiQsKE7qe3MezX8LINDkauT+1ar5IMd2+FNdlT+r10hrYb9f2nEXOsWKEjJgevlzaDSPfHyOHXI9ZAqMFOE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=aqpdwaok; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="aqpdwaok" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1777906856; bh=xWfpnUZfLeM39wUROZg2x6WISFfY57/hGwZjThDIqQU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aqpdwaok+7uZsXLXhTblfDb4NS2nvQrMnkx0YttSRFAVmHQIDS3u+yYCSXgtp3RtH 2bxV73kSvk6vQ8OyEKh7Qlrk5nPEpgSJq9lEPNJoAxQuvJH1WIqK0q1Sydb6F28G2q UteirA/NBr+WGYbGWAm4eiWfwu5tRi0VkJ1ebOGqGse9MGw2calw+LFIBciaDnC9zU G9iAcH//L07TM5WX8boSZ3hioY56BBJU6I9CYTFNYk/Ss1dUGDsK8zb3nnFQf04+k8 y8zeywlb6EuGpt5bKhU5JKct5DRpnXTSJMzyMK39CMlkQgxRYcts1mgLd3AUOpq1TA v+iFvWhroQHzw== Received: from fedora (unknown [100.64.0.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 0B81E17E131B; Mon, 4 May 2026 17:00:56 +0200 (CEST) Date: Mon, 4 May 2026 17:00:51 +0200 From: Boris Brezillon To: Steven Price Cc: Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/10] drm/panthor: Automate CSG IRQ processing at group unbind time Message-ID: <20260504170051.64759934@fedora> In-Reply-To: References: <20260429-panthor-signal-from-irq-v1-0-4b92ae4142d2@collabora.com> <20260429-panthor-signal-from-irq-v1-7-4b92ae4142d2@collabora.com> Organization: Collabora X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 1 May 2026 14:53:22 +0100 Steven Price wrote: > > @@ -2970,8 +2963,6 @@ void panthor_sched_suspend(struct panthor_device *ptdev) > > > > if (flush_caches_failed) > > csg_slot->group->state = PANTHOR_CS_GROUP_TERMINATED; > > - else > > - csg_slot_sync_update_locked(ptdev, csg_id); > > The justification for this change doesn't seem to be included in the > commit message and looks suspicious. Hm, right. I somehow confused csg_slot_sync_update_locked() and sched_process_csg_irq_locked(). > Although AFAICT the events_lock > wouldn't be held here so it could trigger a lockdep assert before this > change... Yeah, the guard(spinlock_irqsave)(&sched->events_lock); should have been added to patch 4.