From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-177.mta1.migadu.com (out-177.mta1.migadu.com [95.215.58.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7732D3C6A39 for ; Mon, 4 May 2026 18:16:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777918584; cv=none; b=BpLxIDWEEGb5jd5SFoLAMjvxK4DK19KVEvgpi/5DUVXI7fREqmtAmt2bc2ZuK570zQLfaygMtDZ/UvdVhLoyRAAIA13PmZ9cZxHznxSFRzGZg7yqq0pWK3u1xsI/CKiSe69MNbp1b13VQm0BplJih47b75Q3bynjhrWWHwGHxzU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777918584; c=relaxed/simple; bh=GUollpyndkkqk7y15YK57X1BnbWZqCU7lcTzAI1Krtg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=plrm3NXpMBQqGqeLbcLM7ZgoGUPmCGR0YJBXAXuLzxL/20dlPC0cbgduoWt3zPdOIrGSCzB291kwSAwjgPY4kfCAEK0AQGXRizyZ+3L/cWXjxqth77/abwOhyvlpC28CZPZW/Il/NsHpbTyf6zYMzNChfmPxunlXXP8ppngWzVg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=AOaMEt+3; arc=none smtp.client-ip=95.215.58.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="AOaMEt+3" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1777918580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=2sirbH050P4iZwfAlDGl+WqUVJ3L+YNTCpGjJATVmvE=; b=AOaMEt+3cUM+ANCCl5DfG8YfTcuC1wUTYCYBnidRYaUx+GQGeSYok5IqK425hCdvtZCtoX Mdtls8faTJh2FE1lvbdZIR7aIw5aoVz4lRPRwVvhhoH3va8Ht0Nqphki4g0dDeal9ubrdH yLuTF6oB36R6A/KKdwRexxueRgXHNDM= From: Thorsten Blum To: Parthiban Veerasooran , Christian Gromm Cc: Thorsten Blum , linux-kernel@vger.kernel.org Subject: [PATCH RESEND] most: configfs: use sysfs_emit in sysfs show functions Date: Mon, 4 May 2026 20:16:00 +0200 Message-ID: <20260504181559.143576-3-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=5138; i=thorsten.blum@linux.dev; h=from:subject; bh=GUollpyndkkqk7y15YK57X1BnbWZqCU7lcTzAI1Krtg=; b=owGbwMvMwCUWt7pQ4caZUj3G02pJDJk/HsX/lQ41Wz0/LXv14xuiqcrvKzra52h8K8tVqI0+s 1ZQJX5hRykLgxgXg6yYIsuDWT9m+JbWVG4yidgJM4eVCWQIAxenAExE4i4jQ2f07G2PJO7PUL+p ul/kjtyvO1P3d9Xnf9347l/2gzfB/+4wMqy5Ne1md0Lw/8yo3IyeouMfLy3IUfzHFv+U8bjcBH3 zOFYA X-Developer-Key: i=thorsten.blum@linux.dev; a=openpgp; fpr=1D60735E8AEF3BE473B69D84733678FD8DFEEAD4 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Replace snprintf() with sysfs_emit() in sysfs show functions, which is preferred for formatting sysfs output because it provides safer bounds checking. Signed-off-by: Thorsten Blum --- drivers/most/configfs.c | 28 ++++++++++++---------------- 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/drivers/most/configfs.c b/drivers/most/configfs.c index 8f5158d95bc3..f2aae6874b64 100644 --- a/drivers/most/configfs.c +++ b/drivers/most/configfs.c @@ -8,6 +8,7 @@ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt #include #include +#include #include #include #include @@ -159,7 +160,7 @@ static ssize_t mdev_link_destroy_link_store(struct config_item *item, static ssize_t mdev_link_direction_show(struct config_item *item, char *page) { - return snprintf(page, PAGE_SIZE, "%s\n", to_mdev_link(item)->direction); + return sysfs_emit(page, "%s\n", to_mdev_link(item)->direction); } static ssize_t mdev_link_direction_store(struct config_item *item, @@ -177,7 +178,7 @@ static ssize_t mdev_link_direction_store(struct config_item *item, static ssize_t mdev_link_datatype_show(struct config_item *item, char *page) { - return snprintf(page, PAGE_SIZE, "%s\n", to_mdev_link(item)->datatype); + return sysfs_emit(page, "%s\n", to_mdev_link(item)->datatype); } static ssize_t mdev_link_datatype_store(struct config_item *item, @@ -196,7 +197,7 @@ static ssize_t mdev_link_datatype_store(struct config_item *item, static ssize_t mdev_link_device_show(struct config_item *item, char *page) { - return snprintf(page, PAGE_SIZE, "%s\n", to_mdev_link(item)->device); + return sysfs_emit(page, "%s\n", to_mdev_link(item)->device); } static ssize_t mdev_link_device_store(struct config_item *item, @@ -211,7 +212,7 @@ static ssize_t mdev_link_device_store(struct config_item *item, static ssize_t mdev_link_channel_show(struct config_item *item, char *page) { - return snprintf(page, PAGE_SIZE, "%s\n", to_mdev_link(item)->channel); + return sysfs_emit(page, "%s\n", to_mdev_link(item)->channel); } static ssize_t mdev_link_channel_store(struct config_item *item, @@ -226,7 +227,7 @@ static ssize_t mdev_link_channel_store(struct config_item *item, static ssize_t mdev_link_comp_show(struct config_item *item, char *page) { - return snprintf(page, PAGE_SIZE, "%s\n", to_mdev_link(item)->comp); + return sysfs_emit(page, "%s\n", to_mdev_link(item)->comp); } static ssize_t mdev_link_comp_store(struct config_item *item, @@ -241,8 +242,7 @@ static ssize_t mdev_link_comp_store(struct config_item *item, static ssize_t mdev_link_comp_params_show(struct config_item *item, char *page) { - return snprintf(page, PAGE_SIZE, "%s\n", - to_mdev_link(item)->comp_params); + return sysfs_emit(page, "%s\n", to_mdev_link(item)->comp_params); } static ssize_t mdev_link_comp_params_store(struct config_item *item, @@ -257,8 +257,7 @@ static ssize_t mdev_link_comp_params_store(struct config_item *item, static ssize_t mdev_link_num_buffers_show(struct config_item *item, char *page) { - return snprintf(page, PAGE_SIZE, "%d\n", - to_mdev_link(item)->num_buffers); + return sysfs_emit(page, "%d\n", to_mdev_link(item)->num_buffers); } static ssize_t mdev_link_num_buffers_store(struct config_item *item, @@ -275,8 +274,7 @@ static ssize_t mdev_link_num_buffers_store(struct config_item *item, static ssize_t mdev_link_buffer_size_show(struct config_item *item, char *page) { - return snprintf(page, PAGE_SIZE, "%d\n", - to_mdev_link(item)->buffer_size); + return sysfs_emit(page, "%d\n", to_mdev_link(item)->buffer_size); } static ssize_t mdev_link_buffer_size_store(struct config_item *item, @@ -294,8 +292,7 @@ static ssize_t mdev_link_buffer_size_store(struct config_item *item, static ssize_t mdev_link_subbuffer_size_show(struct config_item *item, char *page) { - return snprintf(page, PAGE_SIZE, "%d\n", - to_mdev_link(item)->subbuffer_size); + return sysfs_emit(page, "%d\n", to_mdev_link(item)->subbuffer_size); } static ssize_t mdev_link_subbuffer_size_store(struct config_item *item, @@ -313,8 +310,7 @@ static ssize_t mdev_link_subbuffer_size_store(struct config_item *item, static ssize_t mdev_link_packets_per_xact_show(struct config_item *item, char *page) { - return snprintf(page, PAGE_SIZE, "%d\n", - to_mdev_link(item)->packets_per_xact); + return sysfs_emit(page, "%d\n", to_mdev_link(item)->packets_per_xact); } static ssize_t mdev_link_packets_per_xact_store(struct config_item *item, @@ -331,7 +327,7 @@ static ssize_t mdev_link_packets_per_xact_store(struct config_item *item, static ssize_t mdev_link_dbr_size_show(struct config_item *item, char *page) { - return snprintf(page, PAGE_SIZE, "%d\n", to_mdev_link(item)->dbr_size); + return sysfs_emit(page, "%d\n", to_mdev_link(item)->dbr_size); } static ssize_t mdev_link_dbr_size_store(struct config_item *item,