From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f179.google.com (mail-dy1-f179.google.com [74.125.82.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BB733E715C for ; Mon, 4 May 2026 18:54:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777920900; cv=none; b=Wdpqsgqx16HB//pWyjgI4AJ6mt7DhAQjwpni3tPw6JI4L6s41gYQbZzunOAM2cFv2XoDrTNXGeMMrosbDpE+AF4V0x00Rro++2eniPQyzE363NKWF89G+maffk005QkfV6v1+YO9qwauls7zVWDejr2dZHO8FFpkXk2szxbHxVM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777920900; c=relaxed/simple; bh=X55ehTcHXaCqT0xJ22vOal7zcjBzPSQpKGIGy6t63ps=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QYVDqSlGL0YTYa6uLsLjcGc2QgcbPFP724RUWOA3UJnBgR3Ajb2W9oBOnImDSTPBB2pT2MO0lGNIbfy6A31arorlPvMsgyKLOneRpjNLHadH12tM53j9lcHAqN8Oyd18VLCYOzi+qN5hSAcrZOECPUNdD/dSSuCHxvUTqTvWXVU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Oca6NDNy; arc=none smtp.client-ip=74.125.82.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Oca6NDNy" Received: by mail-dy1-f179.google.com with SMTP id 5a478bee46e88-2bdd40d3c61so5637805eec.1 for ; Mon, 04 May 2026 11:54:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777920896; x=1778525696; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HYObmHZvceBxCd+lbo9bHNlphgzvjFOiFABepwHq0Xw=; b=Oca6NDNyU2J+lcUqGgcCel8FmGp1SeOelWw6UPmlHd8VSuCWlH/JC05prZ734Y49l8 yCXhIsGnL7Z0PqTspg/L/0aLHf4lZCbpeQqfGf2zJHlJScqBUtd3CP+k+f30LuicGeTY OsbliHqd7Qf5TOfiwr64g+hykSNvGZ0p7vWHCYjugdFGGbUV2R1LBh3pFp/7x5GTnI1M GU0iSpwM7y/Xn4REotZoTBN4Ty1wvMBCH4OX8EdS2aEg/TRRjxqBYkOChZLp0tEvcrvW RoV+aDHsFGfSP5gr0pkOpb2t05SmEvCWWn9yRRs1iHXrf6NW9qmxpyy7YGzbGjKgwx0h JEWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777920896; x=1778525696; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HYObmHZvceBxCd+lbo9bHNlphgzvjFOiFABepwHq0Xw=; b=MtAjWMYI/z3jiSku2O9KCSJ7PUy78jB2ildVucim1vA7/LtyZnfgIW88Jj/nabTQnJ pTdMSpTLD8OUm/6DNyN6cTWjBBRKOWW3KoPvhW1R5pE8+2v5HiFv6CCH02RRPvMGscxh Xc7o3Zu4+rCwKU/crqw/wfqII4+nND9rYy+JP/WxBMZ/BDF5E6xZp596aWRtP6fJv9Bf L1eiMGYRdBBaYBMGnEwkzTE+xLvciyphqOELEhO0RUFhsqkn0Q2nKwmJSME1Dqy2ogxB HMFVcVzr/s7r1Fc0W8RXHIDjn/rrL7sOanqcoVXb5+FoWGGMhOLSunW8nvKqjUBXfGkw Nhsg== X-Forwarded-Encrypted: i=1; AFNElJ8Ay1guWKFqne0/g6o8xRHIwOaotVhz8tc4NE+i68GQKEyllxAaoMoSraeGpcv4usVVxCd2pL1uXhbb2/k=@vger.kernel.org X-Gm-Message-State: AOJu0YzoA2b5MoASoxd47CA80I7B7v1MM348Vpb6KKbYO+QDHFwxwl5e YxUBFpHahGrwIcgwaHUsW4bP09k6LJdLYit7gRollXwEsl6K2TQr7Oxe X-Gm-Gg: AeBDies3LBlbgPX2TIK62NRmJFW8xlaeaSDUNZW1oscLD8blMyviuA4P2ZtV/q3F7ss h9JI49wOZ3+0+pEc8oNo6LBZpb52GUKgRUGxki3S5Fp1mQlKSWtyp+q3zKX4tUp56yInHUTWSrF H19HBHX8bMYp0+zHNsu7REyo/RlIYgMdIPII1SUbAYq5ybFv44X6R5oTBx5zuAcYiYtPp/KlAi/ D+NcjJq61wirFp/ACgmOhzgyWHxSqYGmlTVEpyCh9MbV5tvewy+6UC4MCCJv+grw3nEswfYEFN6 TAMN0okDAxPbYuCgSGZcP8jRICB0g05uJ/4GO0FKteGVVrYfckCAEhRqs7IYFL5UC3CQd4vA6Z0 mD1cvcLARocVY+KKquyXCuTfXafN3oAvqnJeFfwwhO6/5FU9kH08mSwJmlzt7Cj+UzEYbTlzKmk YUz2tnzzevPf271PYJNNwYFZv6rDt0dYqLxzi4Zr+vgTd+iCtHe+tH0zz9BnJ4CLne3+g7VgDeR W9zEpFtSUYhsHgrUjh56QdyNw== X-Received: by 2002:a05:7300:fb96:b0:2ed:2942:34ab with SMTP id 5a478bee46e88-2efb8aa1fa1mr5602385eec.3.1777920895874; Mon, 04 May 2026 11:54:55 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:5b87:9b19:32e2:2981]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ee3bf6812asm16830718eec.28.2026.05.04.11.54.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 11:54:55 -0700 (PDT) From: Dmitry Torokhov To: Nick Dyer , linux-input@vger.kernel.org Cc: Ricardo Ribalda , linux-kernel@vger.kernel.org Subject: [PATCH 3/3] Input: atmel_mxt_ts - use __free() for obuf in mxt_object_show Date: Mon, 4 May 2026 11:54:47 -0700 Message-ID: <20260504185448.4055973-3-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.54.0.545.g6539524ca2-goog In-Reply-To: <20260504185448.4055973-1-dmitry.torokhov@gmail.com> References: <20260504185448.4055973-1-dmitry.torokhov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use the __free(kfree) macro for the obuf allocation in mxt_object_show() to simplify the code. Assisted-by: Gemini:gemini-3.1-pro Signed-off-by: Dmitry Torokhov --- drivers/input/touchscreen/atmel_mxt_ts.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index d660cc5b5fe3..6af4db5ed117 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -2870,14 +2870,12 @@ static ssize_t mxt_object_show(struct device *dev, int count = 0; int i, j; int error; - u8 *obuf; /* Pre-allocate buffer large enough to hold max sized object. */ - obuf = kmalloc(256, GFP_KERNEL); + u8 *obuf __free(kfree) = kmalloc(256, GFP_KERNEL); if (!obuf) return -ENOMEM; - error = 0; for (i = 0; i < data->info->object_num; i++) { object = data->object_table + i; @@ -2892,15 +2890,13 @@ static ssize_t mxt_object_show(struct device *dev, error = __mxt_read_reg(data->client, addr, size, obuf); if (error) - goto done; + return error; count = mxt_show_instance(buf, count, object, j, obuf); } } -done: - kfree(obuf); - return error ?: count; + return count; } static int mxt_check_firmware_format(struct device *dev, -- 2.54.0.545.g6539524ca2-goog