From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1D893DEAD3 for ; Mon, 4 May 2026 19:08:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777921700; cv=none; b=Z2xH+wLyMCNTDHHbLADZrmcNL+kBSomB4EfEdR7estrBK5Mifh0ZB9kWq+H8ApJvo36vA2id28Vo6ep3OoGXBMkEtOtTkTygPZiLYgI/oEOjJRaFKlL60AsTaQ3XXjGRDnYIBqFVfdptlbhDQjiB1UOIHx7SGL3ecqQ6bTcgCb4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777921700; c=relaxed/simple; bh=/NsgYCf/YJOjQfBrxIduQkHUSM4dKNrQiRj00JRK8V0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BtnuTZ2FGIfCyDhEWBWzqeGolWeiTS5qJMbsPd/N9MxysFMqnfB5E+TYdTTkK30A7Y9SxwHD8Ggx0e1JPzg/HEAFcwn8IBjwDhJ0h/UZLqr1U/s3h06T3SqNF2woRkFg2d5wj/bqyHni7JrLtVBp74Y3MGm/rnLlGWFrWsGY9WI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WNJqRhap; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=f46l7Pr6; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WNJqRhap"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="f46l7Pr6" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 644Dwcxb3467673 for ; Mon, 4 May 2026 19:08:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=QpEOCCW2frO 5RjDS7yw8Uzvvr6ebtp3PdlAzKWnUJ/s=; b=WNJqRhapNaIGfUkgELB7bB9p/Sn wH5IACswdNeuv7ebxiGWk36eB5G2Ebvb1fl3KZSZXnXIjjij6ZXTLArrDA1f+fqY b9CV2qzT/9a0dVr2dZisqn3y/zx90Ct+9LFEpE8UiY2vZ/53eyNWJOhPqPwu1XYo ooqzIbpD30qd9g8tPgbFUrFjBeeGyrUzmZPpJ5/5kpGckMEADraHB+e36H0k/8hx z2ShEhfAc1aXG6mBggBJ5pb5aLikiCkrJ6KTA//Jtu+/+79OR33KPFRooYcNheeW NrIpOVrOtjLYlOeI/EQVS37JHXgSZvQqQ6PlscG/N/cEVKb0yoplV/DamLQ== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dxvtjs923-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 04 May 2026 19:08:18 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-3651991d0bcso4131504a91.0 for ; Mon, 04 May 2026 12:08:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777921697; x=1778526497; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QpEOCCW2frO5RjDS7yw8Uzvvr6ebtp3PdlAzKWnUJ/s=; b=f46l7Pr6uZ72xNa6q8fbt/ITqCjPFVVKTR2Mw1UM8dVqoAp+60fjIYGMiHHyoAQfm+ 3PNyRH+nUGlDXVHT8GJrmRsPcML+rBl6otkx4p5r5qW+ddhWtELBF59oIBkYDEqCwVKD P7HW+63QW7yOFwjZdLZ8Hs0Bhwq/lPtuoIPE0uLliUyzYN893T+Dpyuu7Wrfg1krBNVY MDiLrOKPBdySVozHmH0ukuvcu7aZLvctInwlimfIJEzrklcXuChKYJ8MUeCYr+Fl4WYK 8wl+bRRbGjrQ33NlZ+retQzD9juqWJRuCBSamgJtb2GkbkUEZM+Wnn0gQsqecpbr5rpl 888w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777921697; x=1778526497; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QpEOCCW2frO5RjDS7yw8Uzvvr6ebtp3PdlAzKWnUJ/s=; b=JgRnMatFKSMfmUN9mFgIMNwKjmi3GPpQ6kyXg5hliout5ojG3xQpkUEpa+zYmBizEZ gBxAfzmDsbe5Rq2xkVy7MqjJcL9CIwZvxW2d5kaQrZRA5kdelhduPkC7FiFM2/i+6lua dQ76OSZoOto/pLVS5mZ7enxOAL0hPrsgLPXTaauR7lrFGpfZa91j9aXIei/EFioKk0en +cSV8esGR63NgOFaiVIFJAXah5DOYDHlXFK0dJzqeSUiyKIdPOqW/e39ERW2i57MIFbR mNe256eL89GU88nfeqcqUdTrZyhxWxnS2DJKrcBcswJ3vJ3q/+POVETEz/Vo2oW+xAIg vUcw== X-Forwarded-Encrypted: i=1; AFNElJ84Qhp7q6YkthZ/s0Y6tZPnsxXMoiBBvKQ4we9X1RLfHm9YLKtLnZJ/Rfr0vyB1kasuHlKAGLOix1OQzL4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6goevlw8qDiA+qremXJA79zFQGydIJukOgOuNXYDWhdOFlbcD RFLqg5iPbKqJiwkRykRl+TOOdKEtxy1rE80J+DcR1ruFhZ7lfDC1h5SAhmZE0tj3uQliuASmeva qWzY1Rhf68Dsgx7fJw+qKW7V0b5qwJQmt0/XncI04RjsgkLRfppgdghzjV4E2zj1hW1s= X-Gm-Gg: AeBDiesW9aPhqnZT6v6VlmnOl4y0K5WlKDSFZB3n4NmFsGdD1wvFJJAiZ0lIOzJJF1t USs91tNvqOLiaYpOf99phmioXx/xkIsA3ia/KpYDEazEJgk34HevKaDSiluB7PINZKxMGJLym2G D1V2dQwPoeoFyhM2o0Ncunp5qNcngHIm6ijafYP72lV6QasMAwJZigZW4CYdDM0T1soyy1jaiYo yE+5PL/T94D7V7FWgyQ2jbJuOCjK0L6YaE2PUq2YrQ0PI3vJV3DKW3x4qlz8CdfgSrUagdL9dCI OgHqichTvIYzOhp9/CYxD43M6anZsg3L1hPIVvDXhKVj3VoBO7jqsFPWAl1YBWDtl5S57KRJiIF rgBC+45V1FpelGVqnM6PjuEzS0fbwS6rcdBEBkIduZec= X-Received: by 2002:a17:90b:44:b0:35d:a90d:580e with SMTP id 98e67ed59e1d1-3650cef4475mr10744334a91.23.1777921697409; Mon, 04 May 2026 12:08:17 -0700 (PDT) X-Received: by 2002:a17:90b:44:b0:35d:a90d:580e with SMTP id 98e67ed59e1d1-3650cef4475mr10744305a91.23.1777921696879; Mon, 04 May 2026 12:08:16 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:4ec8:83f5:8254:6891]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-364f48be507sm4609984a91.14.2026.05.04.12.08.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 12:08:16 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Akhil P Oommen , Rob Clark , Dmitry Baryshkov , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v3 02/16] drm/msm: Allow CAP_PERFMON for setting SYSPROF Date: Mon, 4 May 2026 12:06:45 -0700 Message-ID: <20260504190751.61052-3-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260504190751.61052-1-robin.clark@oss.qualcomm.com> References: <20260504190751.61052-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: nqROJ-MGHf5nj8sSZfv11x2TYNITnyiF X-Authority-Analysis: v=2.4 cv=KuN9H2WN c=1 sm=1 tr=0 ts=69f8eea2 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=xqWC_Br6kY4A:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=ZRXlmS4ShPoOlOK7p90A:9 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA0MDE3NSBTYWx0ZWRfXyMWgdFIYVI07 p+d/vj1FI7aJXFGkoe+I5iV/SXtJiqTDyIkK0BAFm7eY6gBeBRCkaVaHXrA5IVXWFsnyhkSZoQ5 FWZrfteJRNxxz0Kj4ki69IypcssPRhp9Mp+lrZ5qQx/pBTzBr0wHw+M3EO/JnCCImYubtpzjE3p al4OlCUYmelNmuDFKLAXjDX2kRdwNOlkSWImDeoeHsSzwOFu9syJXKhibNUCabjr93ZgE41RCa9 iBl32ImHG9GtIZOf7BmTlxHFePQsPEYjQHu/v1dgtULbaf3qmlTAjAfoYmszWhGxYqyWXiDFOCF HnHu8wSEKbIFMr1AkeoHScHwVQeCk1GekjbH/WbeRpwngkI3Z1s5aP8xooQMdpfPqGcqxwWuLEw aN+LzHP3dpLXrz1ol72WQxmmUZsNv/2jh/5IpKwfF12Q8Cw0vuGtZTKv9RER22Jow3fIqltxQ9m 3JJxvtx97G3ZWPXzORQ== X-Proofpoint-ORIG-GUID: nqROJ-MGHf5nj8sSZfv11x2TYNITnyiF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-04_05,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 adultscore=0 impostorscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605040175 Use perfmon_capable() which checks both CAP_SYS_ADMIN and CAP_PERFMON. This matches what i915 and xe do, and seems more appropriate. Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c index 66f80f2d12f9..72b71e9e44f0 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -494,7 +494,7 @@ int adreno_set_param(struct msm_gpu *gpu, struct msm_context *ctx, return 0; } case MSM_PARAM_SYSPROF: - if (!capable(CAP_SYS_ADMIN)) + if (!perfmon_capable()) return UERR(EPERM, drm, "invalid permissions"); return msm_context_set_sysprof(ctx, gpu, value); case MSM_PARAM_EN_VM_BIND: -- 2.54.0