From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6317533BBA7 for ; Mon, 4 May 2026 21:01:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777928515; cv=none; b=Tg7XMvHrH1/3eZ/jUC6eUiQ1rh33Ztl+as6k3iGuUqw+d8PMpgv0FUGRngz8emMCj0HY8ZPcGmgpzGTzIPdksOl3Tq4/YUl1qig/iYfEDgjc/DKeF1jsP8XZMQWkVqJz1quT62jPPSNzSBJ2Qvdxdm2/Ue7jVbxe5IO1TbHamNM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777928515; c=relaxed/simple; bh=VmSXVD3JTHn924FOX94nzojXXzoLulX3vKK8x1K2ndw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ijlqrf1GcsNOxzCNXJvFuZI0xmGN1mcFh/BFSvMJ+wpry9UYxiSluLdP6mvMMbbvIHoAec8El0XpWx57TGor3w39Ji0o8pwVzemxp9V38Tx4OM9VDd2QANrGxwl8PAycVVwmuohDuopVBDJC769MTCrcE0TyAUmCP9mtTzJD7lA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YW/t7PYu; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YW/t7PYu" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-488a88aeec9so50899805e9.2 for ; Mon, 04 May 2026 14:01:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777928513; x=1778533313; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=8V3EEF5vuXOGGZWzOmCLTd7Ai3hmXK/x8X4/6fRIf9c=; b=YW/t7PYuYEjItA8subcyJiCgehG1/knIeGeZGcuOrEJrnq9zeTLoqyjg5+hMaErAH8 jA5B3imTEVIgDQLhhCeKxza+I/30933e48428NCQXNo8OwuMWzEOkffps03P6okwTe4i lzvmv4QQvZkluZ1WJuLByEH9uIqGgXc4G2qo/CLkiLbGYOfqiy+NgR2P9AojLv3iecM3 fpMwg6oAX+9AJTiOs6Jxx82rsB5zdAwDAoSTlbSB0OmhLDBZhrqdq+Ku2EBGbX0Qt7RR j9mELeJSL0xLWF2vXt/5TKtSJZFMbRxrz43k1zx+dfbR5zqTEplpUL9x0HM2VAGprStA tUgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777928513; x=1778533313; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8V3EEF5vuXOGGZWzOmCLTd7Ai3hmXK/x8X4/6fRIf9c=; b=g+A6QvGe1XWcKJoDw7Q0rbzsoL/BkdZ7UKiEIHqoKu5a0j3ibYk2Vri6HGPOYjVpqi BnSVgfUIJI7CmhmwEPVCWqQanUghwdKEUlCQGOqljTWTkiX9EKWuLz+FM5FZtJ+fmMR6 O8myU8uIbC5KReXpxrczXlYJBGTzEuc+NjAzXvBxpxyOWpiELDEvl4uIXZHcV8n+buYc tD88zcJ9+Qxui6aily6JhV9ZZ836Ch3YvYsgold6lFaAQBXYRgDocAL5r7bAtqXw4Blc BFsPflhYPNb5fjjzkovKif+JeDuISjXgbYHVZxeQclVGqSlJxl/CH40DgmMcjDTMsKzh i90A== X-Forwarded-Encrypted: i=1; AFNElJ/EPj1ed5f33aLig2EVnlc1SVUDdM/Xbf/BBp1U5Hw0tfgTrsOFXrRtNVcJiq0L768tZI+dQlqy45e2HS4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9tPLhiSTEKzM6T0myFkh7VNeHEW+DCg9QYVU1tVuhZL+IvO3d d8OetbttpHNy1c5fx3fgvgEXtl9VhyjNHGCheylKehMpwFrhqjrlvBiY X-Gm-Gg: AeBDievNPsUXCc3+LYD4u9o6WcmJ4T1Bg28BGky0+TscyemoT2IXQaFCn/jIMA3R9b7 /kOHEqGxgxhdTMxeIb6avi3thXYbnpOGIFkMgEhWBbwFpQNoeziPpRVisKSSQPp3mZe6NEv9HXy jMR3VVTAi1yci47vsrSdQbDVzzO61OALj0GKYCzesD5a3BmovmoyGxH+xtJFMCdaMWFKSR119/N CHtxXhMV1PMfiIVjCPYm4B4YGS0bcfRZTNNFzeeuy3RoqrVC45uvXOf9V6zoOZ0SC8PPV2bWX/3 fUEtJDH/+lgvWRxjeY5wqFkkrhmNmKgPPfySkIOvQkDu/0ajfnFWpKTStp2gHA3/DdwzZIe6o4z 5DPUzcOWLj+yyD/i68qRaWAiad/2ktP7GUBzNH8Qbae5cFlCZYdI5D+OvG1E8/G+mlrC4sRGwVO U3AtjzYYPeUHHN0+Cqd2YvImZ34hkLT0yRNm1NIRrfx2PDz9RJzggvLiVnTFuOPfOeGzRnlcMVp gw= X-Received: by 2002:a05:600c:18a5:b0:48d:364:6c54 with SMTP id 5b1f17b1804b1-48d03646d09mr86616225e9.23.1777928512657; Mon, 04 May 2026 14:01:52 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48d184e197asm1027725e9.30.2026.05.04.14.01.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 14:01:52 -0700 (PDT) Date: Mon, 4 May 2026 22:01:50 +0100 From: David Laight To: Andy Shevchenko Cc: Herbert Xu , Lianjie Wang , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Olivia Mackall , Thorsten Blum , Manuel Ebner Subject: Re: [PATCH v1 1/1] hwrng: core - Replace strlcat() with better alternative Message-ID: <20260504220150.5e6ce43e@pumpkin> In-Reply-To: <20260504130259.473382-1-andriy.shevchenko@linux.intel.com> References: <20260504130259.473382-1-andriy.shevchenko@linux.intel.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 4 May 2026 15:02:59 +0200 Andy Shevchenko wrote: > strlcpy() and strlcat() are confusing APIs and the former one already > gone from the kernel. > > In preparation to kill strlcat() replace it with the better alternative. > > Signed-off-by: Andy Shevchenko Reviewed-by: David Laight > --- > drivers/char/hw_random/core.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c > index aba92d777f72..c789699bd773 100644 > --- a/drivers/char/hw_random/core.c > +++ b/drivers/char/hw_random/core.c > @@ -418,21 +418,21 @@ static ssize_t rng_available_show(struct device *dev, > struct device_attribute *attr, > char *buf) > { > + int len = 0; > int err; > struct hwrng *rng; > > err = mutex_lock_interruptible(&rng_mutex); > if (err) > return -ERESTARTSYS; > - buf[0] = '\0'; > - list_for_each_entry(rng, &rng_list, list) { > - strlcat(buf, rng->name, PAGE_SIZE); > - strlcat(buf, " ", PAGE_SIZE); > - } > - strlcat(buf, "none\n", PAGE_SIZE); > + > + list_for_each_entry(rng, &rng_list, list) > + len += sysfs_emit_at(buf, len, "%s ", rng->name); > + len += sysfs_emit_at(buf, len, "none\n"); > + > mutex_unlock(&rng_mutex); > > - return strlen(buf); > + return len; > } > > static ssize_t rng_selected_show(struct device *dev,