From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C9213803D4 for ; Mon, 4 May 2026 22:19:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777933173; cv=none; b=JI9+/sMF0xnYRnO2OsiGfyC1nm3IhF7LboOkqfLxH1j5Q6ZbZMkLxxxrZXuli49Ie8UnE6VDxxdCT3qACsa/SOEr8eHCbaOSsEofNjLg94Nk4URuSL3dZ2KkTsRlI5YM4vG5Q72pO6bUq3kJq6FJvQrhuLxO4rOgLUD6UebEkoM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777933173; c=relaxed/simple; bh=ztdrt9vzdAq7Eb3jA8QSH/Kuq6wH7FHBH/eCinh7P78=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=txOeATZwwpdhjnSXoKK9ib4f5OyeOPbp3cGuVZ8Iz2CFN2VX1e+eR1d0nXU6jPdm6Rw4yvS48zQf5aWCWBJKlWOse3AQtGDtHdy9YoSdXRnhl3I2Ac1rte430JXq7ztXaoKzecMNkm3mdmzBjtbFcJzW+V8TRuHBpwUa0XseiOw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WZ0sQ5KN; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WZ0sQ5KN" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-48984d29fe3so66929855e9.0 for ; Mon, 04 May 2026 15:19:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777933168; x=1778537968; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KI2VHwPQhpEIeLDiMOieSMNQDxnxTzAkBbt4N2Gn7vk=; b=WZ0sQ5KNwc9UKb87PbRpwUbhzHCinR220WgIiug2lm5Bi43pCTBtxHXdBQsO4So5v9 6k1JykPH3zptZbL8xYFjIFYoaUOC34LyYGg9RGPusyw+nzwyNv5p/WLRLlft9sPWeLuN PY05vc8/7VKF/tzXexpNum/VRNtOaCRAmbBiM82Bqn4l0FrBc+2NIj7OG6Un5kL1yAnU aPpmAx7LYaUlTLyyqH62NjJVi7wZIUFk+WVfPLIKCaz64XBC+n9NCNGwPKwz3BzuRa39 SZydJIGuQNk7m1SfgSlsoECv3b2V+OYzxlw1NU9fk2Ab77rq1UuvCiMrdg0fA/q8hBZ6 AZAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777933168; x=1778537968; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KI2VHwPQhpEIeLDiMOieSMNQDxnxTzAkBbt4N2Gn7vk=; b=OFIS9916YOPd/F/ruJhMKfp/sFxQBFkDnFZL7YzZmPH+AIcqDa4OKZeUuSYDJaFR0o 75xBTWQDEzrPFrt2+k1d/qAoy2G1cgCDv26aqaistXxvDXHW4ZbknS18gZX3U3GG4STO Df+CHAaj5UUyQ5k2OixS+TH3na2kR1xZHZ6RFHD59Fd9o/tFI6IDHiowA+OnPStLg1tP L03b11Yatq9PylU98j630EhLU92zaOtyuAzcrSCsoSrK2sS6wwjduI2xSWC7GMaei2m4 IJQVu61bhsOsZnsS2lcf8ItizsFarBHSkjG77zp/is9oTqqMuUNjagilQDksnK9zgvBL BKKg== X-Forwarded-Encrypted: i=1; AFNElJ8o7hd1ZKmzS1zn4LW490zDISg/kEpDMSr2PRhq8c7ccSHl+Q+tA4Q9nWzOgDnpACqbs0MJG+8qig51e7s=@vger.kernel.org X-Gm-Message-State: AOJu0YzwiInBHa7/7Az0YHEqPjpPEWfs2rbs0RqlrRBYo8pXU6WAy6Vy Blcg1l4tktAC56gNNkFoanXSov8tsuRny4W1yh6QzBDrPSDA1e3hBfw18sMLugRd X-Gm-Gg: AeBDieuXC5g/2eFM3WhnZX/7Y09CJN+gxZswNsfexDhZFEHSetRIJksNmSXEq+QHc6+ 1g6DAiUqpqiC52MJNKuVPkZm0IFtF1PedvdQ+1wgKVAWM4E/lhrJTfPSOhM5o1pLSmQEEqnoLkF Ahnwzl0bhuopxQS6zX89y6ccQ8ylrOelgWdqaCbsnDro/drhMx7wF+URVvwQnOiIxudmUyX4lK8 eIAAv/yvi5aDQk9A9OXgc3K3L6Bvz926menQCpltkvXdTfsAKTyy0AjqQWY2n5OTK2Be7+tXLTu aAa490jLceZir3NbAa4ENhbHe8Ud/SKOULh9hzImhlDGTQn/rEzXp+tlbcCEVXpEZvurd+VZkcs 38vOticSlxgU9LeUY3m+vv/Tp8yPgoCf2vz85L/qUNUfLXrZ7ppb0ClWXfMxcNG3UAzPEx5Phdu cU7NaU7mxRGSyCB3cRWiD2Ye30ODGNNhT7bgxMyYzatRCfsq8cJ48bA3oeZdfG2ZT8vUdM4zX/2 MJBttmBWln3idWa4i72ObAA+j6T65n4QrwCr7GY2g== X-Received: by 2002:a05:600c:4f05:b0:488:c683:be89 with SMTP id 5b1f17b1804b1-48d188dcc95mr6010225e9.9.1777933168454; Mon, 04 May 2026 15:19:28 -0700 (PDT) Received: from SD.localdomain (heme-13-b2-v4wan-167795-cust403.vm32.cable.virginm.net. [81.108.45.148]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a8ebc4201sm484802335e9.15.2026.05.04.15.19.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 15:19:27 -0700 (PDT) From: Prathamesh Deshpande To: Saeed Mahameed , Leon Romanovsky Cc: Moshe Shemesh , Mark Bloch , Tariq Toukan , Yevgeny Kliteynik , Jakub Kicinski , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Prathamesh Deshpande Subject: [PATCH net v1] net/mlx5: Fix HWS L2-to-L3 tunnel reformat release Date: Mon, 4 May 2026 23:19:17 +0100 Message-ID: <20260504221920.48685-1-prathameshdeshpande7@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit mlx5_cmd_hws_packet_reformat_alloc() allocates MLX5_REFORMAT_TYPE_L2_TO_L3_TUNNEL objects from el2tol3tnl_pools with MLX5HWS_ACTION_TYP_REFORMAT_L2_TO_TNL_L3. The deallocation path uses el2tol2tnl_pools with MLX5HWS_ACTION_TYP_REFORMAT_L2_TO_TNL_L2 instead. This releases the packet-reformat entry through the wrong pool, corrupting pool accounting and potentially moving the bulk entry onto the wrong pool list. Use the matching L2-to-L3 tunnel pool and action type when releasing the object. Fixes: aecd9d1020e3 ("net/mlx5: fs, add HWS packet reformat API function") Signed-off-by: Prathamesh Deshpande --- drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c index aca77853abb8..60fbb048db10 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c @@ -1396,8 +1396,8 @@ static void mlx5_cmd_hws_packet_reformat_dealloc(struct mlx5_flow_root_namespace pr_data->data_size); break; case MLX5_REFORMAT_TYPE_L2_TO_L3_TUNNEL: - pr_pool = mlx5_fs_get_pr_encap_pool(dev, &hws_pool->el2tol2tnl_pools, - MLX5HWS_ACTION_TYP_REFORMAT_L2_TO_TNL_L2, + pr_pool = mlx5_fs_get_pr_encap_pool(dev, &hws_pool->el2tol3tnl_pools, + MLX5HWS_ACTION_TYP_REFORMAT_L2_TO_TNL_L3, pr_data->data_size); break; case MLX5_REFORMAT_TYPE_L3_TUNNEL_TO_L2: -- 2.43.0