From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E1A8386574 for ; Mon, 4 May 2026 22:30:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777933826; cv=none; b=V68TAx49v1XtUYHbbU5R2c+sa79PLONQG9BM+gnVcU3IiXontPKYPK6zKPOsJ5+habLqcGLn3Q5oAcfm/rrJP3SgLlXrUEIhLIDzN4IZz5tdh6MYdkrG+EtzDgfkf8yF/owlETcmpJ7eRUihMfZs4RvDPr0kc8yMuNqL3O4lX0c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777933826; c=relaxed/simple; bh=cOYBuqi/VNzz2C0cy5p2PKu3wLi5vzljAJiS8TAEd2I=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BwjkHma+IThCYDt9JR8+ZVgT8eB+GlkB8He7aFuQBcTpmrIsbuI1cGKsKgDlYnpFcOcnjQ+0bt/h5HGQx+h/8MFkqcK/Pys5w2DhRmuNzSILEZXAyXM9oExewjiDrAfIN+1rDtUHqY5T1hO7owcY5eBOo889C0ANsg+AARVC5L8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sx4q/bGW; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sx4q/bGW" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-48374014a77so53387275e9.3 for ; Mon, 04 May 2026 15:30:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777933822; x=1778538622; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=T8YNj/CzrqnJauyF8qzb/2yp6o5yAPhiMcAgKOfOpJ0=; b=sx4q/bGWbYMbJ84fbGEaB0LNIP524Azl/87gJ29wgq50Uszj0PmamYNc2+vc/Czw/9 IOcpyXRjuDLOtM1RSi4WO4ceCVY24boni+owH+nRISQ1o/gyqCJZWeByotq5wxmzqTnq kP46+n6MtMrBDIj+3zToCNbtWnQ1JM/QeIhrr89b/9pNPn0HDuRaEIDBJVwYDUm+BASr ckpW0pKAb08/ZzfL5RmhRHiTrGB8gvPX6XkfKou4h3SmRQAyHBvhXX8AIvxUNfkdhUCu dl29fI7MqllHZf7GPTAMU23yo3lpMlPs+9z4PcZfANbrinKJd8KwSnZapWGV1OADBmLP hOnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777933822; x=1778538622; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T8YNj/CzrqnJauyF8qzb/2yp6o5yAPhiMcAgKOfOpJ0=; b=RTZsHRp0EHfMw88i+EkakfcFIH56TyeNsphTXs4KrNyjaYdK6dChkaf8JBh4Ey7SxJ /vi5Wd80QWgHMKZFrXSekwNOiH8XtQvi9zFsOAESsiqWDFi5yQVgvPT/bIT/T8JgbGFc Gj2dCak7puU/mD0EPeaDW8BOVEKDs43DkFCfu11YhVjINenALiBxWIjeRymjreR792p/ KxLELsMmoq/Ol1/PmdHNvWLJOtN0end1Wp/dLPgQU+lP3yE4PpTTSfpWtErOC2rHg406 YjDJoaIHjSgUYvklMaL2tcgqP3c4w0haRy+boMuXIaSYN0koBCaa+SqMTj8zM3L60u87 tzYA== X-Forwarded-Encrypted: i=1; AFNElJ+IHiaieOoVamc535rhIiEzAIyqon7PMUFtUK4hhD1L5SEzkx4ALJCRg8av/Cg3iMKuzmsUYBrG+xfHGrw=@vger.kernel.org X-Gm-Message-State: AOJu0YzHZSXS8MSFqQ4abP0bYDvDusW9ngfo9bDCLjdVnZ44q1drwjnN dF+/dc7cMuVjHOqIk+CjGcbI10YZHz8b6IaoQoF8hpVan6vVHk+rVKAY X-Gm-Gg: AeBDiet/2PuU5o0LGW0LD5LSP1xbR7cULcytdu+oiMjVGdoCn/ZuV6+rEqt6AXOoccw /b2+O4nzgdz3kcyQPl/tmn4CBjZvOoaViJQbMdqh/ih+33BLCUNNkJEGvyvYzM1o/Y6wf0kGnad gKwhMdLfjdCZFNaVlchYNT0NlCu3HRdvrONvQEzwS8prSCZe2XsYMWa8BHmJc2cHJsMDtKvLk29 CeR6kXg5V6GqJCcnFpPCwPVx1o0ukVzj8gz8rmqmScYtPH0MGKDh4c8eRNWoAIxL9k/1jwN5gr7 nY3rfCDJ5r2EISXVrK12NdzBxGYzezVI6q+zNmUq/fdVfzi9EA+OG3v3vibPRVAtxCqSf6nWTUl cxL4BMp/prcn8CVbZdzl0THx4aAGNfrQ2lTUgs2FTohwnqFwAcONSnHif6S6Prsw48kvPfqx8t4 p/ZsBRFp22dO257k0xpkFVsnAvxZ1VPch/Qfut6mYaRQgFXFDN1nb9EjeWsGLrYaiHl88B4WHE6 /WcfqqEvXVbIeprhsnudzEYFPcAuMHYHZoGwv25oQ== X-Received: by 2002:a05:600c:444c:b0:488:7ff6:1f75 with SMTP id 5b1f17b1804b1-48a9866aa1amr196231205e9.21.1777933822449; Mon, 04 May 2026 15:30:22 -0700 (PDT) Received: from SD.localdomain (heme-13-b2-v4wan-167795-cust403.vm32.cable.virginm.net. [81.108.45.148]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a8eb72a17sm319020415e9.6.2026.05.04.15.30.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 15:30:21 -0700 (PDT) From: Prathamesh Deshpande To: Saeed Mahameed , Leon Romanovsky Cc: Richard Cochran , Tariq Toukan , Eran Ben Elisha , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Prathamesh Deshpande Subject: [PATCH net v1] net/mlx5e: Fix PTP TX SQ cleanup on metadata DB failure Date: Mon, 4 May 2026 23:30:05 +0100 Message-ID: <20260504223018.49556-1-prathameshdeshpande7@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit mlx5e_ptp_open_txqsq() creates the hardware SQ before allocating the PTP traffic metadata database. If mlx5e_ptp_alloc_traffic_db() fails, the error path frees the software TX queue state but skips destroying the already-created hardware SQ. Add a dedicated unwind label that destroys the SQ before freeing the TXQ state. Fixes: 1880bc4e4a96 ("net/mlx5e: Add TX port timestamp support") Signed-off-by: Prathamesh Deshpande --- drivers/net/ethernet/mellanox/mlx5/core/en/ptp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/ptp.c b/drivers/net/ethernet/mellanox/mlx5/core/en/ptp.c index 723f66a6bd63..45db2dd7408d 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/ptp.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/ptp.c @@ -489,12 +489,14 @@ static int mlx5e_ptp_open_txqsq(struct mlx5e_ptp *c, u32 tisn, err = mlx5e_ptp_alloc_traffic_db(ptpsq, dev_to_node(mlx5_core_dma_dev(c->mdev))); if (err) - goto err_free_txqsq; + goto err_destroy_sq; INIT_WORK(&ptpsq->report_unhealthy_work, mlx5e_ptpsq_unhealthy_work); return 0; +err_destroy_sq: + mlx5e_ptp_destroy_sq(c->mdev, txqsq->sqn); err_free_txqsq: mlx5e_free_txqsq(txqsq); -- 2.43.0