From: Greg KH <gregkh@linuxfoundation.org>
To: Seonbin Yoon <seonbin.yoon0@gmail.com>
Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: Fix CamelCase variable name pHT_info_ie
Date: Mon, 4 May 2026 16:47:51 +0200 [thread overview]
Message-ID: <2026050446-catty-amenity-c1c1@gregkh> (raw)
In-Reply-To: <20260427111022.37282-1-seonbin.yoon0@gmail.com>
On Mon, Apr 27, 2026 at 08:10:22PM +0900, Seonbin Yoon wrote:
> Rename variable pHT_info_ie to ht_info_ie to comply with
> kernel coding style (snake_case) and remove the unnecessary
> pointer prefix.
>
> Fixes the following checkpatch warning:
> CHECK: Avoid CamelCase: <pHT_info_ie>
>
> Signed-off-by: Seonbin Yoon <seonbin.yoon0@gmail.com>
> ---
> v2: Remove the 'p_' prefix from the variable name as suggested by Dan Carpenter.
> ---
> drivers/staging/rtl8723bs/core/rtw_ap.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
> index 4b4012411011..36af7d07269b 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
> @@ -798,7 +798,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len)
> int ret = _SUCCESS;
> u8 *p;
> u8 *ht_caps_ie = NULL;
> - u8 *pHT_info_ie = NULL;
> + u8 *ht_info_ie = NULL;
> struct sta_info *psta = NULL;
> u16 cap, ht_cap = false;
> uint ie_len = 0;
> @@ -1054,7 +1054,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len)
> &ie_len,
> (pbss_network->ie_length - _BEACON_IE_OFFSET_));
> if (p && ie_len > 0)
> - pHT_info_ie = p;
> + ht_info_ie = p;
>
> switch (network_type) {
> case WIRELESS_11B:
> @@ -1091,7 +1091,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len)
>
> HT_caps_handler(padapter, (struct ndis_80211_var_ie *)ht_caps_ie);
>
> - HT_info_handler(padapter, (struct ndis_80211_var_ie *)pHT_info_ie);
> + HT_info_handler(padapter, (struct ndis_80211_var_ie *)ht_info_ie);
> }
>
> pbss_network->length =
> --
> 2.53.0
>
>
Does not apply to my tree :(
prev parent reply other threads:[~2026-05-04 14:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 9:18 [PATCH] staging: rtl8723bs: Fix CamelCase variable name pHT_info_ie Seonbin Yoon
2026-04-27 9:52 ` Dan Carpenter
2026-04-27 11:10 ` [PATCH v2] " Seonbin Yoon
2026-05-04 14:47 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026050446-catty-amenity-c1c1@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=seonbin.yoon0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox