From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C20CE3A63F2; Tue, 5 May 2026 11:46:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777981562; cv=none; b=c5cxwlsYX/u0PcxrigPxZGgai1pTaX1Pp+6SJdp+IekLsyuKLXRMZAoz10LkoXiWnaIZYrZPkMjsaPMeBcuDOMHPF9n/DSFTXA/SSB59csYWRQzBNqkvCks6wIyrEfwjuf+/q3nIlmCnD3WD8DDTFjVqMKvq5OkHGN0RVp9oqFU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777981562; c=relaxed/simple; bh=XuxK1om5igY73A5db3176rapoJfEk9AM5Vw3ShphxAI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oks2INdsxpbFABy6Gest6POGzTDJjhU9aSR0Vv0Qv/3ZBiVnLXpQ0kS3C8b2jTT1CYXrLD9E9WNtBXr/POPIUT6uHY5vbNau5wIm2spRNnPfK3vm9H4/26uX29m0jNl73eacOOIvSRnUkcldX2hXqzCM6EJMqh1uCkndqdAmZpA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=u6L7z8i6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="u6L7z8i6" Received: by smtp.kernel.org (Postfix) with ESMTPS id 944C3C4AF0F; Tue, 5 May 2026 11:46:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777981562; bh=XuxK1om5igY73A5db3176rapoJfEk9AM5Vw3ShphxAI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=u6L7z8i66pH7Die5IVwRtDgNBvZo3Kji8Rerred01PPNOxCiyzauSRcO4R3G12JxN +ZDAqUSASB8Kcv2/rmObA6tK+jqPj/HJo2FVRAYh5Ztn52DaTXYrRj6PscH+Drh+6B svHd2kbrCk41h8zJDMgLRwpliA4YtMsZ7XSscSFifEx3jxru7ut73hB8FXwjxpgc31 SSVk01wqD9CP+6R3BqZDOkEwuO086y0EFNqMY1UiUXw82kFujTaP1TV/9D0RlHFdHy uXDvCyOoX1rPQhNrGi8G87OLWQ8GZxQK5FcvTyjt9QKQk9suJunPu+V1lyxVzKxOsS fx/w4IEl7shjg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BC4CCD343C; Tue, 5 May 2026 11:46:02 +0000 (UTC) From: Joshua Crofts via B4 Relay Date: Tue, 05 May 2026 13:46:11 +0200 Subject: [PATCH v5 15/18] iio: magnetometer: ak8975: consistently use 'data' parameter Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260505-magnetometer-fixes-v5-15-831b9b5550fc@gmail.com> References: <20260505-magnetometer-fixes-v5-0-831b9b5550fc@gmail.com> In-Reply-To: <20260505-magnetometer-fixes-v5-0-831b9b5550fc@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts , Andy Shevchenko X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777981558; l=2222; i=joshua.crofts1@gmail.com; s=20260422; h=from:subject:message-id; bh=umiM7hdXq27k5Ls/2JriqoMfYhs0WQ5fuFisplUXSUk=; b=pViVm2bgoTcd5BujlnxkRjcjkw3jbyboSsEk3PwDlDpSOaJEWcE5AQfiu9JePWFiGg5bg76SF Va1v8PodAjMCoN3avupeLxHuUOdJ8RF3ZzywdXv/GR7vaydBAk1yuDN X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=Xd+UVoRPiiI0K3LHQ2XIcXmO0jvVuFTv9eTx3lgBphI= X-Endpoint-Received: by B4 Relay for joshua.crofts1@gmail.com/20260422 with auth_id=746 X-Original-From: Joshua Crofts Reply-To: joshua.crofts1@gmail.com From: Andy Shevchenko Some of the functions use 'client', some use 'data', and some use both. Refactor the driver to consistently use 'data' in all cases. Signed-off-by: Andy Shevchenko Signed-off-by: Joshua Crofts --- drivers/iio/magnetometer/ak8975.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c index 84ccbca758b0121a9c4930a368cb113471d389da..d40ce26e3a47d5a5c9c81d49c128d136208a343a 100644 --- a/drivers/iio/magnetometer/ak8975.c +++ b/drivers/iio/magnetometer/ak8975.c @@ -474,9 +474,10 @@ static void ak8975_power_off(const struct ak8975_data *data) * Return 0 if the i2c device is the one we expect. * return a negative error number otherwise */ -static int ak8975_who_i_am(struct i2c_client *client, +static int ak8975_who_i_am(const struct ak8975_data *data, enum asahi_compass_chipset type) { + struct i2c_client *client = data->client; u8 wia_val[2]; int ret; @@ -598,10 +599,9 @@ static int ak8975_setup_irq(struct ak8975_data *data) * Perform some start-of-day setup, including reading the asa calibration * values and caching them. */ -static int ak8975_setup(struct i2c_client *client) +static int ak8975_setup(struct ak8975_data *data) { - struct iio_dev *indio_dev = i2c_get_clientdata(client); - struct ak8975_data *data = iio_priv(indio_dev); + struct i2c_client *client = data->client; int ret; /* Write the fused rom access mode. */ @@ -999,7 +999,7 @@ static int ak8975_probe(struct i2c_client *client) if (ret) return ret; - ret = ak8975_who_i_am(client, data->def->type); + ret = ak8975_who_i_am(data, data->def->type); if (ret) { dev_err(&client->dev, "Unexpected device\n"); return ret; @@ -1007,7 +1007,7 @@ static int ak8975_probe(struct i2c_client *client) dev_dbg(&client->dev, "Asahi compass chip %s\n", name); /* Perform some basic start-of-day setup of the device. */ - ret = ak8975_setup(client); + ret = ak8975_setup(data); if (ret) { dev_err(&client->dev, "%s initialization fails\n", name); return ret; -- 2.47.3