From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f54.google.com (mail-oo1-f54.google.com [209.85.161.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF01A2FD681 for ; Tue, 5 May 2026 10:42:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777977749; cv=none; b=hEHNckJjt9agXsits1xmu2nFf0V67YqT17G22Wut/w/LKBzhOvCrx2w1rU7MT8XKqZJbE76m4WWZ16lcmu8n62AdtH97YyGGe7zdVV4oXOWFUn0WoxThUgH0IGpr92D60t3d01+YMCZ+FbwWaQlU5GluNczrhCiQOnmxD/8IR4E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777977749; c=relaxed/simple; bh=hrwnQjibpj+Gvrxg7H38spBNIlmQIG6bHPm0PcK5eRw=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=Eo4ybC+b1I/GkJfgKegd2lwlrJl79z4MlF1DyHTmFYt/IX1P5xDVp5RzF54Nv48CWda+8pArYhLvsUo040K5dqSXHgvE3Po31y0q206zmv4j9+zttXPkFKBuclfPxUU/2PKW4poe3F9JAZp1VkhtRyNVuiLZwR5uSBvgTysHT68= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LL7KwgJi; arc=none smtp.client-ip=209.85.161.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LL7KwgJi" Received: by mail-oo1-f54.google.com with SMTP id 006d021491bc7-6949192b843so1772513eaf.1 for ; Tue, 05 May 2026 03:42:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777977747; x=1778582547; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=Ap9MrTI17gF1EQQMix+Pb5fYRN3jWL2MaECpfpplGfQ=; b=LL7KwgJi9RCRCJsNIOZ+QtzekBPzQFVTNuNGDRWAK0d16tF7dnjaASOEbqvINN95Y+ 0iwtExarladUPj8adgeGYFnH5Q4VnH0k84o3ltYwkzql9yJpdOXunHrjKPrK3dVPaadG jg/B/pFYUIJUvWcfA39nZkbfj7PODAre7G02Fh8iN2tMSm1JAIwv+pWTsiIbsro3hYEX UdVFPxXxokIu9LNAkCuMeTCQk0QbUlBrWyQLwAQwZfVb+5ig7aXRPc9Qw5iRxcl52Tce Qy/suWIKgOpfiny9m04gC0CKKeom1FV/6nG4icP3s78K9lss8rxiDqSNIFpN6ciqxI0x /XMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777977747; x=1778582547; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ap9MrTI17gF1EQQMix+Pb5fYRN3jWL2MaECpfpplGfQ=; b=s5sZKiaGDqaHelTU6No+siz3sVxOe+pmzC+D+qwXFwqlxYaNrt/+1JdrPB7I7pnsAy XHkSglhD4XSsAV0uLKQXPjXM1U//Xm8X6ICyutXIYYTRESaXczthT3Y6GnmQSvtRtxul HjX8ui6Rc0HssuSQpuQgEIKRv09fkajQDhoXs48p3SRDuUIJe1rtfE6e+nkyjDvZ5Keb HyfEKSNc2V6D7R13coRwDoVPg1X/hA+1RxWebOzEP+tsdekgdpa7ajR8Fve3JqmARgFb nINWI0a+k4eH8ny8HG6NM8bSqUmUZXiAoyGG6BjnWsCuh3qyl/iMabuZWiujmbp4Xrx7 2ZUw== X-Forwarded-Encrypted: i=1; AFNElJ8jEMTfT+cMxrLuULU13nwWOlv5v0tGD8sxnC59WRlPCXrUBa1vUvhlx4OQMaeEeXQqgjbSRBTimUuYSL0=@vger.kernel.org X-Gm-Message-State: AOJu0YwGMdkvyc6zpdiIMMWrJmmUsGHkUljHRi8XG346D9H8ftukH8T9 9RZMYydcVKz1XZgDAadclaZQ6xrWwKyRMIj5FgYbw0zf9Ym4Se87e6sy X-Gm-Gg: AeBDieuNB6Ho+HhBMwNemSL46SYMrxDyY9TEwhdtZ8dvglGS0aW3SMei7Bmw0Pd9vKS PwtTXrIuliablkq4MkmZ4sHLmxZHJJfeByNwTnvIO7UYia044vlzAECSXtCxtNUpMFz62NM58yL co03+BZZHBtnJT8eAtLaAlLJJpLjYiweure67sXdJRxVXzxOzUVU23/m0bUKIeYks/zWTscbCl5 Ohhdj99flcwhz+qLdlWJHQ4lDWGXj1/aCWioDLTUanx7Na68yxm4COG7dWszXNy1TPqWDd6FEo9 2Cnp2ZXghnErD2bm+ULLM544+i/vFdpU23J1R6cMP0DEF9EQXHTnRmSRZ0K+mMlRDx1LnWbnCAm rxQG2UigfKj0cFNG5U3IWskTRcNKP2+aJg1+P/9ANeUEV/oYhHIfE9Nnwi00v6BFm1AvWpiS8Bg uOqTRImiF6zlrywTkOqzrI4eYxoC0MsW8WAWlA54F3rQvM+hN0Ohpm6tZP0FJtoQ== X-Received: by 2002:a05:6820:20c:b0:685:ecd2:40e9 with SMTP id 006d021491bc7-69697e1b6a2mr6917324eaf.59.1777977746667; Tue, 05 May 2026 03:42:26 -0700 (PDT) Received: from localhost ([2a03:2880:10ff:5::]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-69689479359sm8233497eaf.7.2026.05.05.03.42.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 03:42:25 -0700 (PDT) From: Daniel Zahka Subject: [PATCH net 0/3] netdevsim: psp: fix init and uninit bugs Date: Tue, 05 May 2026 03:42:22 -0700 Message-Id: <20260505-psd-rcu-v1-0-a8f69ec1ab96@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAI7J+WkC/x3MQQqAIBRF0a3EHyeoWERbiQair/oTE60IxL0nD Q9cbqGMxMg0d4USHs58hgbVd+QOG3YI9s2kpR7lII2I2YvkbmFh9QQJ7ZShVseEjd//tFDARWu tH//gDQJeAAAA To: Jakub Kicinski , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , Willem de Bruijn Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.13.0 This series has three fixes. The first is a straightforward NULL pointer dereference that is reachable by creating and destroying some vfs on a kernel with INET_PSP enabled. The last two patches deal with nsim_psp_rereg_write(), which is a debugfs handler that reregisters netdevsim's psp_dev without aquiescing and disabling tx/rx processing. This was added to enable some tests in psp.py where a psp device is unregistered while it still referenced by tcp socket state. There are two issues with this code: 1. Calls to nsim_psp_uninit() are not properly serialized 2. netdevsim's psp_dev refcount can be released while nsim_do_psp() is reading from it. Signed-off-by: Daniel Zahka --- Daniel Zahka (3): netdevsim: psp: only call nsim_psp_uninit() on PFs netdevsim: psp: serialize calls to nsim_psp_uninit() netdevsim: psp: rcu protect psp_dev reference drivers/net/netdevsim/netdev.c | 3 +- drivers/net/netdevsim/netdevsim.h | 4 ++- drivers/net/netdevsim/psp.c | 65 +++++++++++++++++++++++++++------------ 3 files changed, 51 insertions(+), 21 deletions(-) --- base-commit: 07d99587396024932e02474c3a5bede71d108454 change-id: 20260504-psd-rcu-aea28e0e2c14 Best regards, -- Daniel Zahka