From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5BE8406276 for ; Tue, 5 May 2026 10:42:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777977751; cv=none; b=PvUMSLd12R5bEiQvSUyIu3nqV2uN92TZ6DVajLFXP4+BFlpf2NgHz2HViYRjplONXCLkW+OdlpbqjkwcuZ9Y9+tbIEQ8lXu9xO7obvqvhj1pDDwjluZYZswR1a6aIx9FuFj/UaMiTtix6bnYUnjY9bdj5n2Lh19hNjEJA3+Ysto= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777977751; c=relaxed/simple; bh=YhZwMUTRyWyfrMMn0VOaBy9tmw60nL85T+/PZnWnELM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gxUClDGt/yHJWc3PlMZsekQOiNzcUMcAk7knIYBsrAXH6ZeNjxyX0OgEhRYo7WXU68y6dCTuUOAE1wsCW5imeiVvUja5RSDP8/pJci427Ewj4Y+KolhygJnqK6dMcnpPo3MnBivLM2k84Jl4CKZtUmCSzJyXPUWet6U7CMHQ30s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mNfz4V1a; arc=none smtp.client-ip=209.85.210.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mNfz4V1a" Received: by mail-ot1-f52.google.com with SMTP id 46e09a7af769-7de7c57b52cso4331109a34.3 for ; Tue, 05 May 2026 03:42:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777977748; x=1778582548; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=bEctwiaijkDd1U8s8JRDXgY/saaQUbwV6xXhN/X+GFE=; b=mNfz4V1abHYFWnV3lRnsHz55KiRyL7IlkoKrZnGGT2T5QHNFgTsahIJgGuBoMyENE0 WU84FymeAHfmam7YZz3L6o7bHR2hK1f0ADBBfwMVu93No8Ql/RkBCAXU2NlmFHhoOIBK U7SibIomCy0ImJjbuyRnS2jIY48cFqooSYiwA1iJwMs73KdAqlgPwQFoOU3kN1043DBb U51Bs49tNzThQpZE0N3r2oAkersDV2jywW/IYENxE+erJd6VnOeOj5H76RKzLQ8RraqJ s6aM4aak5I/LVxINi4EEBaYkZtft8nOTyRp0DcGh1kBtpkWHFrwvY2LmM3i0QbByhXL/ dU7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777977748; x=1778582548; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=bEctwiaijkDd1U8s8JRDXgY/saaQUbwV6xXhN/X+GFE=; b=TrhM/I29zobTTmSy/+/2Erhc/RWivEXF05vIlEQs87IXiADKAZWVXBEx82rBnVZr0K Cd/0In9M3KKuBFRqBxQ3P5UQwodmzW+3l8ncYfjO0PHKkAGZERStzwl6vgIyCtmmNDzj TjdBq055oc4iXVdOxMdV1pulCHECwl4Hse6o+05DCPIfMV61NUcVC1Oa5T3SiAaRGwnG Yg5JXU/dknh2bXTvkf5heD1T/larlCNlDBKbvpQFyyi6a7sOvWktzK1LI+NbIBJ4wXbJ bXNCQdpd8Bm8nYCMK8GkXVNvRztuusdFSWYuqjF3rR9C1BTkeYvIexU2a9cXU/k1EFWs FkVQ== X-Forwarded-Encrypted: i=1; AFNElJ8Cal1VQBnkOUr1BKAqd86QxnsOR41BdD4/FaKYpKGZGhO8A6IIsVM3kkwtECfN/5dEb3Uhw35P3EKMpac=@vger.kernel.org X-Gm-Message-State: AOJu0YzHjpWcuae+BDk7kgOaE01fP8+vtfMi/GMR6oo0vnM0euuPK9BR r6225r7tIYRE5trnpf/lCBkvDAypUV17nM/AEqDb6Fl4Hbl7M2Qp6qlE X-Gm-Gg: AeBDieuc6i31w13xVvDDzl+amL7DFA4tevhfmY3cMbO2AAr+htDBkV4O/IWDDnbdA9U 8oEk6P+L7RDa/Gt5sL8ZMcoMtwyoN9MwV8knx9oXAjlYfW1rbHxA3gaLWiCQxWmlyNiQQgjAXwt VHYFwTOQIuxxMf0QOmZcTvKU9Gk5hatFYltrOIFpVxw6dWHJg7cjDOdjtbVo6ZATQtyL+aIIZm8 jgEIyH5MJXxm0e5wYLVMmsWFNHreU3BUaIVCgFPzyrC66kzY9uXRUmKCO3FXXEcbkwzrSvnXd1P 9EN5yo07lBX9142mUQ2ccfQAIZqIx06Xs3hbBijVF5mhwGP+6/8QxrMEBiX8i700zI6CcTfjj7t aonVSkGbAoXYWhgNNXbRhLoysMjTiJFflPzFEPd1tg3C8IApS5hNCGppJXrBM61hPLu3ko4ANci ohdxNg9X3qjHiixGE/v4OjrNQupf2IyWrn+wQSZdJRcuxanwkfAoigitobKro3CiO7014PalTdc Q== X-Received: by 2002:a05:6830:67c5:b0:7de:a2cc:9da2 with SMTP id 46e09a7af769-7dee13a4e13mr7989212a34.15.1777977748655; Tue, 05 May 2026 03:42:28 -0700 (PDT) Received: from localhost ([2a03:2880:10ff:70::]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7decac26330sm9525858a34.13.2026.05.05.03.42.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 03:42:27 -0700 (PDT) From: Daniel Zahka Date: Tue, 05 May 2026 03:42:23 -0700 Subject: [PATCH net 1/3] netdevsim: psp: only call nsim_psp_uninit() on PFs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260505-psd-rcu-v1-1-a8f69ec1ab96@gmail.com> References: <20260505-psd-rcu-v1-0-a8f69ec1ab96@gmail.com> In-Reply-To: <20260505-psd-rcu-v1-0-a8f69ec1ab96@gmail.com> To: Jakub Kicinski , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , Willem de Bruijn Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.13.0 VFs go through nsim_init_netdevsim_vf() which never calls nsim_psp_init(), so ns->psp.dev stays NULL. nsim_psp_uninit() guards with !IS_ERR(ns->psp.dev), so destroying a VF reaches psp_dev_unregister(NULL) and dereferences NULL on the first mutex_lock(&psd->lock): BUG: kernel NULL pointer dereference, address: 0000000000000020 RIP: 0010:mutex_lock+0x1c/0x30 Call Trace: psp_dev_unregister+0x2a/0x1a0 nsim_psp_uninit+0x1f/0x40 [netdevsim] nsim_destroy+0x61/0x1e0 [netdevsim] __nsim_dev_port_del+0x47/0x90 [netdevsim] nsim_drv_configure_vfs+0xc9/0x130 [netdevsim] nsim_bus_dev_numvfs_store+0x79/0xb0 [netdevsim] Gate nsim_psp_uninit() on nsim_dev_port_is_pf(), matching the pattern already used for nsim_exit_netdevsim() and the bpf/ipsec/macsec/queue teardowns. Reproducer: modprobe netdevsim echo "10 1" > /sys/bus/netdevsim/new_device echo 1 > /sys/bus/netdevsim/devices/netdevsim10/sriov_numvfs devlink dev eswitch set netdevsim/netdevsim10 mode switchdev echo 0 > /sys/bus/netdevsim/devices/netdevsim10/sriov_numvfs Fixes: f857478d6206 ("netdevsim: a basic test PSP implementation") Assisted-by: Claude:claude-opus-4.6 Signed-off-by: Daniel Zahka --- drivers/net/netdevsim/netdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/netdevsim/netdev.c b/drivers/net/netdevsim/netdev.c index a05af192caf3..a750768912b5 100644 --- a/drivers/net/netdevsim/netdev.c +++ b/drivers/net/netdevsim/netdev.c @@ -1182,7 +1182,8 @@ void nsim_destroy(struct netdevsim *ns) unregister_netdevice_notifier_dev_net(ns->netdev, &ns->nb, &ns->nn); - nsim_psp_uninit(ns); + if (nsim_dev_port_is_pf(ns->nsim_dev_port)) + nsim_psp_uninit(ns); rtnl_lock(); peer = rtnl_dereference(ns->peer); -- 2.52.0