From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A54FA1A683C for ; Tue, 5 May 2026 00:32:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777941180; cv=none; b=Z4+jrLuyYtgd5tsYsdl0Cud58f/f/Tc8D8GuoxLRHUAtqaxYSk0P+IHpL9xCjddgpvsE9B8ohMMS8oLJpiklx72FXxhTgMCehezOMQ03HcTX2mGzUOh7LZ7rUCc7Ku+F8YQj7LbAUe/vMHjwou7Z9QI2NZPZRtEBhVrrjV6S7+c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777941180; c=relaxed/simple; bh=fTVV28HC+xAjAAS5bnQYbsdGT63WEyXwEPPIV54zxdQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=r65rL+R5Y2sj7dmHgLt2e4lgW00wwAyHUL/MLfpnFZmNbKfy4Z9J+PuBYpnBM8P2dNpcCvlmAkOEKlqTs97QqGpUKWhNYGQxyiUkHqrGx/bttRCRtGwrf5KWdpnEYYUkR7c85BbH53AWB97pUquiFPDE2iR5kg5eONu1ZFblKxw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f7szY8Tc; arc=none smtp.client-ip=209.85.222.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f7szY8Tc" Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-8ee63e91acfso355764785a.2 for ; Mon, 04 May 2026 17:32:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777941178; x=1778545978; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vwCjmYDQDSbhK8A4q1s5JLoAl5JvbkQVBgszjF0OKGo=; b=f7szY8Tc7FOqO1TR825BLisXQ50VrvRZXYfen+VIxqPWtfSTdOvyj3vj8Tvf0k1HHj m4U7Lxkmhbj1dz0cCjWRUl+yQcTLrEj+/Ly9vY8iq3lpmAOFMgcjDsuTuxufPkDxQ9F9 iIS6dzxM8NQKM2yPFNtFRtiBhUVbHv/WNDiKXixu7phujMDmyo1X1eXf6JTR9wbMR2Dh zvFu47JwHi80HGWZecJ2ZFXmu48D3hodoonzokpw3h17X8tnHOBP+790xNc5P4mwDDba 4wS0xW0YpRttDiLk5O186cSuYzuR64LrNCqADpV3+uoYnrw/Rx1iTyX81sbytNAmkrkx yPxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777941178; x=1778545978; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vwCjmYDQDSbhK8A4q1s5JLoAl5JvbkQVBgszjF0OKGo=; b=KXXh0ES4GVPYQzPIQWJCZhpTKsbAxvau12DwNab4yOnAGnysmxVVRg4YKv6varG0lC WLKd7V2uKxJU3QFuPZ8hUWJ5K6BASNINIpTlR1Isux3p3aPT5gwiQprLXzqXqbJY7NFI rUOq+GjM+SUV3FFZkGX8OEeqRlEsxIIicONl0aEQ76bTIVeBQ1ZPdzxQuT24oPZ328wv 7krC3ymW5527FI7iqhihrkm51VTl2gDfWLX2CnnFFHyM+texTzmJDiQCrsXNZPw4Hrdn a4qdL/I0M8l8m9EjAkz/ZutgeqIeuJGQpNbK4gfssjPpornPIhv0CTHM6w8ah1PkGiHk h+Gg== X-Forwarded-Encrypted: i=1; AFNElJ+qSdXmUiRgAt2+eBi5PSJgJfM7dil+sGu3UlWO86tjv6LLCXfJ1HplR7xcZL/INFvQQVJondmxpaIE3os=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5o3s8/bNVbb4sswLHBkU+AXpPTp0c8hObgJ6eXM7OaXGM6hiH XPGQiiHfpwNNfouPRZwrDlGEm2OTERE33tQVBTfOG0m/f1xBGOHn9+t+ X-Gm-Gg: AeBDiesJ4xTVR3UguLG0v9y9IRWVDs1nB6FUbpFSnfP7hZQETYl69E2U0qQdWaYg8br ED/BrMrx3MdvhL7SUYalxiqxoZL4n8YDo54MovVJDZEOY9Q+xn/isfOb3n5UY8FUsS7G+qQhgzA u/sFxT7LAN1W8RR31fGkSpVR8kBjQBB+wzSh/2PGZOHtIy9A2NIGkzgTlWsfCJF6BD3TkmkGRNb qULnCRcQozs2HGk7q3uRK4u88f2R3q+JfOVTaZSSRrwHqfFPi35XyzI2TcWV1eivZymKfl+GB5U lEuJSP4ehlOKBA3II2TB/ykbWgBrUFheZmN4vA7qrUBN7875judA/lpoUdqtf+EvD2+ufctXaFI dnJyPT8ZsOZqPMbpqlms0xg5Q7k2DqqvrlH9az3u7CjqQK4IZaLEELcFBuyQiUfc2m3Fh3/Apta OvdleONEPuEZ/TgyFtx2HVoH7EJlb4EpQ+vQ4WzaJNG8AW2BMrbMo= X-Received: by 2002:a05:620a:470e:b0:8c7:a53:4d17 with SMTP id af79cd13be357-8fd16aa5ebamr1929138485a.21.1777941178516; Mon, 04 May 2026 17:32:58 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8fc2938e0b9sm1178632485a.9.2026.05.04.17.32.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 17:32:57 -0700 (PDT) From: Yuho Choi To: Russell King , Nishanth Menon Cc: Lee Jones , Kees Cook , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Yuho Choi Subject: [PATCH v1] ARM: Feroceon: Fix OF node and mapping leaks in L2 init Date: Mon, 4 May 2026 20:32:52 -0400 Message-ID: <20260505003252.2886028-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit of_find_matching_node() returns a referenced device node, and of_iomap() creates a temporary mapping. feroceon_of_init() currently leaves both resources around after init and also returns from the of_iomap() failure path without dropping the node reference. Unmap the register mapping after the register update and put the node on both the failure and success paths. Fixes: 4b8f7a11c9fb ("ARM: MM: Add DT binding for Feroceon L2 cache") Signed-off-by: Yuho Choi --- arch/arm/mm/cache-feroceon-l2.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm/mm/cache-feroceon-l2.c b/arch/arm/mm/cache-feroceon-l2.c index 2bfefb252ffd..1fe931a09d79 100644 --- a/arch/arm/mm/cache-feroceon-l2.c +++ b/arch/arm/mm/cache-feroceon-l2.c @@ -373,16 +373,20 @@ int __init feroceon_of_init(void) node = of_find_matching_node(NULL, feroceon_ids); if (node && of_device_is_compatible(node, "marvell,kirkwood-cache")) { base = of_iomap(node, 0); - if (!base) + if (!base) { + of_node_put(node); return -ENOMEM; + } if (l2_wt_override) writel(readl(base) | L2_WRITETHROUGH_KIRKWOOD, base); else writel(readl(base) & ~L2_WRITETHROUGH_KIRKWOOD, base); + iounmap(base); } feroceon_l2_init(l2_wt_override); + of_node_put(node); return 0; } -- 2.43.0