From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f173.google.com (mail-dy1-f173.google.com [74.125.82.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 882A93B6C16 for ; Tue, 5 May 2026 04:59:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777957198; cv=none; b=KAmRQT4Fp2KoppogO0IRvSg744Z9LUdbUKBAeZHZ+Cy/dXxbUWrXaiPHTNxxRRFG7WanxOK1TauAaX8bGR9+sgWzn/dK0AxfXlEeNYoLj4KoeOcWJHMY6WjVRKeveHE5Omf0zRNQTsIP9kwXpl56+J7MX2vzggslSH5LXKHHnmc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777957198; c=relaxed/simple; bh=VFdrAZoVLC4fQhDueHQHa6dNg4khUzfyM4bGbZqKHNY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=CcmKvEpP+ij7ielqvwBhEYjZICm4+gxxGUNRrdPkHXDffYeD6mbkOmxQOhx8CsCwR4S7kwCGvIYHESlPuupOF3Y65iFOJyAJwMjx98qWkLcLPU5FaEVjX0pQF4ql0L5BPt4EoLt08icCV9ZSOeWN5ZAgcDTyUKYCQncbjlcUA8o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Foz6b8ig; arc=none smtp.client-ip=74.125.82.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Foz6b8ig" Received: by mail-dy1-f173.google.com with SMTP id 5a478bee46e88-2ba9c484e5eso5276211eec.1 for ; Mon, 04 May 2026 21:59:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777957197; x=1778561997; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WxAG6wmMi0r6jkkaHKyUSCVdOHZ9UsxXPZ5kjHekB/4=; b=Foz6b8ig/extUdJxsormurwIUn2OXhpGhmncEDlGWg/rM+PbbN0vrCsGQQv9KQAoDE hXZPaH5JVga2C1nX8NR4VjjxKdrOAniBhkAO05U7AFWDY/L9Py0zMSOs0lbKVG8H/ht5 k9D637yUjDuigqt3kaZf1ZjlZRbWfVG7efO8D9Qk91JeIdraWmAnAuEFmqLupUqrwYJj X/i7XNWHB/vCONLxEY/B/CFg5vYSZUYwaSTE9bc0NqfctgkAXPczN864MGmcvICT7WzE 4/bZ3NiqW+fIED5OfpHWUEYqQLTSPOOJiSgsNHCk2Yn/x6c0AXt7EtX8LFCYPIzJ9XKR rfFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777957197; x=1778561997; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WxAG6wmMi0r6jkkaHKyUSCVdOHZ9UsxXPZ5kjHekB/4=; b=YZFfQU+HJBs6NYiQUlWoKKnNFeBW6gEXEKuqhDTWmuzXlPvJlSwv7WCspPAQ3iPmnB ytYtZDgIrGUKy+iFARWpnZl/IhaNUpfLNHkxX+Crdkhs3SHofjNQaQ9xSWLPyBcdniCN EU7KTVREALxCT+RUMYmOI147G/udws8X0rOqpdjCZnqy1NGdyAL6WK568WRZGrywZcC1 WaG0cqtq9IjE07n3gqSgHHH11r4TMOtnAMsyYjBKqKxqnSPJOzsj6KZMpYsMAgOJkjJz KpeZPZD1Bfffb3rcIIVWUBxvvuDhIFgxh4v0UmARAiv/9JjElzIEiIeXTbkM6nhWPazF yc2A== X-Forwarded-Encrypted: i=1; AFNElJ9lrzO4M2s2K3v4DiUXm/85rBBvosbzMCuVxj3NznStZLJwe+ezNYIL0330KD/WhVcniQPrCy3CP2IzxOM=@vger.kernel.org X-Gm-Message-State: AOJu0YyrrwNu4bQSgJna2l4kGckCpUy8taVp/t/zSijnAVSnFYmFbHjk lQL7WNVAj/42N8SIh98BQFApw3dvi9quQZU9qMF/N+YovulxP6kMlhPqjCOz6g== X-Gm-Gg: AeBDiev6shr85p4wdoplXlyZj12SFGdg8+qIXOEx9pAGSSPb9DMDqfnajTariZ6lSZF uh+vmynlNUvP8FXsR/tC04uNhXnBhdB7uzoCzz009bEJ3GnUKgcXHYkNXbBnPT+RrQynzY9iK5C AAjUs/9XX+u5H5imvcy6biGT+vMbfcaMFtKNXJmNbfW60VM9qpjQ82aUWyWLx5QqafADVRS52R1 EqyxLkd9HMKLMPOLwXu3Jd4kY8O16SvnCAA99jV4S0zXk092yH1vR2v/41hmeQOFNloFKZLSpAY Qau+HbxxA7hjEnKjvVNSZ3jH/vuYrCv644cwlD8HQMZrrTal81YrzkHB99VZ5aNl6QwNiHLv2wS 4vfT9XP0U+o6x6BJHjNSrCNzeDWQeVnk73mxaIhUtnL7iiMKnZO7R2U3QqB0+kx7jkpamgqHyEN vQhyJnzxOxTrCaIu/xBxzkNj2QtpukoG5iAlxTQyu5Czf1omrRL2NMX7NWPYnZvTywB9VBHMl9C SCbKgCDkUBU5APiL9HWvtklWg== X-Received: by 2002:a05:7022:611:b0:12c:8e7f:1b30 with SMTP id a92af1059eb24-130b163f8bbmr900233c88.2.1777957196554; Mon, 04 May 2026 21:59:56 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:94ef:a6f3:2c96:2d58]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12df827a73fsm16897502c88.1.2026.05.04.21.59.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 21:59:55 -0700 (PDT) From: Dmitry Torokhov To: linux-input@vger.kernel.org Cc: Marge Yang , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v2 01/20] Input: rmi4 - fix register descriptor address calculation Date: Mon, 4 May 2026 21:59:31 -0700 Message-ID: <20260505045952.1570713-1-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.54.0.545.g6539524ca2-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When reading the register descriptor, the base address is incremented by 1 to read the presence register block. However, after reading the presence register block, the address is incorrectly incremented by only 1 byte (++addr) instead of the actual size of the presence block (size_presence_reg). This causes the subsequent structure block read to read from the wrong memory location if the presence block is larger than 1 byte. Fix this by advancing the address by size_presence_reg. Fixes: 2b6a321da9a2 ("Input: synaptics-rmi4 - add support for Synaptics RMI4 devices") Cc: stable@vger.kernel.org Assisted-by: Gemini:gemini-3.1-pro Signed-off-by: Dmitry Torokhov --- v2 of the series: added a bunch of new patches. drivers/input/rmi4/rmi_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c index ccd9338a44db..06f5e3000cf0 100644 --- a/drivers/input/rmi4/rmi_driver.c +++ b/drivers/input/rmi4/rmi_driver.c @@ -594,7 +594,7 @@ int rmi_read_register_desc(struct rmi_device *d, u16 addr, ret = rmi_read_block(d, addr, buf, size_presence_reg); if (ret) return ret; - ++addr; + addr += size_presence_reg; if (buf[0] == 0) { presense_offset = 3; -- 2.54.0.545.g6539524ca2-goog