From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f54.google.com (mail-dl1-f54.google.com [74.125.82.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24F483D5259 for ; Tue, 5 May 2026 05:00:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777957231; cv=none; b=eTT2pz0nchnqDBp5hc3LoyB+0+IjorskielQEKLCK1347dOO00D5PUKKo+l3aNY0j1U7O480lAE7cIjyFEyhx6YIHjV9iY2CIj/YfAVW/KMI/4T8ziW+tx9GdTjN9dJ7YuyG4Fg1/WSAGAtdEofqLGaiWyHmgxnVe6+GDI0u3TQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777957231; c=relaxed/simple; bh=lvgn7q0Ow84Yi1NlycJeboE0aL1jixpOHvToaCQWwDQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=islvj4qdaGMKJqo1dfcb/sPcxWuP9e0NFrmGA2aXoUuHhj0FMNyBN4nlONszkqST+BjD09ShghV8QfByxSFNJMsyfZ3v7XnE7agN3MMQq4oaf5e76L/jtpmRugJqfyx9UCoJOrANMCcLKxG/a+9PAL5wli1DuyQLSgNcv8kO528= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=B8iwpY73; arc=none smtp.client-ip=74.125.82.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B8iwpY73" Received: by mail-dl1-f54.google.com with SMTP id a92af1059eb24-12dfee30612so2048769c88.0 for ; Mon, 04 May 2026 22:00:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777957229; x=1778562029; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ITP9fYm6668VerGxzkCEPeFYtOb1KXTza8Qxp0QEEgk=; b=B8iwpY73W2vYctF2vgXT9+iraz53Xy9A21UeAl+eoSk10aQy3sZKGXa1CMm2lu+rE5 YEkJ1fuXatEpOIeBwZFFTV/oUfKnUROphmrcr/5CtP14ZE7HyNFZdMGdesWDlULUACXY uoKSkbSSekXNfciIdeRtTJk//HYwDA11zlgZJym9c6mwYpa0bykiqYopM9iFwNcfIy/K IMT+nB+OQ89oS/oAHOYc3t9NJXAP02LPmsOuLDTiaFc0NTHFB8e/ORzr+FBGwfguJ+qj PLmudx105O2ZMU3Ef6EyoSw8aeeyVPkgxwWGrQC7+9ZPKupJ+z//IqGO1zmjk0OlrW08 UtUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777957229; x=1778562029; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ITP9fYm6668VerGxzkCEPeFYtOb1KXTza8Qxp0QEEgk=; b=oY027KsxI+2ekQkUBE3PYVeyjvvTRXU3ec3wDFVV1y1umW8+x02G9P/xMjiGW+13lF 1Fc4QWf8xUUkovSrHyyn1tQ6CPX3w/k/oWuM1MRkIjW8tz+Psi9o6XuMq2yM4kzZiVOJ 7kadnhyfTZMEdSkSGWnj4UwIUC5EtNWle+7h/lubi3JvylR9jnpB6ijpG33crw/AsWs9 YjrM2McJtVY0hv6+EqnvYsF8H2AV8Rim7Zh91WM89FbHam3fTVWRRb1FDqkw4HNzdXH1 fs+YVAWfMGlj9QqLj7AWU49danzgF1OeIKFS5157/0bx8ffiGAbkNfDjOPIn94jXYlLi jFbw== X-Forwarded-Encrypted: i=1; AFNElJ9Xi3mZsOAddAtEx6VEBtWYz772P91t9cRhfYhqSVw1wZvc+e4XNsoYu+ea6C8+2Dbo1+8hhnwcFzEuXvk=@vger.kernel.org X-Gm-Message-State: AOJu0Yzm9XiJHXNif9F9ACvQ0GbEls1aGZGOFEft+YbHjRo+TLTMDQuk XdguOIjvANhD3XQbwhGxnRRcVGSWQwaLmz36TTc4PSjA6p9UNh7hVrkt X-Gm-Gg: AeBDiethrsjPZW068+/zop0oUcMIy7j0z7IkHnQiha6MM+Cr4gnuVt34HyF2J1ka2GU VXwwgWtWVaavvKqVcQsj3IALC/MQQyXK1GbTszFJzvolNk2sAYslAmiXJWj0mUTF2iLFKevg0HU OkwTFYNXcUtN+2ajnSBhirxqVmUmCZTSse2cS1lVYa6kRVohOgOwmG9tC3D69eZtQaOpe4X3UXp dOss15ddVMhG2q6gf3Rk6B9fX1awdfVEx/sMFO5Ud0IaGaWX/qUqJauLyYj0EZsK2lIoCOI86ZU YYSOJmBpECKnx7XJaeVtNApl6TfyeAeKzrqEvMYxAQW3QdV9KthoqATVoJQovkY8oiaSSfN8UAI 29/J8Kky5R1EjlWrcnWy/gqf6lpFdCP5sFxA37L95n9qFemNpqu0eUmjSTxv8UHwVjHiWNLl0Ld MgODqumuweBP+SGPH1HAx0Eftd1LUCM5CGQGx595QzgELZ/m1iQT+8dIdZVT658LrpDSdoKkwI7 qaGYZuX6RLP4pdJlhQAXRI8ew== X-Received: by 2002:a05:7022:6286:b0:12d:d972:b96e with SMTP id a92af1059eb24-12dfd81a804mr7139807c88.20.1777957229175; Mon, 04 May 2026 22:00:29 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:94ef:a6f3:2c96:2d58]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12df827a73fsm16897502c88.1.2026.05.04.22.00.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 22:00:27 -0700 (PDT) From: Dmitry Torokhov To: linux-input@vger.kernel.org Cc: Marge Yang , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: [PATCH v2 17/20] Input: rmi4 - use sizeof(*ptr) and idiomatic checks in f12 allocators Date: Mon, 4 May 2026 21:59:47 -0700 Message-ID: <20260505045952.1570713-17-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.54.0.545.g6539524ca2-goog In-Reply-To: <20260505045952.1570713-1-dmitry.torokhov@gmail.com> References: <20260505045952.1570713-1-dmitry.torokhov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Using sizeof(*ptr) is preferred over sizeof(struct) because it is more robust against type changes. Also switch to checking for allocation failure immediately after each call, and update formatting. Assisted-by: Gemini:gemini-3.1-pro Signed-off-by: Dmitry Torokhov --- drivers/input/rmi4/rmi_f12.c | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/drivers/input/rmi4/rmi_f12.c b/drivers/input/rmi4/rmi_f12.c index 01838907c64b..34ed02b7f30f 100644 --- a/drivers/input/rmi4/rmi_f12.c +++ b/drivers/input/rmi4/rmi_f12.c @@ -528,16 +528,21 @@ static int rmi_f12_probe(struct rmi_function *fn) } /* allocate the in-kernel tracking buffers */ - sensor->tracking_pos = devm_kcalloc(&fn->dev, - sensor->nbr_fingers, sizeof(struct input_mt_pos), - GFP_KERNEL); - sensor->tracking_slots = devm_kcalloc(&fn->dev, - sensor->nbr_fingers, sizeof(int), GFP_KERNEL); - sensor->objs = devm_kcalloc(&fn->dev, - sensor->nbr_fingers, - sizeof(struct rmi_2d_sensor_abs_object), - GFP_KERNEL); - if (!sensor->tracking_pos || !sensor->tracking_slots || !sensor->objs) + sensor->tracking_pos = devm_kcalloc(&fn->dev, sensor->nbr_fingers, + sizeof(*sensor->tracking_pos), + GFP_KERNEL); + if (!sensor->tracking_pos) + return -ENOMEM; + + sensor->tracking_slots = devm_kcalloc(&fn->dev, sensor->nbr_fingers, + sizeof(*sensor->tracking_slots), + GFP_KERNEL); + if (!sensor->tracking_slots) + return -ENOMEM; + + sensor->objs = devm_kcalloc(&fn->dev, sensor->nbr_fingers, + sizeof(*sensor->objs), GFP_KERNEL); + if (!sensor->objs) return -ENOMEM; ret = rmi_2d_sensor_configure_input(fn, sensor); -- 2.54.0.545.g6539524ca2-goog