From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f43.google.com (mail-dl1-f43.google.com [74.125.82.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 041333C872E for ; Tue, 5 May 2026 05:00:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777957240; cv=none; b=j5mA+KUrGGvu6q3MWr2hGNJw33+aRA571nwP1LPPEaxhhIun95gqQ/7FzuTtVF235Kh9ZWAoSGCjLfdYhZPK9eX8QhluuQhTN6PD+XruWStBs/Ee+pqWoIVGpzLvguBTar4DN5TLn1qII7vwQS0E9xcmw4TF7OVZgj9qZEc/WEY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777957240; c=relaxed/simple; bh=4kkcscaZmHFJ4YWxD6BD9kpYK/3eYjWDpjnqHTFpBSM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=utFr7Lp/O9sowKiDioG5832liigo7UlAkuCIIIChvW32dj9aZS0xGzx66cwc/omRMmfqlk6/VI9r3MG7c5WpLxBVL27gVkgD4WSBVJpojJNlp3Ms1dOny+oA3OGfYWwr/v8kMJcC9xwnGbzWynTGMgmv+HyLpEVu+75saibWp5E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TLotZjYA; arc=none smtp.client-ip=74.125.82.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TLotZjYA" Received: by mail-dl1-f43.google.com with SMTP id a92af1059eb24-12c19d23b19so7019572c88.0 for ; Mon, 04 May 2026 22:00:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777957238; x=1778562038; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=72V7ol7Ytc4urKocnYQLQfygeemqtzjda7Fx3aBgxpY=; b=TLotZjYA/1YYW9t1glBYL6LzF3QLKYRvoX98Bk3hqAzFbIVpvVdT9Zt13QI6NhwXyx GxsIoIHXT8nOcpuafFwy9M2lDa0o4UlWJEv+0mxxeXAelER5ozRGqpUqkohDrKnEgD5X c841FaRja9h3IP16k4YgPBomhdxGDDu7qSP1hJdZPoWWHmyq4SjMBcnhUbBq17e1bVyo l1iF+4DHbxwP9/TX0/oYghgC4EoZLBmdBRFP2B6M0giHDTcNwu3RvGDj5yE3H2sdhF43 kggCXIa3fsttpk5lAeeTPYM0dLf3v+7N3qV88wJtU43IoETmt2cyZnH2FJBNRVG/KSw0 69yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777957238; x=1778562038; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=72V7ol7Ytc4urKocnYQLQfygeemqtzjda7Fx3aBgxpY=; b=Ifj05SF8EOhGAYGWVLgdccYQDW/HaBP6p4fwGdiyQj64nuOCLYJIErL+RE3zEriekh 2vAzMeOaPEECtm4TPme/XbCSz9uEZ8xxDarTgyLSs773NnBXwzyD5SeY/gdv4EiaHXbt usVb20mHlIYBAF7kgcY9KVgwTkWuZj3Z8dMjolc/cUo5hnHBIPm5AAjKZHRonxtfOeD4 /RzHgVPACveyZ3eGeHKP1fJx9WV2/dvIdyUXGq5W327en+733sHkPuvA7j2xDfcg7Kjc iWjdmLCGY2/Pg0yYOP5u0gJlu9HMvEJtaXB7LiVlZoPZ5HGf94dXD5wwo5Nb4vwd1dSz 6wjw== X-Forwarded-Encrypted: i=1; AFNElJ/djVtnAO7z9c6SaYOQyRBMzVu1Mr1lC4m5VmHAfkftA39PaL+O6TUtUakWjnf+7QXHYzRAYVL4YnfdJog=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6HiAVVhMDkNDA6yCpf4K/EszqRiXvp55UVEOSRvGtxte/hxf9 aE/BGk6vD61C5l67+iKFlLeEmYlmq0ctK4zfFOaB26ESSVFZAZQDW5Q+ X-Gm-Gg: AeBDiesRlXXcoJFcSQDOaw30GsyYJk6VjzVQYRw52r//h25y0btn3y+URIoQHiis/sL QDWZe0Cv5WLLlQ94KAp2EqmYvEbausrINEvaX588MluIlaBvci0QHIUegaRGv0gjTF1WcNcfonr CZ5PC8XPyvWE8aE+chAgIuZmSjAiHY1VK7T6TTL+KMpb9H+wrPTbz3rzyxsMU/sPb3BPpYEc9uI xto+Owe1saqRG1Gjvm/LZo3Y8ZozDEdRebWQp+pH0SPAlV2xn3U22YkBWS3coe2tcsnne0h/Omw 7IZ8BOmbD4PXXjzwCtW18u4dodXY4l2W8dRn8aMR96V6DzPTnQe9XHBazJE2NiwoHhsxtIFsgvW QOmGpOQhYRiSB1kCqheGF9AyN3a4kTXhFvpP7CZMdu3ZdN3UpPYvl2HEWkas7/xYnhiNeKvlRoq d7FJ/8ZE7L38G5EqNoQXZeRbhkP3EL6DOCydZRzOMGHqH3wpu01OtHLrNtySoC31HwO6F7F9c6o JTOEQdFi8bq9wiYX2xAs7sVRQ== X-Received: by 2002:a05:7022:224:b0:119:e56b:98a4 with SMTP id a92af1059eb24-12dfd7ba4cfmr6023780c88.11.1777957233464; Mon, 04 May 2026 22:00:33 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:94ef:a6f3:2c96:2d58]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12df827a73fsm16897502c88.1.2026.05.04.22.00.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 22:00:31 -0700 (PDT) From: Dmitry Torokhov To: linux-input@vger.kernel.org Cc: Marge Yang , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: [PATCH v2 19/20] Input: rmi4 - propagate proper error code in F12 sensor tuning Date: Mon, 4 May 2026 21:59:49 -0700 Message-ID: <20260505045952.1570713-19-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.54.0.545.g6539524ca2-goog In-Reply-To: <20260505045952.1570713-1-dmitry.torokhov@gmail.com> References: <20260505045952.1570713-1-dmitry.torokhov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Propagate the actual error code returned by rmi_read() in rmi_f12_read_sensor_tuning() instead of hardcoding -ENODEV. Also, since rmi_read() returns 0 on success, use 'if (ret)' instead of 'if (ret < 0)'. Assisted-by: Gemini:gemini-3.1-pro Signed-off-by: Dmitry Torokhov --- drivers/input/rmi4/rmi_f12.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/rmi4/rmi_f12.c b/drivers/input/rmi4/rmi_f12.c index ea72d5ce8050..bf8c4a0e10de 100644 --- a/drivers/input/rmi4/rmi_f12.c +++ b/drivers/input/rmi4/rmi_f12.c @@ -166,9 +166,9 @@ static int rmi_f12_read_sensor_tuning(struct f12_data *f12) RMI_F12_QUERY_RESOLUTION); query_dpm_addr = fn->fd.query_base_addr + offset; ret = rmi_read(fn->rmi_dev, query_dpm_addr, buf); - if (ret < 0) { + if (ret) { dev_err(&fn->dev, "Failed to read DPM value: %d\n", ret); - return -ENODEV; + return ret; } dpm_resolution = buf[0]; -- 2.54.0.545.g6539524ca2-goog