From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f44.google.com (mail-dl1-f44.google.com [74.125.82.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A159F3BFE41 for ; Tue, 5 May 2026 05:00:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777957202; cv=none; b=TW+SiROp8rCKsX+fhUcwkrQzCKHFAnc1Q6MhWkME6b0wxDUPjUgBMD4QI0Biaj9dtTxb/wuLRWBwhWVluPdaMASI0SJWUhD5mkeN6Y8vNtsAretZpjccjHH34ojoMysGgF4dSTVlyjptFcrxDkSaFWgt4Wgt9777mxmdZ2zBdfc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777957202; c=relaxed/simple; bh=5rynYdstDSidD8j/koIGOQVJQmbG3RqF9LlqykFyDW0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pQsU86Mh7WZkIaH5Z0t0vGKu3TUBSM1hka+wEAnfhXfgVZhPCe0LZr2xsHzpchP/YvzBClbg0ZsKgj19YCm7Lwwa0Ksus9KoiPPB+6Ub6jk6jkdEVNDJ1q/wB8f4bXEJ7sWsCInp+2LF5e9zXba4iIvZoxAN8rELyTtv0SEDlI0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XQESCUo2; arc=none smtp.client-ip=74.125.82.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XQESCUo2" Received: by mail-dl1-f44.google.com with SMTP id a92af1059eb24-130b2295ed0so878985c88.0 for ; Mon, 04 May 2026 22:00:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777957201; x=1778562001; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+9AIIjE/oL3/1g9erZ/rZjvg7OI/hW1eJeMwxNk6yK4=; b=XQESCUo2ymAJhm0ey7Gcij7Cl0XNN4sT+sOKXie5w7H0eeUjsjQ8m7J9MGKM8dlPae tRp1R4ugY5Gi8mmOx4adhPaaMLJfRvr8CLxd1gLfhvRPol7E5MxyvLM7OigxB/snBssf nfBpw06uvB2ozTjesVHZJCOY0cDswExWNm6UnkTTG63bImJJj3zjWHcn0vn0jRbR7VRW bwP1jzdPVbflOKpHYE7yrL+TbdWjWxfILNmQKvOX3cbcTOVLbXLuchJOSeaRkxI2e++Z ygmcm7YtYiF9VVC0Eh2FDMIRrQh4ofiPQTrEOhGIm2Icduho2tMLYnIZKeA7d/U/gWSF YC9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777957201; x=1778562001; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+9AIIjE/oL3/1g9erZ/rZjvg7OI/hW1eJeMwxNk6yK4=; b=ROeeFBKy8Jtz5f6UFlOTLFIeAf5Q4pL6oDa7U1DghfUB54a0NXlsvzPP6lkUIbet9G 0dRBzEzT2M7dHNvkH9qAf04XS5CyocQnj9ke89ZxeB7aCOovkDbEWkmdzjlciZuttLlU Fu0reuVQlXdwXlFlhdWZYOuo5A8EsMrCubYomrio1Hppzies0dQo3BtzSL8mc13ZsBCZ w2GwaPQFqv5lo3BrBq64faEyX0J0F9tSz7wARND+fjXTwaElxtc6TwogCdApoi2ltJEi mVxntlzFaul5Wl56BEb4+0LJ1YwkY7nmSzY8CDeRa/RneV0Ys2Hii1hEHtpok8Tr5Utj 65Qw== X-Forwarded-Encrypted: i=1; AFNElJ9ybYrjaGuxN7KQkhxtFGwpp0TuoFrlXawsU0vl1wkMY+lDSnDCnBvoht15Rg7JjYVH8mU+pU8N5v4PMYc=@vger.kernel.org X-Gm-Message-State: AOJu0YzMwt/XdyRxqwgaQFOxZ1zbJ/nUrEsCROWzd0vKlUQ9VcL+kY/h Kj7RVrRkAeQuQW4yuA5N5w3w3Y/gwDS7rytk7wSR5CIq93vuaDZRbkOQ X-Gm-Gg: AeBDietQJcp7mM1J+UKFiiuQQiG5ANVZJ6C5y2XTowKBoKv8oc2Lma5LOyiNA6urtUd hgaO4+b9geJyR46vHz25I9WuIKix1tVGJUyjeCW8OfwhxNT4tybaORq/v3GBMgJxaC40KbpzTXs uOP9u6eV9dgGeMzt57C8johDSk29UNn6qJDbVIAHXIbvNzT+dSc79wFklwyL4ku+rg7KMsRSZyT tJcBcZGkC1qf3xifWspFaA7esHhJNJgNyU7O06StoT7CcTUisOnXbQmcutQxYCrVO1/JhHpgjaI OztijYhxVaar+2feHNFZnG+PW4wu/I5OHtF29+JpBYTicNx9J33uU9lO57tVLr4iLFFtuWyhHs0 mPak64E3PbLsIcXVOWjrFsrUhjJ4g9b5NcFicW7bnBCcHZj5YWYyjtysUAQf9cf0BIAjHx/3n5Z HUkFj6CbS8djZtMuuHh8UqGCnrkaVmaqoNKf62YSKOFMMh61vuuFvrOZbnryRAQt1I5phM5w0Dt yfetF/TbryUIvbTx+h2sprEXw== X-Received: by 2002:a05:7022:4392:b0:12a:713b:896a with SMTP id a92af1059eb24-130b1752d68mr981710c88.17.1777957200796; Mon, 04 May 2026 22:00:00 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:94ef:a6f3:2c96:2d58]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12df827a73fsm16897502c88.1.2026.05.04.21.59.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 21:59:59 -0700 (PDT) From: Dmitry Torokhov To: linux-input@vger.kernel.org Cc: Marge Yang , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v2 03/20] Input: rmi4 - fix type overflow in register counts Date: Mon, 4 May 2026 21:59:33 -0700 Message-ID: <20260505045952.1570713-3-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.54.0.545.g6539524ca2-goog In-Reply-To: <20260505045952.1570713-1-dmitry.torokhov@gmail.com> References: <20260505045952.1570713-1-dmitry.torokhov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The number of registers in the RMI4 register descriptor is populated by counting the bits in the presence map using bitmap_weight(). Since the presence map can contain up to 256 bits (RMI_REG_DESC_PRESENSE_BITS), storing this count in a u8 can overflow to 0 if all 256 bits are set. Change the num_registers field in struct rmi_register_descriptor from u8 to u16 to prevent potential integer overflow and ensure safe processing of devices reporting large descriptors. Fixes: 2b6a321da9a2 ("Input: synaptics-rmi4 - add support for Synaptics RMI4 devices") Cc: stable@vger.kernel.org Assisted-by: Gemini:gemini-3.1-pro Signed-off-by: Dmitry Torokhov --- drivers/input/rmi4/rmi_driver.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/rmi4/rmi_driver.h b/drivers/input/rmi4/rmi_driver.h index e84495caab15..5f769fcc758d 100644 --- a/drivers/input/rmi4/rmi_driver.h +++ b/drivers/input/rmi4/rmi_driver.h @@ -65,7 +65,7 @@ struct rmi_register_desc_item { struct rmi_register_descriptor { unsigned long struct_size; unsigned long presense_map[BITS_TO_LONGS(RMI_REG_DESC_PRESENSE_BITS)]; - u8 num_registers; + u16 num_registers; struct rmi_register_desc_item *registers; }; -- 2.54.0.545.g6539524ca2-goog