From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f46.google.com (mail-dl1-f46.google.com [74.125.82.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69A853C278B for ; Tue, 5 May 2026 05:00:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777957206; cv=none; b=nRbpxJ7ncI5iAgTMGpDmHYSyhdiw8TcX+A/uq73i7Gn4fBSeNupNS1DeKmjV8vpenwyVW4kGbCexlfi7zChD9Y4iTLsUvD8zEN7U1X2jRelSBXalM8Dx6XIFrvLVJG1rkbOyBuhp8JTxjP33JZGabkzte81iZSMGtym2kNrMzk4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777957206; c=relaxed/simple; bh=TEvCiEbQhzE4Pn5a92hAxEUB6/ep5l6pVtFMl8q6X+w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tNJnkKLTOHL6BEv4RzE/z/SpYO1UDcn/AuxB2KHFmRRNU/fxGK3DvagnvbYYnE9LvMglTZ4dVb2ulk/8XYBIXQRJ8M+CL9vWhGyvQeExEFFcHxcOIn117CoUq6HgJPzAw11HC+EN9bHoiwHzBUmeLtZfeCgVXP033HU9uT5omDI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hYA47lWI; arc=none smtp.client-ip=74.125.82.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hYA47lWI" Received: by mail-dl1-f46.google.com with SMTP id a92af1059eb24-130c653cce4so59438c88.1 for ; Mon, 04 May 2026 22:00:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777957204; x=1778562004; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RYBlozxzCL/KPqU6onSXZMaSuqAKVSHz3cyPWSVaa6M=; b=hYA47lWIWimqmlEsOKM93i+Sabxh2xCpfkxphpCcI2aeIGNnVNg0PtymoVTnSinmtA oOjxNNDkA8JOvWdebMJvlgcu/hWVuymZV+dKuUOcabE1JswwiZzIAa5JU64DOQ/QGn7L TSzmt36o6KWS3YdQQhsemquqvFQO1ayAya+NEQhxLffUMdP1y20+X4B8PJgkkpiXnHDk Y3Nwdr1G/mxTR5/HNraZd2/LyXocFiRmMeIaFBjW6JqWfr8bR4cl1Q89AWSy2F+XTRRH FGUtWZN1woWVFRqzkYvKDqZIXkpjFQV7HBUzheZaoatDhruHaR+1Se1KJdPeW6epxc6I Rqyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777957204; x=1778562004; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=RYBlozxzCL/KPqU6onSXZMaSuqAKVSHz3cyPWSVaa6M=; b=qT44OGAUC71ZvGWeBD0kn3Jp26W1qdj6Kv2f/5muv+ebL7QvVgSCAfadSoBjn0hXew N6uPSpdlVLbDvVc7T9wHAYm3V2fyJi0MtJOSTEiWJDialsSb/FgM5T8QaL22f1jgzja7 9RSe/ptwD0Nl4ymNxGKFyKrH6PgL+3VLTyW4cWxwGXIOsGqRnRllgPHpH3+3G2nR1na+ IUISXmLqz9mHD7R5ZItfoTGf5qr3kWthHyh10nOqw4mL917+NYViiZhePFrHbcWy01Oq +wR1KznMJoTfOWja+LvcPgyWB+dmSlAruWe9CatQ8U0wEJAXDHo+O6CHolb0woO/HSrP iWTg== X-Forwarded-Encrypted: i=1; AFNElJ84yksGVneB2oeWCYz4WKJBQDSK1qmjRgIEUZUHEGAxb5RMZcfszEVk4ZWfj9S5PCj42eAv0Jlhzflg1Yg=@vger.kernel.org X-Gm-Message-State: AOJu0YxV36XaSvubPQTAqqz2r9b78LGu+yVu9OPIhQtA82bw2R1xM8fI 48s7TIlKtICh60HYzfRlPWy2F6esXWxyEXrQxhCdFr/TGeEJ7Y5rjXc8 X-Gm-Gg: AeBDiev8nOPAXfPXknNv7MaUKPu9S1tuQ9rj5OCG7DnVpsClqF/l8+5K0Ywg2Enk43d i19kH5Vu8ZoP0A7ONssgCMY+6HJRq75yrdFYpF84hzMvbb2SDQ+8TBr3bK9GsKL1xvRa1eFryfO qpztSWRY4wsB62/zNbfHBRZcWRQs3bPlSTtUYokUTdkxqakqWpm5Z+2Cr7et4JZV6N5BBvn1bVE cvkzQYnbYv6ch5Cgnh9xCSWBw5c3wL5ddzNIu9hcfxQh0hw634qv79hVV+wTp7r37B783IoC9f4 0x6XY+/YYqJWlHFhWZVKsBaW0zeOFAI8rgPdltEQmVNX2IsFc8tYlEMFAPwbIm3tLK0MPXgrTFk 2QoJjXu1W81qM8bx3TDR3RmqpTn43XvdTNHRlJIVcKFiu114Y1elZ5eVln6bU4CLifkT3ncay9t 6IwlyudLRSYp5Q6RverQt43v62Avfwdso1puHunSLe6dKIBP5zI51afwRHLkYl2Snj7bXaep6aM SETErcyBzG3aRkt4ZrM0EuAbA== X-Received: by 2002:a05:7022:61a:b0:12b:ec67:3529 with SMTP id a92af1059eb24-12dfd7fc727mr5726975c88.14.1777957204506; Mon, 04 May 2026 22:00:04 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:94ef:a6f3:2c96:2d58]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12df827a73fsm16897502c88.1.2026.05.04.22.00.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 22:00:03 -0700 (PDT) From: Dmitry Torokhov To: linux-input@vger.kernel.org Cc: Marge Yang , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v2 05/20] Input: rmi4 - fix memory leak in rmi_set_attn_data() Date: Mon, 4 May 2026 21:59:35 -0700 Message-ID: <20260505045952.1570713-5-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.54.0.545.g6539524ca2-goog In-Reply-To: <20260505045952.1570713-1-dmitry.torokhov@gmail.com> References: <20260505045952.1570713-1-dmitry.torokhov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit kfifo_put() returns 0 if the FIFO is full. In this case, we must free the memory allocated for the attention data to avoid a leak. Fixes: b908d3cd812a ("Input: synaptics-rmi4 - allow to add attention data") Cc: stable@vger.kernel.org Assisted-by: Gemini:gemini-3.1-pro Signed-off-by: Dmitry Torokhov --- drivers/input/rmi4/rmi_driver.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c index 75949fb1a922..d873c7f08e42 100644 --- a/drivers/input/rmi4/rmi_driver.c +++ b/drivers/input/rmi4/rmi_driver.c @@ -183,7 +183,11 @@ void rmi_set_attn_data(struct rmi_device *rmi_dev, unsigned long irq_status, attn_data.size = size; attn_data.data = fifo_data; - kfifo_put(&drvdata->attn_fifo, attn_data); + if (!kfifo_put(&drvdata->attn_fifo, attn_data)) { + dev_warn_ratelimited(&rmi_dev->dev, + "Failed to enqueue attention data, FIFO full\n"); + kfree(fifo_data); + } } EXPORT_SYMBOL_GPL(rmi_set_attn_data); -- 2.54.0.545.g6539524ca2-goog