From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f45.google.com (mail-dl1-f45.google.com [74.125.82.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DE883C4565 for ; Tue, 5 May 2026 05:00:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777957208; cv=none; b=oc2F9DZgALiHlxpkslKTqpBkdbEGcBS9t0iQxAzVfmKmyF+mM/jEoUo3MWw7galkmUBVk/AXAB8lv8WNzsrjhMKnysJAZWB2y41mw/+hXI0l9TZKXGYuMmnWPqIolF+xIsku66nSrrA0XrDpIYihcX8t/PCwGOiH8Ht6e7cJ3tA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777957208; c=relaxed/simple; bh=sft4S321VXYeqpilqeEW/bXaAPzvEQnvHkltC7Lc9/Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jAwgZ+7s6B/ZkONaw0ptbSdtoHuKpuq29BwPo69Q8UxNtEL5gjDWw59234cGRU9EfhdG95Hk4/6zwCVdJN1EsgFHMDdam27K+IRysI1GRxL4PgFG7GhE5L4Dptbt5N3j12t+4KtDg++ulQmMOw6OvVPz1rIv5DxfzxQ/iJPbJM0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TS/YzVQ3; arc=none smtp.client-ip=74.125.82.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TS/YzVQ3" Received: by mail-dl1-f45.google.com with SMTP id a92af1059eb24-12e332315a8so6951113c88.0 for ; Mon, 04 May 2026 22:00:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777957206; x=1778562006; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WfrP/YM0+QiNPfuc4aJ75FAml9M4/b1GGe/ogCrwC90=; b=TS/YzVQ3KQggpsfMRejtSuYZZ4MdWX1978dKyKjVmjBuKAPo5fBzw8L1gASukjooep sCITxThjCXQj2RFkRsB0QzaofpSGu0s4n/qLO4ZCNO3BvnQBfy4Aib8ou/uOraHCyeNT eogFOIAo88vqjXVbeVQl7zg4WV8RZIbNZVKRZmxaOjZzSY36HbdrqZfFVLBlAC1nTPpP UQdbMhXv4+ejW46ya8YJ9QZ/KKXV5lxWRsP97o1YQ1tZdLJNicpTLBXGc15bI7emyn/7 DdLGt3RsShJ21nJJYrZm3CNFCd+UxUHIpEb73Jw5I+JkXI0KBFSvFuJxgil1AwBwcDwq SxCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777957206; x=1778562006; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WfrP/YM0+QiNPfuc4aJ75FAml9M4/b1GGe/ogCrwC90=; b=ip0mqx7yNjichJGoGPsmHZR70YNZ+kwIsF75c3UD88ugYBJvNQHso5b8rQNnUMGysW FrvzDLKWqyFPaU5j4fsl2mw3dXUMdPOUEtWGkGjyFs7g5svBHOYZbBS0SAcrxGoztG9U fIEQqWQUgp4aqpcXOsfCVCiiiYBs7f2v054NjRpMCF/HV8cn0Jb7XJKZESmyPBkp7Gft +YeBxS6i/XvvCpa/d3cApJ+dvCd37r6ttRM9/YCXF0toSNT/Re0Bws79hvRgbgAkRilV PIc7o0Vq5H9DIT8VA9UXfDO7TS+MXWq5bswhoB6wYXWo3IcM9rFQN5iFdbot3UaLiQds Z45Q== X-Forwarded-Encrypted: i=1; AFNElJ+f5nzh80XanP509dQGxCgcFwqP0kPhVXDWZB+9ZIhEYEJPE53H7FlD0tSYobGbFi0k25RhERCHoa6nHX0=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3Dnya41c/2eklQ4Ar83mQ/qpO7Rk+7CPcwN+qNjLNXjc1VhX0 kJtA7pz4yaQShKaLexmy7Xf6tQSdqFWJo6CAZ7DZCHZmkN81QuG2Jp7H X-Gm-Gg: AeBDiesOj2xxeG5R6rQ2IYhBLVVi3g4Yg5jtnZrfBRa+1zQo7AXguxRDG8MD0jTMdTZ aKWOz/BKR0g5BVimFxJwL0JDHEh66e/W7WD3XOEtV3XSLonorF/UVkeyr3Bsi+pBFP0LdayCFKW zrGWiMWz2D2j2+/bYyR0wav1N9SNfRShdLdp00zqEQH4vtGUNzp3fS90leHn6Cvx9RFhuG0Cr6Z ILb8x7xeDbClRYgIif0BmMRECtPNxbKcWU2p1CvjpaPeeC4bbrzRh18K2JegGx4BpEg+kt3EKVo FhnLyk7MEOkLeZXUfufKjUnviy7hIR6PB30+hnoqGwU7/WghUyfGqw43XyF4D1pHpO4XOyiBVvp jGAj2YrycjlUbGFDqFpoF4jgkG4QHHKbeUDQRRXjABz59EyPmmCOkqD45Xg7DRMuUGLzpFKrHsu hGRtAUATD66d48L+gTm30QyjFmnkBx4JUdxInWvBI9gfLUqAg4qG3O8YN6r3wXhf+O3545vd6rM Cf3EMVTOkElS8m0eaZtUErHbXTdGWP6YZnI X-Received: by 2002:a05:7022:404:b0:12d:b7e5:a67b with SMTP id a92af1059eb24-12dfd7ca694mr6147437c88.14.1777957206409; Mon, 04 May 2026 22:00:06 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:94ef:a6f3:2c96:2d58]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12df827a73fsm16897502c88.1.2026.05.04.22.00.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 22:00:05 -0700 (PDT) From: Dmitry Torokhov To: linux-input@vger.kernel.org Cc: Marge Yang , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v2 06/20] Input: rmi4 - iterative IRQ handler Date: Mon, 4 May 2026 21:59:36 -0700 Message-ID: <20260505045952.1570713-6-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.54.0.545.g6539524ca2-goog In-Reply-To: <20260505045952.1570713-1-dmitry.torokhov@gmail.com> References: <20260505045952.1570713-1-dmitry.torokhov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The current IRQ handler uses recursion to drain the attention FIFO, which can lead to stack overflow on deep queues. Convert it to a loop. Fixes: b908d3cd812a ("Input: synaptics-rmi4 - allow to add attention data") Cc: stable@vger.kernel.org Assisted-by: Gemini:gemini-3.1-pro Signed-off-by: Dmitry Torokhov --- drivers/input/rmi4/rmi_driver.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c index d873c7f08e42..c2843c21f0b9 100644 --- a/drivers/input/rmi4/rmi_driver.c +++ b/drivers/input/rmi4/rmi_driver.c @@ -198,24 +198,24 @@ static irqreturn_t rmi_irq_fn(int irq, void *dev_id) struct rmi4_attn_data attn_data = {0}; int ret, count; - count = kfifo_get(&drvdata->attn_fifo, &attn_data); - if (count) { - *(drvdata->irq_status) = attn_data.irq_status; - drvdata->attn_data = attn_data; - } - - ret = rmi_process_interrupt_requests(rmi_dev); - if (ret) - rmi_dbg(RMI_DEBUG_CORE, &rmi_dev->dev, - "Failed to process interrupt request: %d\n", ret); + do { + count = kfifo_get(&drvdata->attn_fifo, &attn_data); + if (count) { + *drvdata->irq_status = attn_data.irq_status; + drvdata->attn_data = attn_data; + } - if (count) { - kfree(attn_data.data); - drvdata->attn_data.data = NULL; - } + ret = rmi_process_interrupt_requests(rmi_dev); + if (ret) + rmi_dbg(RMI_DEBUG_CORE, &rmi_dev->dev, + "Failed to process interrupt request: %d\n", + ret); - if (!kfifo_is_empty(&drvdata->attn_fifo)) - return rmi_irq_fn(irq, dev_id); + if (count) { + kfree(attn_data.data); + drvdata->attn_data.data = NULL; + } + } while (!kfifo_is_empty(&drvdata->attn_fifo)); return IRQ_HANDLED; } -- 2.54.0.545.g6539524ca2-goog