From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22524280035 for ; Tue, 5 May 2026 05:17:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777958279; cv=none; b=ZFNdA62XJ1rOGT1K2XkuRybNxxCNxyS8YJmJfS8PDKObGRSaeLfuJSRzBM8vDbf6+0MBv86gQmp5PBsVP/m9zzBqNC7jzefgdkBzFkQZRAEHGOSVi87QkdArwZXa9wrvpPdKZ5g6KaAgaBlMPoCjjQAtbkf6A/6/V7RZcFj3UH4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777958279; c=relaxed/simple; bh=M2p2S5HBxIwBxbIm5f29AVl39jooJ/7kAn1ac8j7tSM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=Xgc8OV+RvOw9PmOqH+Y05jiH8TS7OhhFEOZGwr4KCc5caHaC5loClOtD5G/3bZWkllNKF7isyFFRfMxd7q3Hv7PLQxVV7iUxUdC2W8DmB6rQmbQ6i+tGT1FfOl+xFLZ6nZlQkHrDZ9TNcWRfw5vCWAGwTEVUpj6fekb2wpy/h2Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DDBYb6WR; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=lC3RTBgq; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DDBYb6WR"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="lC3RTBgq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777958276; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HAr0xbXZbAJ3/GDtKYezys+kB2bNlRlW51R5ZTUaPGw=; b=DDBYb6WRy+yLmCJ1Xe1mkeYIOHx2dTwvI31RJ3ffTtoFPO6VQRj/HvJtDE3ky2JCOi5c5G jwpt79RsQFvnG3hH9KYTpaOg7Bv9g2/821kypnLzKguxz9zKORTWx6OyV8wGGLFL9pqhGi 8Tq6FjT+UzSZSwfC2IiondsnxYtcgSk= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-617-UVYxVaJtPPauxD55J5FBNA-1; Tue, 05 May 2026 01:17:54 -0400 X-MC-Unique: UVYxVaJtPPauxD55J5FBNA-1 X-Mimecast-MFC-AGG-ID: UVYxVaJtPPauxD55J5FBNA_1777958273 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-393adad635dso4231581fa.3 for ; Mon, 04 May 2026 22:17:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1777958273; x=1778563073; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=HAr0xbXZbAJ3/GDtKYezys+kB2bNlRlW51R5ZTUaPGw=; b=lC3RTBgq1JulYQoexg3jdii/5Hvp+u9kLcfLsG0JcV2NFdVHzriEy8UFykR/z8GFUd F8tS87xHv424TWd9u9tm3qlngf1qnrxUr/WCx/44HaH3ftuGd8vGSR6+oNUl2ixyrr48 m0ekQPURooZ/i9+LvWGJu/P5mQVLlxt0Nows85vjuU6FTVY193Iv4COt6d3ZE8PgHZaD Zebc00OgQw9JlJguKpXXTz4PdxDYkET/61DFPAlhPLuaAJNByFJK5aewRwPC393i6vhZ wS1P+hlFKxIsstrJu0iGPC0zVPXGJbIkLild12YgTKTUFKqVGLPLBuxZ7T2dvSLtIMhL gG1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777958273; x=1778563073; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HAr0xbXZbAJ3/GDtKYezys+kB2bNlRlW51R5ZTUaPGw=; b=mzvxjI5FPtMCExCaOTpuVva2X2YEBvSINdFJhDGdUttLtp8b1ID0w02V3E8BdHW0hI xunOgHaX7VNcXIsR11N3otyMpfuIi6e5YJakZmDC74paNA8d4pUSnGco+khPFOLN1mPd g6L43vDBlUicfk/AC/XfpF64aABE/uDOOicGuBL5b7rTYR9GNs4v6DiCbIhcCF5cXA3B O7rx3zoC9opj6oCk4yTxKyDeTI89WmjNYg83IrdjmpCW18feFlvPYhUifwMMwMn22QZw S90STQY5yMm3i5yBXDKkwSIgdMDUkr4jCvCJafmAp9vW0dxtyPuD+n8rAXnB86RXcu0j 0FWQ== X-Forwarded-Encrypted: i=1; AFNElJ/b45U3NThYkk2MF9UoCZFnBgwaDU50Evzu67JKMpL40RPyh7JJ8z0Bz2qqTUqZcbmKWf4OlSwch+kkA60=@vger.kernel.org X-Gm-Message-State: AOJu0YyuEj9c/dBpildmD2/dK0iSyV+doPPj4pUKL0ZPd3fJywRqHQge Lj7Fy5cIEbZnxdBr/9X3Y6oLkhoUSPX59CORUTQULRUn9/a3u01uzuZfQTC5cN8lEmnQdYmPz7O ITNMnWft4ovseo3QP6YDrwhNklUv4PvQ9irBadt5OvTqwEgVFm8EHlN6PA0+4ydsJ X-Gm-Gg: AeBDies+2Tgtv3UH+jgmuuL6kkV92D4ghGKuRJ0Yt48vjoACR6By6MEpX2dJ0jv9Etc yAA5upNfUtpNsIvLOLOCPrkKeuaNIxA+4WlIHOX9OoPaG61n3xpBN1ufCe32VfdQxmXfi0Ca7ok Q4DO9JciQkRjmdWesr7JbCS8AsVjMKb3rvyeXh4XiLhYwIjgK3ixeYwlydPoA8fnQyYOPqRb1qI /DzuXe2fSRmU1/An+o9IOXNAmbSmjjMdv0FvmhITIMTAN8c+hnU5TMdjfQYLCnBJEYCht00tOOF zYEyV/Gm0Jf336QOQKcS0UyrFIHek+H2FTBgZxQGTV+WFPxXKGJZL1EUKEhGB27HhV8rlGfnaa7 cPM4JU2Vs5LFX93TRJNH12ZUUZk0ZH85c4A+1XrnH1RFhA3j5ZdFt6wT5Fg== X-Received: by 2002:a2e:ab19:0:b0:38e:2fcc:78fe with SMTP id 38308e7fff4ca-393783c5ceemr56487261fa.3.1777958273032; Mon, 04 May 2026 22:17:53 -0700 (PDT) X-Received: by 2002:a2e:ab19:0:b0:38e:2fcc:78fe with SMTP id 38308e7fff4ca-393783c5ceemr56487031fa.3.1777958272465; Mon, 04 May 2026 22:17:52 -0700 (PDT) Received: from fedora (85-23-51-1.bb.dnainternet.fi. [85.23.51.1]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3936138935fsm37206141fa.41.2026.05.04.22.17.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 22:17:51 -0700 (PDT) From: mpenttil@redhat.com To: linux-mm@kvack.org Cc: dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Mika=20Penttil=C3=A4?= , David Hildenbrand , Jason Gunthorpe , Leon Romanovsky , Alistair Popple , Balbir Singh , Zi Yan , Matthew Brost , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko Subject: [PATCH v9 0/5] Migrate on fault for device pages Date: Tue, 5 May 2026 08:16:53 +0300 Message-ID: <20260505051658.2219537-1-mpenttil@redhat.com> X-Mailer: git-send-email 2.50.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Mika Penttilä Currently, the way device page faulting and migration works is not optimal, if you want to do both fault handling and migration at once. Being able to migrate not present pages (or pages mapped with incorrect permissions, eg. COW) to the GPU requires doing either of the following sequences: 1. hmm_range_fault() - fault in non-present pages with correct permissions, etc. 2. migrate_vma_*() - migrate the pages Or: 1. migrate_vma_*() - migrate present pages 2. If non-present pages detected by migrate_vma_*(): a) call hmm_range_fault() to fault pages in b) call migrate_vma_*() again to migrate now present pages The problem with the first sequence is that you always have to do two page walks even when most of the time the pages are present or zero page mappings so the common case takes a performance hit. The second sequence is better for the common case, but far worse if pages aren't present because now you have to walk the page tables three times (once to find the page is not present, once so hmm_range_fault() can find a non-present page to fault in and once again to setup the migration). It is also tricky to code correctly. One page table walk could costs over 1000 cpu cycles on X86-64, which is a significant hit. We should be able to walk the page table once, faulting pages in as required and replacing them with migration entries if requested. Add a new flag to HMM APIs, HMM_PFN_REQ_MIGRATE, which tells to prepare for migration also during fault handling. Also, for the migrate_vma_setup() call paths, a flag, MIGRATE_VMA_FAULT, is added to tell to add fault handling to migrate. One extra benefit of migrating with hmm_range_fault() path is the migrate_vma.vma gets populated, so no need to retrieve that separataly. Tested in X86-64 VM with HMM test device, passing the selftests. For performance, the migrate throughput tests from the selftests show similar numbers (within error margin) as unmodified kernel. Tested also rebased on the "Remove device private pages from physical address space" series: https://lore.kernel.org/linux-mm/20260130111050.53670-1-jniethe@nvidia.com/ plus a small patch to adjust with no problems. Changes v8-v9 - rebase on drm-tip - fixed uaf around migrate_vma_split_folio() usage - added missing pmd unlock Changes v7-v8 - rebase on 7.0 - fixed subject in two patches - enhanced commit messages - squashed patch 6 into patch 4 to fix kernel test robot warning - readded dropped Cc block from cover letter - fixed white space Changes v6-v7 - rebase on 7.0.0-rc6 - added documentation and comments - denote to be migrated zero page as HMM_PFN_MIGRATE alone - got rid of HMM_PFN_INOUT_FLAGS movement in patch 2 - picked up Acked-By from David for patch 1 Changes v5-v6 - rebase on 7.0.0-rc4 - use range based TLB flushing while unmapping ptes - gate migration behind HMM_PFN_REQ_MIGRATE for fault and migrate paths - always infer migration flags from migrate->flags only Changes v4-v5 - rebase on 6.19 - fixed David's email address - fixed link issue without CONFIG_TRANSPARENT_HUGEPAGE - refactored into smaller commits - added more comments to code Changes v3-v4: - rebase on 6.19-rc8 - fixed issues found by kernel test robot with random configs - fixed typos Changes v2-v3: - rebase on 6.19-rc7 - fixed issues found by kernel test robot - fixed smatch issues reported by Dan Carpenter - fixes to lock handling (pmd/pte) on errors - added assertions for pmd/pte lock states - other issues discovered by Matthew, thanks! Changes v1-v2: - rebase on 6.19-rc6 - fixed issues found by kernel test robot - fixed locking (pmd/ptl) to cover handle_ and prepare_ regions parts if migrating - other issues discovered by Matthew, thanks! Changes RFC-v1: - rebase on 6.19-rc5 - adjust for the device THP - changes from feedback Revisions: - RFC https://lore.kernel.org/linux-mm/20250814072045.3637192-1-mpenttil@redhat.com/ - v1: https://lore.kernel.org/all/20260114091923.3950465-1-mpenttil@redhat.com/ - v2: https://lore.kernel.org/all/20260119112502.645059-1-mpenttil@redhat.com/ - v3: https://lore.kernel.org/all/20260126111939.1332983-2-mpenttil@redhat.com/ - v4: https://lore.kernel.org/all/20260202112622.2104213-1-mpenttil@redhat.com/ - v5: https://lore.kernel.org/linux-mm/20260211081301.2940672-1-mpenttil@redhat.com/ - v6: https://lore.kernel.org/linux-mm/20260316062407.3354636-1-mpenttil@redhat.com/ - v7: https://lore.kernel.org/linux-mm/20260330115611.347988-1-mpenttil@redhat.com/ - v8: https://lore.kernel.org/linux-mm/20260414041226.1539439-1-mpenttil@redhat.com/ Cc: David Hildenbrand Cc: Jason Gunthorpe Cc: Leon Romanovsky Cc: Alistair Popple Cc: Balbir Singh Cc: Zi Yan Cc: Matthew Brost Cc: Andrew Morton Cc: Lorenzo Stoakes Cc: "Liam R. Howlett" Cc: Vlastimil Babka Cc: Mike Rapoport Cc: Suren Baghdasaryan Cc: Michal Hocko Mika Penttilä (5): mm/Kconfig: changes for migrate on fault for device pages mm: Add helper to convert HMM pfn to migrate pfn mm/hmm: do the plumbing for HMM to participate in migration mm: setup device page migration in HMM pagewalk lib/test_hmm:: add a new testcase for the migrate on fault include/linux/hmm.h | 19 +- include/linux/migrate.h | 26 +- lib/test_hmm.c | 101 ++- lib/test_hmm_uapi.h | 19 +- mm/Kconfig | 2 + mm/hmm.c | 835 +++++++++++++++++++++++-- mm/migrate_device.c | 583 +++-------------- tools/testing/selftests/mm/hmm-tests.c | 54 ++ 8 files changed, 1066 insertions(+), 573 deletions(-) drm-tip base-commit: 94d56a898a2db27f841b17f6966a81ba502fe63c -- 2.50.0