From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 766DB30E82C for ; Tue, 5 May 2026 09:02:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777971776; cv=none; b=m6F+bokOLOw4NGdNtUPmoej7p22yxz1p3ogDYORpkwMbEXED4f9qOZuOUdxNX+4m1qC+e2H8Ye4MoSwEcdIjPnfxwuIgfL2RaBpGW2H454ZX0AkEuHWBIPI9JTlWNR9zhEVJrRdpQZtu9fYI46mrsk8EGszdL6pvog2quZDF/dY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777971776; c=relaxed/simple; bh=lsMotbbmjRTSAnTSuiqgbvDO+1BFLTUtvyaJVAE3KZM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LPXuddZcUUMTvAyrKf8HKDRY3Wjq74xrNJG3k7Dm4X8w+VXbaIi19NHE2d1NcRAk+SKcMtoOsP3bNu23QXrkCoeiX48bciZd8SbFk570U+VqywYkpPG4t6oa33/igPp42MdpfUnaFnBh4qZ54aArDaW5aCrrTt8MdAGxzoM3BaU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nijqaXE8; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nijqaXE8" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-ba7a1cc0380so843553066b.2 for ; Tue, 05 May 2026 02:02:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777971774; x=1778576574; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ccyLV26D7zYbN2fFdWu3DrAeub8S6U6KL3Fci4tQRyM=; b=nijqaXE8f7ezdGzhmHsnxFcgQcc8UybgzEaLcHzoeOOSk+2CiBAKja46vXq0ManSVR EEHrNc7oUXJlFEviUq8wNX8815AkvFpHtiHkm82VAXZHQEo4itGu38XiPvfh5sqvbiyW ZaQk0c/ALNgM+AmWwZYkmacFSimb/KP3BVtBJS8fZTlEw/5zzrXzhkWCyNHg64dDllJE 09kPCgTXnUqjfP/rD3/lSpjm9ZnIqT6GCaluZU0i08y4/Y2XedS6vQCxixnvOkaZEHNc NqAoxboyexI4GRlSeRSC+IlBWrBl7qrbc37btMyieEAWef3MAleV5lAzAwAwh2+o/5WH 6LTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777971774; x=1778576574; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ccyLV26D7zYbN2fFdWu3DrAeub8S6U6KL3Fci4tQRyM=; b=OnTBYXxuexSqyNTfiIYDXao5DfcERkAW5Pwhol+86LUtpmTVjiJOag87p4d7A0cN2J v8mB0iWcfTyr926aR9aaB/W6pj3TD+w6xpmir3aX7OQKv2cyB2iS/Vx97SvLVsQAx8MH nm3X55hnFMSp4CMzES4IflwU9oY8qTvybmU1rPOVui5E9+tVfg9bg1JEZxXGeCAp1aib TOtZjzzPCXGMs8Xg0PzR40Mmj8Jhg22LmpakCOAE9I3SnMJKy+eyg0NFSo/TQghflvIk Lms9q4jJQ0Rdu6IRYfrn6XiG7Ao5BoRrzeSJwuzNXpPsSvzmdkCE4ztQNEQquyQzddks DSFg== X-Forwarded-Encrypted: i=1; AFNElJ9UzA+kdEMYvihFIkXzAMS6K/DXe+1q5T8uJBfuUT8H97HKD6LI5OeJd6HKp/USRFIfose+QlnElc7e0Mo=@vger.kernel.org X-Gm-Message-State: AOJu0YxtooOp45hAqI4zvyMJqCQH8SxAVNZfMVL4Zs+w+bgYFmqc43dU wS1UH6onjnfPnGYhwPPJ52Nx1BX6UBMlBRsPTGumsN2RUm8L6YuhaWbT X-Gm-Gg: AeBDietWkIZR9CtEWqk1+4ijrorLzlDDTnRvZERWC0oSRdyQGFEzNXbf8nXEcNrk4Y0 AINy82QX1SVIVOALuMFL7+MtlphvjvirrTgP27407umI/t9fS7nN5YQKq0FR3abjIj3UiXpC88D zfEEyKEMQKn76nczIUinc2sqhjdUtW/I/TogXTUscVlTUwv8ZP7BZQcTSAvqL1cCUscvdlcBErh a7mMOxZ2vZ6OGZLMHRI2yBOQNNQJsg9YNlIHF96OYdPLgWszPfPt1w0u13vNdVbQLMmRTLswZIw zwVAySKOLaUDWGe9jib3S2d2B7CxK0EOIQehc6uG9G/HUdqOPm0AaBNXDO9T+NAkazjMN+tg2r4 D5gnyQQwrYTyo998X04tGSJqOOwd8hPnqnT7jb4pnEbqcxYBeTgql4duMfImtgPPLaBB8QjZ0TC cSzIpdSK4iwZCyDrftTqAvA+2iuLhKW31utxaEU79cqzjZuD48 X-Received: by 2002:a17:907:74c:b0:bc2:d65b:5a9c with SMTP id a640c23a62f3a-bc40f43878emr102409066b.1.1777971773370; Tue, 05 May 2026 02:02:53 -0700 (PDT) Received: from localhost.localdomain ([196.235.252.38]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bc1dd343108sm216136366b.63.2026.05.05.02.02.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 02:02:52 -0700 (PDT) From: Salah Triki To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Salah Triki Subject: [PATCH] iio: humidity: ens210: Fix missing I2C functionality checks Date: Tue, 5 May 2026 10:02:47 +0100 Message-ID: <20260505090247.74555-1-salah.triki@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The ENS210 driver uses both `i2c_smbus_read_byte_data()` and `i2c_smbus_read_word_data()` during the read and probe phases. However, `i2c_check_functionality()` was only checking for block reads and simple byte writes, which could lead to hardware interface incompatibilities or errors on certain adapters that do not natively support SMBus word or byte data transactions. Add `I2C_FUNC_SMBUS_READ_BYTE_DATA` and `I2C_FUNC_SMBUS_READ_WORD_DATA` to the functionality check mask to ensure the adapter supports the required operations before communication begins. Fixes: c524fbca672e ("iio: humidity: Add support for ENS210") Signed-off-by: Salah Triki --- drivers/iio/humidity/ens210.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/iio/humidity/ens210.c b/drivers/iio/humidity/ens210.c index 77418d97f30d..e8633f247b10 100644 --- a/drivers/iio/humidity/ens210.c +++ b/drivers/iio/humidity/ens210.c @@ -204,6 +204,8 @@ static int ens210_probe(struct i2c_client *client) if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_WRITE_BYTE_DATA | I2C_FUNC_SMBUS_WRITE_BYTE | + I2C_FUNC_SMBUS_READ_BYTE_DATA | + I2C_FUNC_SMBUS_READ_WORD_DATA | I2C_FUNC_SMBUS_READ_I2C_BLOCK)) { return dev_err_probe(&client->dev, -EOPNOTSUPP, "adapter does not support some i2c transactions\n"); -- 2.43.0