From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Miao Li <limiao870622@163.com>,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
waqar.hameed@axis.com, dixitparmar19@gmail.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Miao Li <limiao@kylinos.cn>
Subject: Re: [PATCH v4 3/3] iio: light: stk3310: Use sizeof() for regmap_bulk_read/write count parameter
Date: Tue, 5 May 2026 10:29:17 +0100 [thread overview]
Message-ID: <20260505102917.2b49fb53@jic23-huawei> (raw)
In-Reply-To: <afmTBZSUpVrS5AP0@ashevche-desk.local>
On Tue, 5 May 2026 09:49:41 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Mon, May 04, 2026 at 11:04:08AM +0800, Miao Li wrote:
>
> > Convert the hardcoded count parameter to sizeof(buf) for all
> > regmap_bulk_write() and regmap_bulk_read() calls in this driver
> > to improve code maintainability. For details, see [1].
>
> > [1] https://lore.kernel.org/all/20260428192213.7c5c80e5@jic23-huawei/
> >
>
> Make these two lines a formal Link tag,
>
> Link: $URL [1]
>
> Perhaps even Suggested-by tag is also good to add.
Tweaked this and the previous as suggested + added tag to previous.
Thanks,
J
>
> > Signed-off-by: Miao Li <limiao@kylinos.cn>
>
prev parent reply other threads:[~2026-05-05 9:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 3:04 [PATCH v4 0/3] iio: light: stk3310: Fix PS interrupt after suspend and clean up code style Miao Li
2026-05-04 3:04 ` [PATCH v4 1/3] iio: light: stk3310: Deal with the ps interrupt issue in PM Miao Li
2026-05-04 15:34 ` Jonathan Cameron
2026-05-05 6:53 ` Andy Shevchenko
2026-05-04 3:04 ` [PATCH v4 2/3] iio: light: stk3310: Replace uint32_t with u32 and reorder members to eliminate padding Miao Li
2026-05-04 8:19 ` Joshua Crofts
2026-05-05 6:51 ` Andy Shevchenko
2026-05-04 3:04 ` [PATCH v4 3/3] iio: light: stk3310: Use sizeof() for regmap_bulk_read/write count parameter Miao Li
2026-05-04 7:11 ` Joshua Crofts
2026-05-05 6:49 ` Andy Shevchenko
2026-05-05 9:29 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260505102917.2b49fb53@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dixitparmar19@gmail.com \
--cc=dlechner@baylibre.com \
--cc=limiao870622@163.com \
--cc=limiao@kylinos.cn \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=waqar.hameed@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox