From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 188CB385515 for ; Tue, 5 May 2026 12:55:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777985728; cv=none; b=YE+ScHYDSPo9qQkdd5gJa8rbHg9T8RusE751f7k16yKsXAN03zMMWenUKdsU1e3zTyineGqIgLZUpo7pA6aFyhcvjs93zPZgJY4/dfsdA9FG38O+6roA01T5Ds/vXpcTJmfca0WI8kS15fGisaE7P5TE95LkcquQaBHZTMDkNCo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777985728; c=relaxed/simple; bh=2Mc4aSMIAqOw0l+lElctDzVew37Q4lCYJ6BeliNJIHU=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=dZM3ycbzB1Q+KPxaCoKHxue7nD4OhxFZePM2MdbRKuyyjF33vvHG7PveY5RuXW/Urc5bbtFxsimbzPF/nr49cOAH95m5tvGR7WFSjRPQVn9ggf91HNUGbDpCcq+CVDb32Ee3NHydwkvhKor8GnsC5QEjXux/SjYo5ySbf5NoUU0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=n/xZDrhF; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n/xZDrhF" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2ad617d5b80so31156855ad.1 for ; Tue, 05 May 2026 05:55:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777985725; x=1778590525; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=O+1kudbJjsIZWx5ktJq6nZJOu+l9qVFRwHZqcHLY8EQ=; b=n/xZDrhFvZs+2ZoL3B7PE9BOZb3oU66VmU9M7yV2EiMutRH0AbtTE/r2GWoMyAlrAW 12H04E2J7XFXYzrHEUygNmwFcUMIHrbqguiU2SzkuAftMlQ6fqdfjfCpDQNcIGvrEDbA bAAnxO7KJm6yzfct54Iv9vvGSbXKN91lUleh3mqdRz893hUYeONXC8jT7HzdTMjmNLbn ei39IxuoiFZUXvCTnGdchsD4xGBm03ol+65X1lkpn/VU6O6iz7NuHWh3oP8vBHyq996s ERL1dyVU3JURcYP86UpWX06Qzmc4/mPSFfbsnNQctrv+fOtEZIxBJAEl6jRD7h3oX953 KgsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777985725; x=1778590525; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=O+1kudbJjsIZWx5ktJq6nZJOu+l9qVFRwHZqcHLY8EQ=; b=di/loR0pccpeOn679JDKyaz4JdaD8XvBGBvb7WKne0u73DaksX8LcwyWSqwyREUgZ0 7c+Ut+2yvjHKVPZGgyYWmjKxcYoz5Q1FKOdJzVNTIR87SbUPqkBTkBOebzIN6eNYuQFm U6FebK+eQsd0SCx1+ZcUH8RQ7QvfsdxdOAE7LCqqbmJH3rO0add6rYPO13mWsPbyD5J1 8fu2WBaepyKLTI1xQBpa+qbXuy9BfBNJ6xatxc+BS6+sfltGX7KU2f4djhWAUGuvhSiA KIItibdhZlzirl7aDmwAhFwWgC4WBzS1ywiZdXr01WwZyilRlyjcebS3bDNp7ipVL2Pw 6Mzg== X-Forwarded-Encrypted: i=1; AFNElJ80LudFJ6fjW7Kr9GddmFRMXMmA+M4JzwQjBzVGzbNO0RqYTCz5s/orUYlOWRcCM7RYdxwbul8idJzy8VU=@vger.kernel.org X-Gm-Message-State: AOJu0YxZzkDcoE8Ik9lzHN32BPqqMQIMt9FFA77s5la6kFHiiAG3x4AM LFZNt6/i2Ya9LFtHb06qMye5FCX13eh9cBBLquiAQ07zqhXPdYe0zDww X-Gm-Gg: AeBDieu6Ab9RPKBEf+icwd+VNKNL/DKdr61Sm1PZ4aw2cQSCz0Ceta2Z/9WLGBr5g4U CAcnSWHHvFrn84ywJCK+D99lkrViDsz/zmkNt1HJReKNZ7w4ackw7K4YkttCnyY1pi075UEE5RZ paPU30QZ9DmAAC4jJkOrBvPhLaQIRCEiB9Jgq4j62JWXhEccKTRiidpL9o95PT4YNM4ORhnnz0s i6hnceCfl1h8wYmMeVKBf8jQkjPNk/vXjiWLn3qcL1Mg7o2wCa1If8exzOAcFIyVFM6nNu/etfE z/14B3U+V/igHiIjvhddPkrFL2iLR3t3AFC+GSCeB2/98LX2jwkEu9+lXxPvN1Of/XcQh+m+uD9 zcpXwukWD5/FP2LDlbc+An54S9XsS4J57C/AB3MJicMoLeGL+nnowfw4dI2sr8oNR5D1OvzTzhe zKwxz8hSlUesYLUxEfBjW1PR6Y6IoG X-Received: by 2002:a17:903:1ab0:b0:2ba:1202:4fa8 with SMTP id d9443c01a7336-2ba1202518emr95899755ad.20.1777985725288; Tue, 05 May 2026 05:55:25 -0700 (PDT) Received: from localhost ([111.228.63.84]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b9caad2bd7sm158423855ad.36.2026.05.05.05.55.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 05:55:24 -0700 (PDT) From: Cen Zhang To: jaegeuk@kernel.org, chao@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, baijiaju1990@gmail.com, Cen Zhang Subject: [PATCH] f2fs: annotate lockless NAT counter reads Date: Tue, 5 May 2026 20:55:10 +0800 Message-Id: <20260505125510.1369132-1-zzzccc427@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit nat_cnt[] is updated while callers hold nat_tree_lock, but F2FS samples the counters locklessly in f2fs_available_free_memory(), excess_dirty_nats(), and excess_cached_nats(). Those helpers only steer cache reclaim and background sync heuristics; they do not control NAT entry lifetime or checkpoint correctness. Document the intent with data_race(READ_ONCE()) and a short comment instead of adding locking to the balance path. Signed-off-by: Cen Zhang --- fs/f2fs/node.c | 6 +++++- fs/f2fs/node.h | 8 ++++++-- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index 74992fd9c9b6..8318c747600d 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -72,7 +72,11 @@ bool f2fs_available_free_memory(struct f2fs_sb_info *sbi, int type) sizeof(struct free_nid)) >> PAGE_SHIFT; res = mem_size < ((avail_ram * nm_i->ram_thresh / 100) >> 2); } else if (type == NAT_ENTRIES) { - mem_size = (nm_i->nat_cnt[TOTAL_NAT] * + /* + * nat_cnt[] is heuristic accounting. Sample it locklessly here + * to avoid taking nat_tree_lock in the balance path. + */ + mem_size = (data_race(READ_ONCE(nm_i->nat_cnt[TOTAL_NAT])) * sizeof(struct nat_entry)) >> PAGE_SHIFT; res = mem_size < ((avail_ram * nm_i->ram_thresh / 100) >> 2); if (excess_cached_nats(sbi)) diff --git a/fs/f2fs/node.h b/fs/f2fs/node.h index 824ac9f0e6e4..c1aa41b31d66 100644 --- a/fs/f2fs/node.h +++ b/fs/f2fs/node.h @@ -129,13 +129,17 @@ static inline void raw_nat_from_node_info(struct f2fs_nat_entry *raw_ne, static inline bool excess_dirty_nats(struct f2fs_sb_info *sbi) { - return NM_I(sbi)->nat_cnt[DIRTY_NAT] >= NM_I(sbi)->max_nid * + /* nat_cnt[] is heuristic accounting sampled locklessly here. */ + return data_race(READ_ONCE(NM_I(sbi)->nat_cnt[DIRTY_NAT])) >= + NM_I(sbi)->max_nid * NM_I(sbi)->dirty_nats_ratio / 100; } static inline bool excess_cached_nats(struct f2fs_sb_info *sbi) { - return NM_I(sbi)->nat_cnt[TOTAL_NAT] >= DEF_NAT_CACHE_THRESHOLD; + /* nat_cnt[] is heuristic accounting sampled locklessly here. */ + return data_race(READ_ONCE(NM_I(sbi)->nat_cnt[TOTAL_NAT])) >= + DEF_NAT_CACHE_THRESHOLD; } enum mem_type { -- 2.43.0