From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D33FC3EF0D2 for ; Tue, 5 May 2026 13:47:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777988840; cv=none; b=MWfSX3spxarlPXwuyNfmm0jyGTQNgS9/MKT8gAqHu5EM/PU8XLX7e0nM63VtDbM1mMPzZMfd5kYEHFvio+FYxEJs8BNza2zHS1yLTTQTqLsx2XBJrcHFCWMPDVz0HVRSwp2oqYbMDMtSsS5OMRT4JpGu90pdB+kmFpUgtO0PRM4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777988840; c=relaxed/simple; bh=T1nYSoC/rhLLKKZCwm+PKabQcoZDmbpRIloWfV/g36o=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=cXBX4ymiLPjbcpWFWFdr2XH5yjBJVhGZVwF2ypeCm4Y9jBLVU0TTw/LIgYH0pKH0mF/uNEki/muLybPp3ECFWcKQt4eyYB3xqUTK79ndP+gwKkJQXZYQjCJlpWhnirCQsfOV4cSrTDnNaIy/Nw/2KBITCYdhRgsM22Ub5uD0F7k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jq9xI3+E; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jq9xI3+E" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-43d77f60944so3414795f8f.3 for ; Tue, 05 May 2026 06:47:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777988836; x=1778593636; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WngZ1i7b+AeASB3S8rstycFmmHOgCBJxwXtpf2QN6jA=; b=jq9xI3+ErPS8bCruMti4o4fdOfGXni9RgF2h8h5queIGLYvGBjg4C1zyXBuuo8vn6K GGsVXPxuKlIivrVcP81WRRtw6+Zdu7GAuvlUZdsRLLxCiq1WDdwKf/XcIDBBJHFvd5v5 teNRKJspdM8f2ZmGXX61+2B+GDTWTo1Vot7VReuAAXlTFTsgh2/y+iJAEjFWsI+LREEq BsIF8TCQCRAc1H2QPfYvuqlf5PQVqhigqxnsSpKODSJWEe6lHCg2tFoAp5ZDyFzsYhrR TuNls9AtQ3NvEhGdKLVeDxl8tlU+OgiqHMzM1tldTTsjrqK30tT1M9y3xycrqbNllVYb MV0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777988836; x=1778593636; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WngZ1i7b+AeASB3S8rstycFmmHOgCBJxwXtpf2QN6jA=; b=O/yXbyxUAMZVRpD14PRjVWT1rlgvoHDfkL2fNgmZ4cepQvLnM0S4DvfIkLRIOnfh4k s41YseVJByVtJdPbC/S5Bz+v9aGi4OYqQcBMlGBcdFoC4lbM+C8/iDKYdcSkiKZ1DpY1 whtIN5JHGO2hEWYhlY14Ib7D4GAgFFKbwjT1f3SuQGQOt//9uy3zI0JRt428/DHyaQJU v3zTJap6Ig/dJknDOi/S+VNh9ILfp2qAM9l4XCZNc3cfr5DY+F07AqNqpYqJHSszarMA 1QpExRgGyHYWh4mYNhlgIdPG9a53iK62pYKPrAaLXM75JsbFJwHVl/Uv+BEK3ar/4nGG sncw== X-Forwarded-Encrypted: i=1; AFNElJ/m2RolKiPDvTtgtlEw/0vAM0xFLN7g7H0kNn6PjaVV8J1a8UOza2/0fHX+5+DlBk0cMpvKIDmuuBARjkI=@vger.kernel.org X-Gm-Message-State: AOJu0YwGhnjBygFdpEmDEq6S9Wk7dVF3eJxg5L39fMTloATzk0NhnmjN oE0wUVkuoTjUkEPH8nJmWjoyt5nIH1m9TCzp/ehbzpzzfb4T41YmK5KN X-Gm-Gg: AeBDieuyI37tFirSc5t3aNmAo3CzONxFKhVjGfr7yHYKaOLXFlbCuFkZ4wNJywd+h5V XqxMVnfaLGE4MuhaLazS78Cd+ONcpZIOncI8IfV/OsCcrx5aJo3DczAmSyrwhECYkoxGj64zgph ENb/PElrS0z8o04VGVC19oiHEDXZDoII4+f0K7VfRzrvePZ+vaKD7seRHqT2yz5TqdxVyLuNGMm d5iKXURdSaW5IzTfHgiHPolyK2jwHMaVjKUd9LiFjOoi/CbOYF6f937Is28/8gtTE26Wmx92ixM eRc1Oanp1gW4DtCslvBYPPYwX9jT7i8LixDy5oUTlqokZg3jt7S0Jv9RKuHXTKtCFWLvAXXgyuB zn7/IUZ9O1fHURWEi10/kkV251CbjpBUsmtwHP6OV2Xx729zfjCC+Gp+PTDHbAhAnbEteGF7/9Y oLGNHV6D4kcZnPN99y+5INsAdHGqBHzoRrUq0W2mihDxSKVD7dDKmI X-Received: by 2002:a05:600c:859a:b0:48a:525b:e157 with SMTP id 5b1f17b1804b1-48a9865f870mr168311235e9.13.1777988835944; Tue, 05 May 2026 06:47:15 -0700 (PDT) Received: from vitor-nb (dsl-113-208.bl27.telepac.pt. [176.79.113.208]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a8eb694fcsm375814145e9.3.2026.05.05.06.47.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 06:47:15 -0700 (PDT) From: Vitor Soares To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Vitor Soares , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Tomi Valkeinen , Luca Ceresoli , stable@vger.kernel.org Subject: [PATCH v5] drm/bridge: cdns-dsi: Replace deprecated UNIVERSAL_DEV_PM_OPS() Date: Tue, 5 May 2026 14:47:05 +0100 Message-ID: <20260505134705.188661-2-ivitro@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Vitor Soares The deprecated UNIVERSAL_DEV_PM_OPS() macro uses the provided callbacks for both runtime PM and system sleep. This causes the DSI clocks to be disabled twice: once during runtime suspend and again during system suspend, resulting in a WARN message from the clock framework when attempting to disable already-disabled clocks. [ 84.384540] clk:231:5 already disabled [ 84.388314] WARNING: CPU: 2 PID: 531 at /drivers/clk/clk.c:1181 clk_core_disable+0xa4/0xac ... [ 84.579183] Call trace: [ 84.581624] clk_core_disable+0xa4/0xac [ 84.585457] clk_disable+0x30/0x4c [ 84.588857] cdns_dsi_suspend+0x20/0x58 [cdns_dsi] [ 84.593651] pm_generic_suspend+0x2c/0x44 [ 84.597661] ti_sci_pd_suspend+0xbc/0x15c [ 84.601670] dpm_run_callback+0x8c/0x14c [ 84.605588] __device_suspend+0x1a0/0x56c [ 84.609594] dpm_suspend+0x17c/0x21c [ 84.613165] dpm_suspend_start+0xa0/0xa8 [ 84.617083] suspend_devices_and_enter+0x12c/0x634 [ 84.621872] pm_suspend+0x1fc/0x368 To address this issue, replace UNIVERSAL_DEV_PM_OPS() with RUNTIME_PM_OPS(). Bridge and panel drivers should only deal with runtime PM, as the DRM framework manages system-wide power transitions through the bridge enable() and disable() hooks. Link: https://lore.kernel.org/all/fbde0659-78f3-46e4-98cf-d832f765a18b@ideasonboard.com/ Cc: stable@vger.kernel.org # 6.1.x Fixes: e19233955d9e ("drm/bridge: Add Cadence DSI driver") Reviewed-by: Tomi Valkeinen Signed-off-by: Vitor Soares --- v4 -> v5 - Fix commit message to use RUNTIME_PM_OPS() instead of SET_RUNTIME_PM_OPS() - Explain that bridge and panel drivers should only deal with runtime PM v3 -> v4 - Add Reviewed-by from Tomi Valkeinen - Rebase on top of drm-misc-fixes - Verified issue still present on the current mainline v2 -> v3 - Fix warning: 'cdns_dsi_suspend' defined but not used [-Wunused-function] - Fix warning: 'cdns_dsi_resume' defined but not used [-Wunused-function] v1 -> v2 - Rely only on SET_RUNTIME_PM_OPS() for the PM. drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c index 0dd85e26248c..e07a9892df4e 100644 --- a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c +++ b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c @@ -1230,7 +1230,7 @@ static const struct mipi_dsi_host_ops cdns_dsi_ops = { .transfer = cdns_dsi_transfer, }; -static int __maybe_unused cdns_dsi_resume(struct device *dev) +static int cdns_dsi_resume(struct device *dev) { struct cdns_dsi *dsi = dev_get_drvdata(dev); @@ -1241,7 +1241,7 @@ static int __maybe_unused cdns_dsi_resume(struct device *dev) return 0; } -static int __maybe_unused cdns_dsi_suspend(struct device *dev) +static int cdns_dsi_suspend(struct device *dev) { struct cdns_dsi *dsi = dev_get_drvdata(dev); @@ -1251,8 +1251,9 @@ static int __maybe_unused cdns_dsi_suspend(struct device *dev) return 0; } -static UNIVERSAL_DEV_PM_OPS(cdns_dsi_pm_ops, cdns_dsi_suspend, cdns_dsi_resume, - NULL); +static const struct dev_pm_ops cdns_dsi_pm_ops = { + RUNTIME_PM_OPS(cdns_dsi_suspend, cdns_dsi_resume, NULL) +}; static int cdns_dsi_drm_probe(struct platform_device *pdev) { @@ -1399,7 +1400,7 @@ static struct platform_driver cdns_dsi_platform_driver = { .driver = { .name = "cdns-dsi", .of_match_table = cdns_dsi_of_match, - .pm = &cdns_dsi_pm_ops, + .pm = pm_ptr(&cdns_dsi_pm_ops), }, }; module_platform_driver(cdns_dsi_platform_driver); -- 2.53.0