public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Marco Elver <elver@google.com>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
	Will Deacon <will@kernel.org>, Boqun Feng <boqun@kernel.org>,
	Clark Williams <clrkwllms@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Joel Granados <joel.granados@kernel.org>,
	Alexei Starovoitov <ast@kernel.org>,
	Vlastimil Babka <vbabka@kernel.org>
Subject: Re: [PATCH v2] locking/rtmutex: Annotate API and implementation
Date: Tue, 5 May 2026 16:03:53 +0200	[thread overview]
Message-ID: <20260505140353.KoacwFc_@linutronix.de> (raw)
In-Reply-To: <eab30abf-9579-4d70-8a3c-1ac8902e3023@acm.org>

On 2026-05-05 09:50:11 [+0200], Bart Van Assche wrote:
> 
> On 5/5/26 9:32 AM, Sebastian Andrzej Siewior wrote:
> > I see. I don't know why CONTEXT_ANALYSIS_rtmutex was skipped. Was this
> > just a regular compile with newer clang or was there more to it? I do
> > remember clang was not complaining but then context-analysis flag was
> > missing…
> 
> Hi Sebastian,

Hi Bart,

> This was noticed by enabling CONFIG_WARN_CONTEXT_ANALYSIS_ALL=n. I'm not
> sure why this was not noticed earlier. Maybe as the result of an
> oversight?

I have here clang-22 and make with CONFIG_WARN_CONTEXT_ANALYSIS_ALL=n
and CONFIG_WARN_CONTEXT_ANALYSIS=y. I don't see any warning without your
patch during "make kernel/locking/".

The change
	CONTEXT_ANALYSIS_rtmutex.o := y

is not needed because rtmutex.o is not compiled on its own:
| $ git grep "rtmutex\.c" kernel/locking/
| kernel/locking/rtmutex_api.c:#include "rtmutex.c"
| kernel/locking/rwsem.c:#include "rtmutex.c"
| kernel/locking/spinlock_rt.c:#include "rtmutex.c"
| kernel/locking/ww_rt_mutex.c:#include "rtmutex.c"

or do I miss something here?
I tried with PREEMPT_RT enabled and disabled. Also with and without
LOCKDEP in case it makes a change.

> Thanks,
> 
> Bart.

Sebastian

  reply	other threads:[~2026-05-05 14:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-05  2:26 [PATCH v2] locking/rtmutex: Annotate API and implementation Bart Van Assche
2026-05-05  7:01 ` Sebastian Andrzej Siewior
2026-05-05  7:24   ` Bart Van Assche
2026-05-05  7:32     ` Sebastian Andrzej Siewior
2026-05-05  7:50       ` Bart Van Assche
2026-05-05 14:03         ` Sebastian Andrzej Siewior [this message]
2026-05-05 15:26           ` Bart Van Assche
2026-05-05 16:14             ` Sebastian Andrzej Siewior
2026-05-05 10:55 ` [tip: locking/core] " tip-bot2 for Bart Van Assche
2026-05-05 16:12 ` [PATCH v2] " Sebastian Andrzej Siewior
2026-05-05 20:05   ` Bart Van Assche
2026-05-06  7:35     ` Sebastian Andrzej Siewior
2026-05-06  9:53       ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260505140353.KoacwFc_@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=ast@kernel.org \
    --cc=boqun@kernel.org \
    --cc=bvanassche@acm.org \
    --cc=clrkwllms@kernel.org \
    --cc=elver@google.com \
    --cc=joel.granados@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=vbabka@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox