From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDFC4282F2F; Tue, 5 May 2026 13:26:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777987613; cv=none; b=Aw56n5BAZkj8w+cZ12uEdyiXGU3CKNjm/XTna35VLGDtSgbQROhCobc0qeBjtHKXiiaUUPbi7s38unq1JLJ4Jk1ZchTFucjGOnMBBRI1LBx+JaT3Btr2aet15/jMzzajmAJgLY8cmhQoQfX4FNBPoRj54/7F4ox8IaOf+5MDgKw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777987613; c=relaxed/simple; bh=AUXwHVKBn5W1eru+voELDFQxjrZF0KYACsGVpH6XKFU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RzJhsAiiwNrV1+FKEp2ADq6An4/LqpfaBwEZkKHmsXCdTLcEaDXfPhUT+xT0xF776gP56i577n4Cy12P2Weq+RVAYntCfcrIz44cHVHQbWBlfADwhRPfXfTiqAFh9e3HK36SxBOpi/8Ru8V22vu9Vk4ygiywQU7UQnrOlPflswo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=g9CuiBRR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="g9CuiBRR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3779BC2BCB4; Tue, 5 May 2026 13:26:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777987613; bh=AUXwHVKBn5W1eru+voELDFQxjrZF0KYACsGVpH6XKFU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=g9CuiBRRD2GQ3crVD7g2sldjPo9Gqf162pDs7Dzc6kNWFdMD16gKZ1tsnlkv1nYTu g8HJOm23VOhr9H0hJ2ApihrfBbaZMGHjMGY2k1YjRB65Ml9y088R32VPo4n8qcyKb/ ezb1y4dmC6nw1bLetW11QXuOZjiR10IhPj9JNK2cTol7n1y+KHfknjmV63dfRhYaYN lUik2uE/TUsd0MSvgw2235fA1RDxBDKFnlAoooOVJNYS5dC3vp8M98kZcrPbhY1U0K FX3uE+GPh8tovtaQf+KsNHwe3ZWhvHfYHX5gPx2NhDeBEW1feuHJvxpF7L8r+KQF4V clYCghsv+Vvbg== Date: Tue, 5 May 2026 14:26:40 +0100 From: Jonathan Cameron To: "Sabau, Radu bogdan" Cc: Andy Shevchenko , Lars-Peter Clausen , "Hennerich, Michael" , David Lechner , "Sa, Nuno" , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , Liam Girdwood , Mark Brown , Linus Walleij , Bartosz Golaszewski , Philipp Zabel , Jonathan Corbet , Shuah Khan , "linux-iio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-pwm@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-doc@vger.kernel.org" Subject: Re: [PATCH v9 3/6] iio: adc: ad4691: add triggered buffer support Message-ID: <20260505142640.49cde0ca@jic23-huawei> In-Reply-To: References: <20260430-ad4692-multichannel-sar-adc-driver-v9-0-33e439e4fb87@analog.com> <20260430-ad4692-multichannel-sar-adc-driver-v9-3-33e439e4fb87@analog.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit > > > > + for (i = 0; i < ARRAY_SIZE(ad4691_gp_names); i++) { > > > + irq = fwnode_irq_get_byname(dev_fwnode(dev), > > > + ad4691_gp_names[i]); > > > + if (irq > 0) > > > + break; > > > > This is problematic in case the above returns EPROBE_DEFER. Can you confirm > > it > > may not ever happen? (Note, I don't know the answer.) > > > > You are right, thanks for this! I'm missing something. Why is that a problem? Driver will return the error and a dev_err_probe() is used so it won't print anything. So probe will fail which is exactly what we want. Jonathan >