From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 687C436404D for ; Tue, 5 May 2026 16:19:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777997949; cv=none; b=a5l/GPJJcXYfJ2ZjPYJfJUMwGK80UfTdOT3mIMG8VN3yANKsMW+sApRCXz4JoX3aGqHuF3u6GlpdlrbnDqA0Il/yr9P7EcN6Q5tun+9oGrtxhypctOcQcuDCLYn1C1yZ7UsGJTuRjKFc3wpIkSUr8zHMYyOz7W+pqV177naQf5A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777997949; c=relaxed/simple; bh=0FGci3zE/Iz+tnNnq/MJWTPU0O3SqHroJAcKL8EBw2U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=h67HS6KhFbk0GgKEvdEkBtHB7THn05tTHLhFD8krWZdHb62IGV9ermydfuZA9jYrpDzGnjGCPhmvqH3Q76x3a850DmeSYr3/eWb3v7GKRdlGVIr2FfWZxfKD+EBFfHkchT2MZ7UNQor7bUmnIfWFZNrkiH8WF+OgLhiUfy9P1QY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=my0HE1dJ; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="my0HE1dJ" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 48AC71C2B; Tue, 5 May 2026 09:19:02 -0700 (PDT) Received: from localhost (e132581.arm.com [10.1.196.87]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 41F1C3F763; Tue, 5 May 2026 09:19:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1777997947; bh=0FGci3zE/Iz+tnNnq/MJWTPU0O3SqHroJAcKL8EBw2U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=my0HE1dJYtMJcmTfB2IP3Fi2ad+vPk24XOy1aJWhajcIpcYNeGp3nR9aXY0mMRQwB jcnJeUyjXVV9N/bo03sDOOBcL3afSQYwSRkGgHy/kvLpc42HdWGLX+9kJApyuNvp18 olgXgI+RS5mqPpM//FdB6BVWwaEVL16Qqs2TaXOc= Date: Tue, 5 May 2026 17:19:05 +0100 From: Leo Yan To: Yeoreum Yun Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, suzuki.poulose@arm.com, mike.leach@arm.com, james.clark@linaro.org, alexander.shishkin@linux.intel.com, jie.gan@oss.qualcomm.com Subject: Re: [PATCH v6 02/13] coresight: etm4x: fix underflow for nrseqstate Message-ID: <20260505161905.GA3778514@e132581.arm.com> References: <20260422132203.977549-1-yeoreum.yun@arm.com> <20260422132203.977549-3-yeoreum.yun@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260422132203.977549-3-yeoreum.yun@arm.com> On Wed, Apr 22, 2026 at 02:21:52PM +0100, Yeoreum Yun wrote: > TCRSEQEVR is implemented only when TCRIDR5.NUMSEQSTATE is 0b100, > in which case n ranges from 0 to 2; otherwise, TCRIDR5.NUMSEQSTATE is 0b000. > > Therefore, drvdata->nrseqstate should be checked before entering the loop. Since TRCSEQEVRn (n=0~2), to avoid confusion, we also need to rename ETM_MAX_SEQ_STATES to ETM_MAX_SEQ_TRANSITIONS and define it as 3: #define ETM_MAX_SEQ_TRANSITIONS 3 Then we don't allocate 4 items but use only 3 of them. Thanks, Leo