Re: [PATCH v3 07/10] iio: accel: mma8452: use local struct device

Sanjay Chitroda
2026-05-07T02:17:11Z

On 6 May 2026 2:49:33 pm IST, Joshua Crofts <joshua.crofts1@gmail.com> wrote:
>On Tue, 5 May 2026 at 19:50, Sanjay Chitroda <sanjayembeddedse@gmail.com> wrote:
>> @@ -1552,7 +1552,7 @@ static int mma8452_probe(struct i2c_client *client)
>> struct iio_dev *indio_dev;
>> int ret;
>
>As mentioned, you added the local struct device in patch 5, making
>this really confusing (and potentially breaking if only a partial set
>of the patches would be picked up). Please add it here.
Hi Joshua,

Thank you for the review.
I have prepared series as there is some dependency on earlier change with respect to current. If we pick random change it has high changes to fail.

FYI, compilation is validated on each change so if someone take few initial patch then hopefully nothing would break. Additionally, if we plan to take random patches from series based on some review comment or requirement then I would resend new series specific to that patches to avoid any break.

>