From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32D6647DFA6 for ; Tue, 5 May 2026 17:46:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778003212; cv=none; b=MgCnhBwbQUOAGhmz6aU/rcdyeXkY+zPyCtH13RCOdx/Pmc/QDOISZ+r0XKHmQ+WKv0a+Gs+oNo07bnJjpV8jYHW6v6N5cKgatmvQ+ZNfKT0o66o0fiky85YgfEN8ZXJOV12dsILAaGu98VxYVxanApt93Rt29IORmj85HrBuPPE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778003212; c=relaxed/simple; bh=dVoROqRTarCI3ArcUvyKEvYVz3wLegfbNtBsFww7WQE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=OJ+mMlSpXzy15WJqz9uLgygnvT8QJfh9KfOTvF8dtA050FEkiDiAuoJa12B5m3EuOZvT7kOwfrxlpEHlZ4N0ccwR1kM5sS+MCS9nNQy/Lukx4yEkpqp9Gg72GZ/fwPXCpIT6qX6h96VsJHTYfNFzaQgZ31Na2aphZ2Woxih3Y3Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZJxniXGe; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZJxniXGe" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2ab232cc803so24612125ad.3 for ; Tue, 05 May 2026 10:46:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778003210; x=1778608010; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HZZevsa28Z0lnZm6lTUzLbhzzlq2jzJL2yxl54eCq38=; b=ZJxniXGet69UD9oYhI2u09xa03IOvvKWEJFpYrfo1mfupfxeEVaRsyWFLoJmtLjyn7 vPQxxDJl9bnUpAVHqC7D52/BlAGlHY8Uij1B0g/kpjbIi9+E1NAmUhFDMOqKn1Rb+OIR PckXHCuJIUG1OvJXZAk5qqdKblGvsusYzQNxhBF4OkVYq4AUEOxqK6diPP2tYZEgxNdw BUc9rRAu16ThFaD37Wi6FBd9vTVn0GmSiKYVBpgFqIzQ9x75P3udIkgT9ohzRt0Yi2g9 Tt/GvvwOaLAKEuPc1D3b+TiUnacLkf92ogTlJlYxRiUdmARMEnbc42M11lEVQOFclDvH T0Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778003210; x=1778608010; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HZZevsa28Z0lnZm6lTUzLbhzzlq2jzJL2yxl54eCq38=; b=CknabESqaurgUlVoD3zjba0zP5o8N+rAfZK0EroDm2LZY3qZ8mg2GFf20UP5oEw60U n1wFpCiDmdmI+n14mlu+szpOkY2JoqQdnoDqpvodhJHpIUaEEmHgNiAq6e0nk+2MVm62 LhO/+DPhLP5LPn2yPfLZEpPlJKwQWw5vSFfQ5zVQHie3iVWxuNWY9xaEWtIShYYC2KxL BdCByXUE0rlwzeIwZHaRmbQ4l8Ga9JmxzvOtU29kykq9jDbUeMuaX/N/ajAICpiuSCWD Sy4B3QCqnVM8uxvFd1zZsjQ+uZJXd3kpXP9oNONnbJ5wpinkwZZ/OQA0Y5DU7g/c3ADM Oalg== X-Forwarded-Encrypted: i=1; AFNElJ84EB3o4eO3CIPf3GVOUURyIfEb1cVGoeB8eCHz4EE+sas+sdLBJ0nww1z874VPknVBlUQvFAYYChAXRqM=@vger.kernel.org X-Gm-Message-State: AOJu0YxHB3PFutWZ0N3alfFdRDin0UO0CBpABmDNjc2CWvr/vwstPzdf Mta4H/lxCf6J+kiHyCIeu5gyGyWOecxdSM4CLNB4kJJ4R751DGfcFaxW X-Gm-Gg: AeBDietZnA96VSISWZBLFsYtMkA8FH8mzsbKmcagEqdr5eMu76cugpZmtrlwdGwAzDm 9DWFaRr8EKHBETX/LUjLoNcedkw0aXdXueQimSmw3/+0uKnyPbFDLe+2KvQmx6O1AFZ26LhN+EY X+uecmz6Qr8CRnLSz3I4OtSCSPejgu8XBZKqieQKQs1cFRkZ090vxz8SMjuVgFDUObhxL4DbfNV KXScaPA43Wq8kLsRileigFKgHvE2V9NPWMkNdmCFVk5sT4RHBGiuBCvJvHtg+1SlNzn52+4Mff6 QIF8SXwtjBeoLOmBmjo18r3rDYYJQdRnmLJNilk4IJX6ukXAh25Efl9EaR+EJq7xSA99q4m4+9W ngRXmPyuXe2ACjvSXq4eGHRc41aEoldtaCUghFx9TiI5xefhcupygJUCVA555BP9TzsdmAWp3Jq Uv3R/CxGgO5eqcm8FyQ08Ge7i69BNDgyaG8HL6K5FGpoJoqkkbgJwIZkX+7GE= X-Received: by 2002:a17:902:da87:b0:2ba:73c4:4a77 with SMTP id d9443c01a7336-2ba73c44b95mr8864685ad.9.1778003210567; Tue, 05 May 2026 10:46:50 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b9cae3b169sm148663355ad.63.2026.05.05.10.46.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 10:46:50 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, sanjayembeddedse@gmail.com, sakari.ailus@linux.intel.com, christoph.muellner@theobroma-systems.com, martink@posteo.de, mfuzzey@parkeon.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 01/10] iio: accel: mma8452: handle I2C read error(s) in mma8452_read() Date: Tue, 5 May 2026 23:16:31 +0530 Message-Id: <20260505174640.3998281-2-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260505174640.3998281-1-sanjayembedded@gmail.com> References: <20260505174640.3998281-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Sanjay Chitroda Currently, If i2c_smbus_read_i2c_block_data() fails but mma8452_set_runtime_pm_state() succeeds, mma8452_read() returns 0. As a result, the caller mma8452_read_raw() assumes the read was successful and proceeds to use a buffer containing uninitialized stack memory. Add proper checking of the I2C read return value and propagate errors to the caller. Fixes: 96c0cb2bbfe0 ("iio: mma8452: add support for runtime power management") Signed-off-by: Sanjay Chitroda --- drivers/iio/accel/mma8452.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 15172ba2972c..cefc7cf4bd83 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma8452.c @@ -252,6 +252,8 @@ static int mma8452_read(struct mma8452_data *data, __be16 buf[3]) ret = i2c_smbus_read_i2c_block_data(data->client, MMA8452_OUT_X, 3 * sizeof(__be16), (u8 *)buf); + if (ret < 0) + return ret; ret = mma8452_set_runtime_pm_state(data->client, false); -- 2.34.1